[Bug 25285] New: Wrong message when plugin minimum version isn't met
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25285 Bug ID: 25285 Summary: Wrong message when plugin minimum version isn't met Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: victor@tuxayo.net QA Contact: testopia@bugs.koha-community.org (not sure about the bug category) == Test plan == - Install the Kitchen Sink plugin: https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases - (the .kpz) - go to the plugin directory. - example: /var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions - edit minimum_version to be above you koha version - go plugin home page - you should see «Warning: This report was written for a newer version of Koha. Run at your own risk.» - this wrong! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25285 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24631 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25285 --- Comment #1 from Victor Grousset/tuxayo <victor@tuxayo.net> --- When bug 24631 will be in master, the file to edit will be: /var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions/KitchenSink/PLUGIN.yml -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25285 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25285 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Tools |Plugin architecture CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25285 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Hi Victor, what should the message be instead? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25285 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25285 --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Found! https://git.koha-community.org/Koha-community/Koha/src/commit/940c0e319a1df9...
Warning: This plugin was written for an older version of Koha. Run at your own risk.
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25285 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Keywords|Academy | CC| |tomascohen@gmail.com Summary|Wrong message when plugin |Wrong message when plugin |minimum version isn't met |required Koha version isn't | |met Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25285 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 131517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131517&action=edit Bug 25285: Fix wrong message about required Koha version in plugins When you install a plugin that requires a newer Koha version, it reports this: << Warning: This report was written for a newer version of Koha. Run at your own risk.
It is wrong in a couple ways: - It is not a report. - It feels like it dates back to when plugins were only run i.e. pre-hooks, etc. This patch proposes a change to reflect this. To test: 1. Verify the string changes make sense to you 2. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25285 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25285 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131517|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 131531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131531&action=edit Bug 25285: Fix wrong message about required Koha version in plugins When you install a plugin that requires a newer Koha version, it reports this: << Warning: This report was written for a newer version of Koha. Run at your own risk.
It is wrong in a couple ways: - It is not a report. - It feels like it dates back to when plugins were only run i.e. pre-hooks, etc. This patch proposes a change to reflect this. To test: 1. Verify the string changes make sense to you 2. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25285 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131531|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131585&action=edit Bug 25285: Fix wrong message about required Koha version in plugins When you install a plugin that requires a newer Koha version, it reports this: << Warning: This report was written for a newer version of Koha. Run at your own risk.
It is wrong in a couple ways: - It is not a report. - It feels like it dates back to when plugins were only run i.e. pre-hooks, etc. This patch proposes a change to reflect this. To test: 1. Verify the string changes make sense to you 2. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25285 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Lol, I've fixed this a few times over the years and it always seems to creep back in somehow. Anywho.. passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25285 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25285 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21866 Severity|enhancement |minor --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Maximum version text was fixed by Bug 21866. This is no enhancement, I change to minor. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21866 [Bug 21866] Rephrase "Warning: This *report* was written for an older version of Koha" to refer to plugins -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25285 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25285 --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25285 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.05 released in| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org