[Bug 17648] New: ACCTDETAILS notice does not show in notices.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Bug ID: 17648 Summary: ACCTDETAILS notice does not show in notices.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The ACCTDETAILS notice apparently bypasses message_queue; notices are sent directly to the linux mail queue. This may be useful from the standpoint that the message is sent immediately, but it should still be added to message_queue with status='sent', so that it's available when looking at the borrowers notices. --Barton -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is intentional as it is designed to send out clear text passwords (which might be debatable anyway). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- So yeah, we can't just add it without more thought, but it would be nice to make it possible to see that one has been sent. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux@biblibre.co | |m --- Comment #3 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- All alerts (that are sent directly and not queued in message_queue) are not displaid in notices. Should we have another way to store them or just had them to message_queue ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think I'd prefer "one place" for them. But we might need some adjustments. For example the list invites can be sent to arbitrary email addresses - so there is no account you'd see them from. maybe a view of the message queue somewhere - we use a report for that right now "messages sent out today" in our installations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27812 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- If we realize 27812 we could add it to the messagequeue after. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27812 [Bug 27812] Remove the ability to transmit a patron's plain text password over email -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 131165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131165&action=edit Bug 17648: ACCTDETAILS notice does not show in notices.pl The ACCTDETAILS notice apparently bypasses message_queue; notices are sent directly to the linux mail queue. Test Plan: 1) Apply this patch 2) Create a new patron with an email address 3) Note the patron's ACCTDETAILS notice shows in the patron's messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I don't we should do this before we have resolved bug 27812 that I have tried to give another push. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #7)
I don't we should do this before we have resolved bug 27812 that I have tried to give another push.
Agreed! I build this on top of 27812 so when I submitted my updated patches, this one got updated a couple minutes before that one :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131165|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131199&action=edit Bug 17648: ACCTDETAILS notice does not show in notices.pl The ACCTDETAILS notice apparently bypasses message_queue; notices are sent directly to the linux mail queue. Test Plan: 1) Apply this patch 2) Create a new patron with an email address 3) Note the patron's ACCTDETAILS notice shows in the patron's messages Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131200&action=edit Bug 17648: (QA follow-up) Further code cleaning We actually have a Koha::Patron method to do all the work of finding the right patron primary email address for notices.. we can use that here instead of doing it long hand. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great improvement, all works ass expected.. Signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9097 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 [Bug 9097] 'Welcome mail' for new library users -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131202&action=edit Bug 17648: (QA follow-up) Restore imediate sending of the notice The original notice was sent using SendAlerts, which triggers immediately on submission and doesn't wait for the cron task. This patch restores that immediacy and also fixes a bug in the imports on the original patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ACCTDETAILS notice does not |ACCTDETAILS notice doesn't |show in notices.pl |show in the notices tab in | |staff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29005 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 [Bug 29005] Add support for AutoEmailUser similar to AutoEmailOpacUser to patron imports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131202|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131245&action=edit Bug 17648: (QA follow-up) Restore imediate sending of the notice The original notice was sent using SendAlerts, which triggers immediately on submission and doesn't wait for the cron task. This patch restores that immediacy and also fixes a bug in the imports on the original patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, this all works now.. but only with my followups as they fix the imports.. I decided not to doctor Kyles original patch ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30214 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30214 [Bug 30214] Add option to send ACCDETAILS notice for new patrons added via self registration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|9097 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 [Bug 9097] 'Welcome mail' for new library users -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131199|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131403&action=edit Bug 17648: ACCTDETAILS notice does not show in notices.pl The ACCTDETAILS notice apparently bypasses message_queue; notices are sent directly to the linux mail queue. Test Plan: 1) Apply this patch 2) Create a new patron with an email address 3) Note the patron's ACCTDETAILS notice shows in the patron's messages Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131200|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131404&action=edit Bug 17648: (QA follow-up) Further code cleaning We actually have a Koha::Patron method to do all the work of finding the right patron primary email address for notices.. we can use that here instead of doing it long hand. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131245|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131405&action=edit Bug 17648: (QA follow-up) Restore imediate sending of the notice The original notice was sent using SendAlerts, which triggers immediately on submission and doesn't wait for the cron task. This patch restores that immediacy and also fixes a bug in the imports on the original patch. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17648 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org