[Bug 18267] New: Update price and tax fields in EDI to reflect DB changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Bug ID: 18267 Summary: Update price and tax fields in EDI to reflect DB changes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campbell@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org The aqorders price and tax fields were renamed/ added to in bug 13321 but the changes were not propagated to EDI.pm which is still creating orders with the prices in the old fields. Update the fields used and check the correct Edifact elements are being assigned -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 61600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61600&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 61601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61601&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #3 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 61602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61602&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #4 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Patches should apply to both master and 16.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61602|0 |1 is obsolete| | --- Comment #5 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 61605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61605&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #6 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 61606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61606&action=edit proposed patch Add test for new method added to line -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Barry Cannon <bc@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bc@interleaf.ie --- Comment #7 from Barry Cannon <bc@interleaf.ie> --- Applied to customer instance and confirmed working. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |nick@bywatersolutions.com --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Marking as bug, asking Kyle to look as he is working with EDI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Code looks good at first glance. But we are missing unit tests here. Sub process_invoice is changed in this patch set and sub update_price_from_invoice is added. Although it seems to be a private sub and could have been marked as such with an underscore. Apart from missing tests for the complete Koha/EDI.pm module, the patches do not have any test plans. I understand that it takes time to write unit tests, but if we keep passing by exception, they will not be written. Minor detail: The four titles "Proposed patch" do not really convey much information. We miss signoff lines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61600|0 |1 is obsolete| | --- Comment #10 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 65244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65244&action=edit Fix unexported interface to Acq routine routine is meant to be a standard interfacre but is not exported -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61601|0 |1 is obsolete| | Attachment #61605|0 |1 is obsolete| | Attachment #61606|0 |1 is obsolete| | --- Comment #11 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 65245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65245&action=edit patch to populate price fields using new methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #12 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 65246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65246&action=edit patch to populate price fields using new methods (16.11 version) main patch uses newer interface to borrowers which is not available before 17.05 this uses the direct dbix interface as previously -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #13 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 65250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65250&action=edit Remove dead code - price method replaced by more specific methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #14 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 65251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65251&action=edit Record tax rate from the invoice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #15 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 65252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65252&action=edit Unit Tests for tax-rate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #16 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 65253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65253&action=edit Unit tests for price methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #17 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 65254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65254&action=edit Update doc for changed methods perldoc was for old methods update to reflect the new ones -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.bourgault@inlibro.com --- Comment #18 from David Bourgault <david.bourgault@inlibro.com> --- Both test files pass without an issue, but without a test plan I have no idea how to test the feature. Also I don't think this needed to be 8 patches, it just makes it more confusing IMHO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight@lboro.ac.uk --- Comment #19 from Jon Knight <J.P.Knight@lboro.ac.uk> --- No longer appears to apply cleanly to master or 16.11.x heads with a git bz apply. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |katrin.fischer@bsz-bw.de --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jon, in this case please set 'Patch doesn't apply' as status. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #21 from Colin Campbell <colin.campbell@ptfs-europe.com> --- I have no problem appling these patches to a clean master or 16.11 branch - can Jon supply more details -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Colin, there is a tiny conflict in EDI.pm: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 18267 populate_order_with_prices should be exported Applying: Bug 18267 Populate new price fields in EDI Processing Applying: Bug 18267 Populate new price fields in EDI Processing Using index info to reconstruct a base tree... M Koha/EDI.pm M Koha/Edifact/Line.pm Falling back to patching base and 3-way merge... Auto-merging Koha/EDI.pm CONFLICT (content): Merge conflict in Koha/EDI.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 18267 Populate new price fields in EDI Processing The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/patch-to-populate-price-fields-using-new-methods-1-4SHHyf.patch Hate to admit, but not sure which is the right line, can you take a look? Leaving status, another tester might have a better understanding of it than I do. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #23 from Colin Campbell <colin.campbell@ptfs-europe.com> --- The error is because there are teo versions of patch populate price fields using new methods one for 16.11.x and one for all subsequent versions applying both versions will fail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #24 from Jon Knight <J.P.Knight@lboro.ac.uk> --- (In reply to Colin Campbell from comment #23)
The error is because there are teo versions of patch populate price fields using new methods one for 16.11.x and one for all subsequent versions applying both versions will fail
Ah ha, yes that's was my issue. Now applies cleanly if I run interactive 'git bz apply 18267' and delete the line for patch 65246. Is there anything to test before signing off other than making sure that both t/EdiInvoice.t and t/Edifact.t run successfully (they do on master)? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #25 from Colin Campbell <colin.campbell@ptfs-europe.com> --- (In reply to Jon Knight from comment #24)
(In reply to Colin Campbell from comment #23)
The error is because there are teo versions of patch populate price fields using new methods one for 16.11.x and one for all subsequent versions applying both versions will fail
Ah ha, yes that's was my issue. Now applies cleanly if I run interactive 'git bz apply 18267' and delete the line for patch 65246. Is there anything to test before signing off other than making sure that both t/EdiInvoice.t and t/Edifact.t run successfully (they do on master)?
No the tests cover the new methods. Thanks for testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #26 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Created attachment 68536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68536&action=edit Bug 18267 Update doc for Koha::EDI Document change to _discounted_price's parameters and wrapper around new Acquisitions routine Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65244|0 |1 is obsolete| | Attachment #65245|0 |1 is obsolete| | Attachment #65250|0 |1 is obsolete| | Attachment #65251|0 |1 is obsolete| | Attachment #65252|0 |1 is obsolete| | Attachment #65253|0 |1 is obsolete| | Attachment #65254|0 |1 is obsolete| | Attachment #68536|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68707&action=edit Bug 18267 populate_order_with_prices should be exported Although routine is used in acqui scripts, access to it is by backdoor methods. Allow it to be exported in a standard way to allow more maintainable code. Effectively this patch merely documents that this routine is part of C4/Acquisition's interface and allows users to import it in the standard way. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68708&action=edit Bug 18267 Populate new price fields in EDI Processing New price fields have been added to aqorders with the result that sites using EDI found prices appearing as zero in displays as the prices were not duplicated to the nrew fields as in manual acquisitions. Invoicing now records values using the standard populate_order_with_prices routine from C4::Acquisitions However when creating an order from an edifact quote the routine makes invalid assumptions about what data is available. In a quote prices are always tax inclusive, and no information is supplied on the tax rate and amount, these appear in the invoice message on receipting. Koha::EDI therefore sets the relevant fields directly in order creation. To clarify the field used, we now call the price_info method rather than the older price method. When calculating discount, we now check if a discounted price has been supplied. (In practice we dont see this but we are prepared if it occurs ) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68709&action=edit Bug 18267 Remove obsolete Edifact::Line price method The old price method duplicated the function of price_info as this was the only type of price field in quotes. The more specific field is now used and the old method is no longer called. Remove the obsolete code Add comment documenting the allowed values in the Edifact PRI segment Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68710&action=edit Bug 18267 - Record tax rate on receipt from EDI Invoice As part of the newly introduced price fields there is also a tax_rate_on_receiving that needs setting. This records the main tax rate on receipting. Edifact has the potential to be more complex than Koha allows i.e. the line amount may be made of different amounts (incorporating servicing, etc) at different tax rates. This concentrates on the main tax rate. The tax rate will be receiced as a percentage value e.g. 20.00 need to convert to a decimal fraction 0.20 as assumed in Koha calculations Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68711&action=edit Bug 18267 Add test for new tax_rate method Test return for new method added to Edifact::Line Note tax rate is not specified in edifact quotes so tax_rate_on_ordering can not be set. Tax rate is only specified in invoice messages Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68712&action=edit Bug 18267 Add tests for all price methods Add test for price_gross in addition to price_net in Invoices Test price_info and price_info_inclusive in quotes NB test is that price_info_inclusive returns undef which we expect to be the normal condition Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68713&action=edit Bug 18267 Update doc for Koha::EDI Document change to _discounted_price's parameters and wrapper around new Acquisitions routine Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68714&action=edit Bug 18267 [QA Followup] - Supress warnings Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Lack of tests and POD coverage. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65246|0 |1 is obsolete| | Attachment #68707|0 |1 is obsolete| | Attachment #68708|0 |1 is obsolete| | Attachment #68709|0 |1 is obsolete| | Attachment #68710|0 |1 is obsolete| | Attachment #68711|0 |1 is obsolete| | Attachment #68712|0 |1 is obsolete| | Attachment #68713|0 |1 is obsolete| | Attachment #68714|0 |1 is obsolete| | --- Comment #36 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 113569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113569&action=edit Patch to handle Price and related information from Quotes and Invoices These modified routines have been running in production and have been tested against all known Edifact vendors messages, both in parsing and populating the database and ensuring the total amounts match the summary totals in the incoming files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|--- |Small patch --- Comment #37 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Handles tax and discount information from the vendor and deals with different encodings of quantity. Ensures all populatable fields are handled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #38 from Colin Campbell <colin.campbell@ptfs-europe.com> --- *** Bug 17279 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #39 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113597&action=edit Bug 18267 Refactored Edifact Price Calculations Refactored the price calculations for Quotes and Invoices This takes in to account various combinations used by different vendors. Makes the extraction of basic price, quantity and tax information more reliable. Tests are in Edifact.t and EdiInvoice.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113569|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #40 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #41 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113897&action=edit Bug 18267: (QA follow-up) fix typo: overriden => overridden -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #42 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Hi, a small typo was found while trying the QA script with various patches to troubleshoot issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Victor Grousset/tuxayo from comment #41)
Created attachment 113897 [details] [review] Bug 18267: (QA follow-up) fix typo: overriden => overridden
Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.07 released in| | --- Comment #44 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Backported to 20.05 for 20.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.11.00, 20.05.07 |20.11.00, 20.05.07, released in| |19.11.13 --- Comment #45 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.11.x branch for 19.11.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org