https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Code looks good at first glance. But we are missing unit tests here. Sub process_invoice is changed in this patch set and sub update_price_from_invoice is added. Although it seems to be a private sub and could have been marked as such with an underscore. Apart from missing tests for the complete Koha/EDI.pm module, the patches do not have any test plans. I understand that it takes time to write unit tests, but if we keep passing by exception, they will not be written. Minor detail: The four titles "Proposed patch" do not really convey much information. We miss signoff lines. -- You are receiving this mail because: You are watching all bug changes.