[Bug 19546] New: Can't locate Mojolicious/Plugin/Koha/REST/Plugin/ Pagination.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Bug ID: 19546 Summary: Can't locate Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: REST api Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl See bug 19196 and my comment 40. What happened? For just a short time I did not see the error. I merged the last changes on master, ran updatedatabase, restarted plack, flushed the cache and there it was again: Error while loading /etc/koha/plack.psgi: Can't load application from file "api/v1/app.pl": Can't locate Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm: ./Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm: Permission denied at (eval 1299) line 1. This effectively breaks opac and staff client completely until I comment the change for the Pagination plugin again in Koha/REST/V1.pm. Note that nothing special happened between Friday and now on this virtual Jessie box.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can't locate |Can't locate |Mojolicious/Plugin/Koha/RES |Mojolicious/Plugin/Koha/RES |T/Plugin/Pagination.pm |T/Plugin/Pagination.pm | |breaks opac and staff Depends on| |19196 CC| |stefan.berndtsson@ub.gu.se, | |tomascohen@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196 [Bug 19196] Add pagination helpers -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Stopped/started apache, memcached, plack. To no effect. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- So just for the record: I have a very simple workaround (but Tomas wont like it very much): Just comment the line until this path issue has been resolved completely. Any other ideas ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I never managed to reproduce it. Are you sure your setup is pointing to the right PERL5LIB? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi from comment #3)
I never managed to reproduce it. Are you sure your setup is pointing to the right PERL5LIB?
Ha. If it wasn't, I really should have had so much more problems.. And what about uncommenting a line in a library that is not used? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |minor --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #4)
(In reply to Tomás Cohen Arazi from comment #3)
I never managed to reproduce it. Are you sure your setup is pointing to the right PERL5LIB?
Ha. If it wasn't, I really should have had so much more problems.. And what about uncommenting a line in a library that is not used?
Just for the record: Paths like PERL5LIB and KOHA_HOME are not the problem (verified). It is something deeper in the install. Combination of libraries etc? Since nobody doing a fresh install can confirm the problem, I will lower the severity of this bug first before closing it ;) Picking minor for my dev box.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Closing, please reopen if it appears again. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WORKSFORME |--- CC| |gmcharlt@gmail.com --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Reopening. Saw this happen on a Debian 8.10 system with a fresh install of 17.11.02 from package. A (truly terrible workaround) got Plack running: /usr/share/perl5/Mojolicious/Plugin && ln -s /usr/share/koha/lib/Koha Koha Version of Mojolicious is 7.21 from the 7.21+dfsg-1~kohadev1 package. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Galen Charlton from comment #7)
Reopening. Saw this happen on a Debian 8.10 system with a fresh install of 17.11.02 from package.
A (truly terrible workaround) got Plack running:
/usr/share/perl5/Mojolicious/Plugin && ln -s /usr/share/koha/lib/Koha Koha
Version of Mojolicious is 7.21 from the 7.21+dfsg-1~kohadev1 package.
I don't manage to reproduce it. I have installed 17.11.02-1 (17.11 repo) on a clean box: $ vagrant init debian/jessie64 only added port mappings to be able to access Koha (in Vagrantfile): config.vm.network :forwarded_port, guest: 80, host: 8080, auto_correct: true # OPAC config.vm.network :forwarded_port, guest: 8080, host: 8081, auto_correct: true # INTRA I then added 8080 to /etc/apache2/ports.conf and tweaked /etc/apache2/sites-enabled/kohadev.conf so intranet uses port 8080. Once I populate the DB I manage to access the API (with and without Plack enabled). The only problem I noticed is that the rewrite bits for the API (in apache) are not working, so I needed to use /api/v1/app.pl/api/v1/patrons to access the API when Plack is disabled. If you still have the VM in which you see the failure, could you try using a + sufix in the V1.pm line that includes the pagination plugin ? I'm not sure right now what was the way to avoid Mojolicious prefixing hte plugin name. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I still have this problem on an older Jessie 8 box. A fresh Jessie install on another box does not have it. Looks to me that it is connected to the install history of various related dependencies to the Mojo stuff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Marcel de Rooy from comment #9)
I still have this problem on an older Jessie 8 box. A fresh Jessie install on another box does not have it. Looks to me that it is connected to the install history of various related dependencies to the Mojo stuff.
Can you share that VM image? Send me a link by pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Well, this is interesting. On my still reasonable fresh VM Jessie 8, this morning I got: Error while loading /etc/koha/plack.psgi: Can't load application from file "/usr/share/koha/devclone/api/v1/app.pl": Can't locate Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm: ./Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm: Permission denied at (eval 1511) line 1. I am setting the Severity higher again. This really needs more attention from the Mojolicious guys! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Marcel de Rooy from comment #11)
Well, this is interesting. On my still reasonable fresh VM Jessie 8, this morning I got:
Error while loading /etc/koha/plack.psgi: Can't load application from file "/usr/share/koha/devclone/api/v1/app.pl": Can't locate Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm: ./Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm: Permission denied at (eval 1511) line 1.
I am setting the Severity higher again. This really needs more attention from the Mojolicious guys!
Can you share your VM? I never managed to reproduce so there's nothing I can do right now! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_05_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
Can you share your VM? I never managed to reproduce so there's nothing I can do right now! Sorry, I can't. It is not mine :) But it should not be that hard to reproduce since these are just gitified
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi from comment #12) package installs on Jessie8. One of the last things I did on the newest box was cpanminussing Parallel::ForkManager during QA. The module itself may not be the problem, and it may just be coincidental but this problem is about permissions and paths for perl libraries etc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Claudio <costalc@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I managed to reproduce. This is the same issue introduced by Perl 5.18 we face with cronjobs. I'll provide a patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 72365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72365&action=edit Bug 19546: Run starman from the instance's home dir This patch makes koha-plack jump into the instance's home directory to run. It is required because Perl 5.18 introduced a breaking change that makes perl die if @INC includes directories for which the user doesn't have read permission, and need to be traversed when querying for a lib. This is the case of '.', which is introduced automatically into @INC until Perl 5.26 (which removes the 'feature'). The Mojolicious::Plugins lib prefixes the plugin names with 'Mojolicious::Plugin' so it first looks (for example) for Mojolicious::Plugin::Koha::REST::Plugin::Pagination (Pagination is just the first one on the list). When it looks for it at '.' it dies (because of Perl's behaviour) so it doesn't query for the right namespace (the following to try). I only reproduced it in koha-testing-docker. To test, you just need to try this patched koha-plack and make sure it doesn't break due to this permissions issue. To test: - In your koha-testing-docker clone, run: $ docker-compose up -p test - Open a shell inside the container (on a separate terminal): $ docker exec -it test_koha_1 bash - From within the /root directory, restart plack: $ cd /root $ koha-plack --restart kohadev => FAIL: Logs show plack is broken due to permissions problems trying to find Mojolicious::Plugin::Koha::REST::Plugin::Pagination - Use the patched script from this patch: $ /kohadevbox/koha/debian/scripts/koha-plack --restart kohadev => SUCCESS: Plack runs fine, no error in the logs - Sign off :-D Note: people who has environments in which the problems is reproducible, please test this version of koha-plack and stamp your sign-off, PLEASE. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can't locate |Make koha-plack run Starman |Mojolicious/Plugin/Koha/RES |from the instance's |T/Plugin/Pagination.pm |directory |breaks opac and staff | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72365|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 72374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72374&action=edit Bug 19546: Run starman from the instance's home dir This patch makes koha-plack jump into the instance's home directory to run. It is required because Perl 5.18 introduced a breaking change that makes perl die if @INC includes directories for which the user doesn't have read permission, and need to be traversed when querying for a lib. This is the case of '.', which is introduced automatically into @INC until Perl 5.26 (which removes the 'feature'). The Mojolicious::Plugins lib prefixes the plugin names with 'Mojolicious::Plugin' so it first looks (for example) for Mojolicious::Plugin::Koha::REST::Plugin::Pagination (Pagination is just the first one on the list). When it looks for it at '.' it dies (because of Perl's behaviour) so it doesn't query for the right namespace (the following to try). I only reproduced it in koha-testing-docker. To test, you just need to try this patched koha-plack and make sure it doesn't break due to this permissions issue. To test: - In your koha-testing-docker clone, run: $ docker-compose up -p test - Open a shell inside the container (on a separate terminal): $ docker exec -it test_koha_1 bash - From within the /root directory, restart plack: $ cd /root $ koha-plack --restart kohadev => FAIL: Logs show plack is broken due to permissions problems trying to find Mojolicious::Plugin::Koha::REST::Plugin::Pagination - Use the patched script from this patch: $ /kohadevbox/koha/debian/scripts/koha-plack --restart kohadev => SUCCESS: Plack runs fine, no error in the logs - Sign off :-D Note: people who has environments in which the problems is reproducible, please test this version of koha-plack and stamp your sign-off, PLEASE. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy@rijksmuseum.nl Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Great. Solution sounds plausible. Will test and QA. Just wondering why perl would build @INC different sometimes (recall that the problem was not completely constant). Glad that I am not the author of this reverted perl feature ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72374|0 |1 is obsolete| | --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 72407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72407&action=edit Bug 19546: Run starman from the instance's home dir This patch makes koha-plack jump into the instance's home directory to run. It is required because Perl 5.18 introduced a breaking change that makes perl die if @INC includes directories for which the user doesn't have read permission, and need to be traversed when querying for a lib. This is the case of '.', which is introduced automatically into @INC until Perl 5.26 (which removes the 'feature'). The Mojolicious::Plugins lib prefixes the plugin names with 'Mojolicious::Plugin' so it first looks (for example) for Mojolicious::Plugin::Koha::REST::Plugin::Pagination (Pagination is just the first one on the list). When it looks for it at '.' it dies (because of Perl's behaviour) so it doesn't query for the right namespace (the following to try). I only reproduced it in koha-testing-docker. To test, you just need to try this patched koha-plack and make sure it doesn't break due to this permissions issue. To test: - In your koha-testing-docker clone, run: $ docker-compose up -p test - Open a shell inside the container (on a separate terminal): $ docker exec -it test_koha_1 bash - From within the /root directory, restart plack: $ cd /root $ koha-plack --restart kohadev => FAIL: Logs show plack is broken due to permissions problems trying to find Mojolicious::Plugin::Koha::REST::Plugin::Pagination - Use the patched script from this patch: $ /kohadevbox/koha/debian/scripts/koha-plack --restart kohadev => SUCCESS: Plack runs fine, no error in the logs - Sign off :-D Note: people who has environments in which the problems is reproducible, please test this version of koha-plack and stamp your sign-off, PLEASE. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 72408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72408&action=edit Bug 19546: (QA follow-up) Make the returning cd more fool proof Trivial and hypothetical fix. If you create /root/AA B (space in dirname), the quotes added here will help you to get back where you came from. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17717 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Pushed to master for 18.05, thanks to all for your hard work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Does not apply cleanly to 17.11 - let me know and provide a rebase or I can try -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72407|0 |1 is obsolete| | --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 73794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73794&action=edit [17.11.x] Bug 19546: Run starman from the instance's home dir This patch makes koha-plack jump into the instance's home directory to run. It is required because Perl 5.18 introduced a breaking change that makes perl die if @INC includes directories for which the user doesn't have read permission, and need to be traversed when querying for a lib. This is the case of '.', which is introduced automatically into @INC until Perl 5.26 (which removes the 'feature'). The Mojolicious::Plugins lib prefixes the plugin names with 'Mojolicious::Plugin' so it first looks (for example) for Mojolicious::Plugin::Koha::REST::Plugin::Pagination (Pagination is just the first one on the list). When it looks for it at '.' it dies (because of Perl's behaviour) so it doesn't query for the right namespace (the following to try). I only reproduced it in koha-testing-docker. To test, you just need to try this patched koha-plack and make sure it doesn't break due to this permissions issue. To test: - In your koha-testing-docker clone, run: $ docker-compose up -p test - Open a shell inside the container (on a separate terminal): $ docker exec -it test_koha_1 bash - From within the /root directory, restart plack: $ cd /root $ koha-plack --restart kohadev => FAIL: Logs show plack is broken due to permissions problems trying to find Mojolicious::Plugin::Koha::REST::Plugin::Pagination - Use the patched script from this patch: $ /kohadevbox/koha/debian/scripts/koha-plack --restart kohadev => SUCCESS: Plack runs fine, no error in the logs - Sign off :-D Note: people who has environments in which the problems is reproducible, please test this version of koha-plack and stamp your sign-off, PLEASE. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72408|0 |1 is obsolete| | --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 73795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73795&action=edit [17.11.x] Bug 19546: (QA follow-up) Make the returning cd more fool proof Trivial and hypothetical fix. If you create /root/AA B (space in dirname), the quotes added here will help you to get back where you came from. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |17.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|19196 | --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I removed the dependency on bu 19196 because it only highlighted the underlying problem. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196 [Bug 19196] Add pagination helpers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Pushed to stable for 17.11.X - had to change the variable from $instance-user to $instancename-koha http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=7963834a937909c5... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #26 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I this also for 17.05.x ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19546 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org