[Bug 20363] New: Privacy management shows misleading "No reading history to delete"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20363 Bug ID: 20363 Summary: Privacy management shows misleading "No reading history to delete" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: pasi.kallinen@joensuu.fi QA Contact: testopia@bugs.koha-community.org (OPACPrivacy is on) User views the "Your privacy" -page, it shows "No reading history to delete", even when the user has history. This is highly misleading. Error caused by commit 286be46e8a8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20363 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20363 paxed <pasi.kallinen@joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20429 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20363 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16966 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- (In reply to paxed from comment #0)
Error caused by commit 286be46e8a8
Bug 16966 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966 [Bug 16966] Koha::Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20363 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20363 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20363 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20429 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20429 [Bug 20429] Patron is told history is not deleted incorrectly on opac-privacy.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20363 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20363 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73208&action=edit Bug 20363: (bug 16966 follow-up) better messages handling User views the "Your privacy" -page, it shows "No reading history to delete", even when the user has history. Test plan: - Turn OPACPrivacy on - Go to opac-privacy.pl - Click the "Immediate deletion button" to delete the reading history => If the patron has reading history you must get "Your reading history has been deleted." Otherwise "No reading history to delete" Note that this patch reintroduce the "something went wrong" message if the deletion failed for whatever reason. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20363 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|20429 | CC| |lucas@bywatersolutions.com --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 20429 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20429 [Bug 20429] Patron is told history is not deleted incorrectly on opac-privacy.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20363 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 73208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73208 Bug 20363: (bug 16966 follow-up) better messages handling Review of attachment 73208: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20363&attachment=73208) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt @@ +27,4 @@
[% IF deleted %] <div class="alert alert-success">Your reading history has been deleted.</div> + [% ELSIF err_history_not_deleted %]
err_ does not match perl script's template_param. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20363 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73208|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73432&action=edit Bug 20363: (bug 16966 follow-up) better messages handling User views the "Your privacy" -page, it shows "No reading history to delete", even when the user has history. Test plan: - Turn OPACPrivacy on - Go to opac-privacy.pl - Click the "Immediate deletion button" to delete the reading history => If the patron has reading history you must get "Your reading history has been deleted." Otherwise "No reading history to delete" Note that this patch reintroduce the "something went wrong" message if the deletion failed for whatever reason. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20363 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20363 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73432|0 |1 is obsolete| | --- Comment #6 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 74663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74663&action=edit Bug 20363: (bug 16966 follow-up) better messages handling User views the "Your privacy" -page, it shows "No reading history to delete", even when the user has history. Test plan: - Turn OPACPrivacy on - Go to opac-privacy.pl - Click the "Immediate deletion button" to delete the reading history => If the patron has reading history you must get "Your reading history has been deleted." Otherwise "No reading history to delete" Note that this patch reintroduce the "something went wrong" message if the deletion failed for whatever reason. Signed-off-by: David Bourgault <david.bourgault@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20363 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |david.bourgault@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20363 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20363 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74663|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74670&action=edit Bug 20363: (bug 16966 follow-up) better messages handling User views the "Your privacy" -page, it shows "No reading history to delete", even when the user has history. Test plan: - Turn OPACPrivacy on - Go to opac-privacy.pl - Click the "Immediate deletion button" to delete the reading history => If the patron has reading history you must get "Your reading history has been deleted." Otherwise "No reading history to delete" Note that this patch reintroduce the "something went wrong" message if the deletion failed for whatever reason. Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20363 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20363 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20363 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org