[Bug 42757] New: Suggester is not passed by purchase-suggestions.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 Bug ID: 42757 Summary: Suggester is not passed by purchase-suggestions.pl Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Like Bug 41997 but for the purchase-suggestions.pl page. To recreate: 1. Find a patron 2. From the patron account click the "Purchase suggestions" button 3. Make a suggestion 4. That suggestion is not associated with the patron from step 1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- You must first apply Bug 42750 so the redirection correctly happens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42750, 39721 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 [Bug 39721] Remove GetSuggestion from C4/Suggestions.pm https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42750 [Bug 42750] Purchase suggestions made from members/purchase-suggestions.pl no longer redirect back -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Ah, suggestedby is getting set to the logged in librarian instead of the patron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199838&action=edit Bug 42757: Use default suggestor or fallback to librarian To test: 1. Find a patron 2. From the patron account click the "Purchase suggestions" button 3. Make a suggestion 4. That suggestion is not associated with the patron from step 1 5. APPLY PATCH and restart_all 6. Repeart steps 1 -3. The purchase suggestion suggesedby should be the patron from step 1 7. Go Acquisitions -> Suggestions -> Add suggestion 8. Make sure when you do it this way the suggestedby is set to the logged-in-user by default -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199838|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 199852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199852&action=edit Bug 42757: Use default suggestor or fallback to librarian To test: 1. Find a patron 2. From the patron account click the "Purchase suggestions" button 3. Make a suggestion 4. That suggestion is not associated with the patron from step 1 5. APPLY PATCH and restart_all 6. Repeart steps 1 -3. The purchase suggestion suggesedby should be the patron from step 1 7. Go Acquisitions -> Suggestions -> Add suggestion 8. Make sure when you do it this way the suggestedby is set to the logged-in-user by default Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes "Suggested by" release notes| |when making a suggestion | |for a patron from Patrons > | |[Selected patron] > | |Purchase suggestions. | | | |"Suggested by" was being | |recorded as the logged in | |librarian, instead of the | |patron that made the | |suggestion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 Myranda Fuentes <myranda.fuentes@groveforlibraries.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |myranda.fuentes@groveforlib | |raries.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|39721 | CC| |martin.renvoize@openfifth.c | |o.uk Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 [Bug 39721] Remove GetSuggestion from C4/Suggestions.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Unsponsored Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199852|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 199917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199917&action=edit Bug 42757: Use default suggestor or fallback to librarian To test: 1. Find a patron 2. From the patron account click the "Purchase suggestions" button 3. Make a suggestion 4. That suggestion is not associated with the patron from step 1 5. APPLY PATCH and restart_all 6. Repeart steps 1 -3. The purchase suggestion suggesedby should be the patron from step 1 7. Go Acquisitions -> Suggestions -> Add suggestion 8. Make sure when you do it this way the suggestedby is set to the logged-in-user by default Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 --- Comment #6 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.01 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #8 from Christopher Brannon <cbrannon@cdalibrary.org> --- Can this be back ported to 25.11? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 --- Comment #9 from Christopher Brannon <cbrannon@cdalibrary.org> --- Also, I am getting reports that when staff manually set the patron when making the request in the staff UI, it isn't consistently linking to the specific library. Have there been any reports of this, and will this patch address that issue as well? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 --- Comment #10 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Christopher Brannon from comment #9)
Also, I am getting reports that when staff manually set the patron when making the request in the staff UI, it isn't consistently linking to the specific library. Have there been any reports of this, and will this patch address that issue as well?
Ignore this comment. This had to do with submitting from the suggestions management page, not the patron page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 --- Comment #11 from David Nind <david@davidnind.com> --- (In reply to Christopher Brannon from comment #10)
(In reply to Christopher Brannon from comment #9)
Also, I am getting reports that when staff manually set the patron when making the request in the staff UI, it isn't consistently linking to the specific library. Have there been any reports of this, and will this patch address that issue as well?
Ignore this comment. This had to do with submitting from the suggestions management page, not the patron page.
I think that might be Bug 42710. When making a suggestion the default library selected was "Any". The default library is now the current library you are logged in as. (So far, pushed to 26.11.00 and 26.05.01.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42757 Bug 42757 depends on bug 42750, which changed state. Bug 42750 Summary: Purchase suggestions made from members/purchase-suggestions.pl no longer redirect back https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42750 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org