[Bug 42695] New: Minor language and markup corrections to reports error messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42695 Bug ID: 42695 Summary: Minor language and markup corrections to reports error messages Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org - Make error heading an actual <h1> - Restructure awkward sentence - Remove redundant language -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42695 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored Comma delimited| |Athens County Public list of Sponsors| |Libraries Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42695 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199577&action=edit Bug 42695: Minor language and markup corrections to reports error messages This patch makes a vew minor corrections to guided_reports_start.tt. To test apply the patch and go to Reports. - Try to create an SQL report which uses UPDATE, e.g. UPDATE items SET barcode = 1 WHERE itemnumber = 1 - Confirm that the text of the error message reads well and is formatted well. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42695 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from David Nind <david@davidnind.com> --- The patch no longer applies 8-(... git bz apply 42695 📋 Bug 42695 - Minor language and markup corrections to reports error messages • 199577 - Bug 42695: Minor language and markup corrections to reports error messages Apply? [(y)es, (n)o, (i)nteractive] y Preparing 1 patch(es): ✓ Prepared 1 patch(es) Applying 1 patch(es): Patch application failed for attachment 199577 - Bug 42695: Minor language and markup corrections to reports error messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42695 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42695 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199577|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42695 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199605&action=edit Bug 42695: Minor language and markup corrections to reports error messages This patch makes a vew minor corrections to guided_reports_start.tt. To test apply the patch and go to Reports. - Try to create an SQL report which uses UPDATE, e.g. UPDATE items SET barcode = 1 WHERE itemnumber = 1 - Confirm that the text of the error message reads well and is formatted well. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42695 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42695 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199605|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42695 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 199630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199630&action=edit Bug 42695: Minor language and markup corrections to reports error messages This patch makes a vew minor corrections to guided_reports_start.tt. To test apply the patch and go to Reports. - Try to create an SQL report which uses UPDATE, e.g. UPDATE items SET barcode = 1 WHERE itemnumber = 1 - Confirm that the text of the error message reads well and is formatted well. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42695 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 199631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199631&action=edit Bug 42695: (follow-up) Format paragraph Moves the explanation sentence into its own paragraph. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42695 --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 199632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199632&action=edit Screenshots - Before and after I moved the explanation of the error message into its own paragraph. Feel free to obsolete my follow-up patch if you disagree 8-). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42695 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the HTML markup release notes| |for some report error | |messages, along with some | |minor text changes: | |- Uses an H1 for the | |heading | |- Uses p for paragraphs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42695 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42695 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199630|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42695 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199631|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42695 --- Comment #7 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 199681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199681&action=edit Bug 42695: Minor language and markup corrections to reports error messages This patch makes a vew minor corrections to guided_reports_start.tt. To test apply the patch and go to Reports. - Try to create an SQL report which uses UPDATE, e.g. UPDATE items SET barcode = 1 WHERE itemnumber = 1 - Confirm that the text of the error message reads well and is formatted well. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42695 --- Comment #8 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 199682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199682&action=edit Bug 42695: (follow-up) Format paragraph Moves the explanation sentence into its own paragraph. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42695 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42695 --- Comment #9 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42695 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.01 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42695 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.01 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org