[Bug 16592] New: Use Bootstrap modal for MARC and Card preview on acquisitions receipt summary page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592 Bug ID: 16592 Summary: Use Bootstrap modal for MARC and Card preview on acquisitions receipt summary page Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/acqui/parcel.pl?invoiceid=x OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Blocks: 8290 On the acquisitions receipt summary page the "MARC" and "Card" links should trigger a preview in a Bootstrap modal instead of a Greybox modal. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 [Bug 8290] Replace usage of Greybox modals with Bootstrap modals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 51835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51835&action=edit Bug 16592 - Use Bootstrap modal for MARC and Card preview on acquisitions receipt summary page This patch replaces Greybox modals on the acquisitions receipt summary page with Bootstrap modals. To test, apply the patch and go to Acquisitions -> Invoices -> View an invoice -> Go to receipt page. - In the list of pending orders, test the "MARC" and "Card" links for various titles. Each should trigger a Bootstrap modal with the correct content. - Repeat the same tests in the list of already received orders. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51835|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 51930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51930&action=edit Bug 16592 - Use Bootstrap modal for MARC and Card preview on acquisitions receipt summary page This patch replaces Greybox modals on the acquisitions receipt summary page with Bootstrap modals. To test, apply the patch and go to Acquisitions -> Invoices -> View an invoice -> Go to receipt page. - In the list of pending orders, test the "MARC" and "Card" links for various titles. Each should trigger a Bootstrap modal with the correct content. - Repeat the same tests in the list of already received orders. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16640 [Bug 16640] Move actions on acquisitions receipt summary page into menu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Owen, The page is reloaded when I close the modal, is it expected? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #3)
Owen, The page is reloaded when I close the modal, is it expected?
Oops, forget that, it's the "close" link of the plack debug block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51930|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52165&action=edit Bug 16592 - Use Bootstrap modal for MARC and Card preview on acquisitions receipt summary page This patch replaces Greybox modals on the acquisitions receipt summary page with Bootstrap modals. To test, apply the patch and go to Acquisitions -> Invoices -> View an invoice -> Go to receipt page. - In the list of pending orders, test the "MARC" and "Card" links for various titles. Each should trigger a Bootstrap modal with the correct content. - Repeat the same tests in the list of already received orders. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for Koha 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16592 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #7 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.01. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org