https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15927 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48456&action=edit Bug 15927 - Remove use of <tr class="highlight"> for alternating row colors The "highlight" class on table rows is unnecessary since we have a CSS rule which defines colors for alternating row colors. This patch removes use of the "highlight" class from templates and removes the definition from staff-global.css To test, view the affected pages and confirm that the change has not broken anything. Acquisitions -> Vendor -> View basket Acquisitions -> Late orders Acquisitions -> Ordered Acquisitions -> Vendor -> Receive shipment Acquisitions -> Spent Acquisitions -> Vendor details -> Contracts table Administration -> MARC frameworks (comment removed only) Administration -> Class sources Authorities -> Authority search results Catalog -> Bibliographic detail page -> Items -> View item's checkout history Catalog -> subject.tt (is this template used?) Cataloging -> Cataloging search results Patrons -> Patron account Reports -> Patrons who haven't checked out Reports -> Statistics wizards -> Patrons Reports -> Top lists -> Most-circulated items Reports -> Inactive -> Items with no checkouts Reports -> Reports dictionary Reports -> Statistics wizards -> Circulation Reports -> Statistics wizards -> Holds Holds -> Place a hold -> Existing holds table Serials -> New subscription -> Search for a vendor -> Search results Serials -> Check expiration Serials -> Subscription -> Serial collection Serials -> Subscription -> Serial collection -> Edit serials Suggestions Tags -> View tags -> View titles with a tag Tools -> Manage staged MARC records -> Batch (I think the affected section of this template is obsolete) Tools -> Log viewer -> Log result Lists -> View lists (May be broken by Bug 15916) Note that if you search the templates for instances of a <tr> with a "highlight" class you'll find two instances in slip templates which refer to a class defined in printreceiptinvoice.css. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15927 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48456|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 48535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48535&action=edit Bug 15927 - Remove use of <tr class="highlight"> for alternating row colors The "highlight" class on table rows is unnecessary since we have a CSS rule which defines colors for alternating row colors. This patch removes use of the "highlight" class from templates and removes the definition from staff-global.css To test, view the affected pages and confirm that the change has not broken anything. Acquisitions -> Vendor -> View basket Acquisitions -> Late orders Acquisitions -> Ordered Acquisitions -> Vendor -> Receive shipment Acquisitions -> Spent Acquisitions -> Vendor details -> Contracts table Administration -> MARC frameworks (comment removed only) Administration -> Class sources Authorities -> Authority search results Catalog -> Bibliographic detail page -> Items -> View item's checkout history Catalog -> subject.tt (is this template used?) Cataloging -> Cataloging search results Patrons -> Patron account Reports -> Patrons who haven't checked out Reports -> Statistics wizards -> Patrons Reports -> Top lists -> Most-circulated items Reports -> Inactive -> Items with no checkouts Reports -> Reports dictionary Reports -> Statistics wizards -> Circulation Reports -> Statistics wizards -> Holds Holds -> Place a hold -> Existing holds table Serials -> New subscription -> Search for a vendor -> Search results Serials -> Check expiration Serials -> Subscription -> Serial collection Serials -> Subscription -> Serial collection -> Edit serials Suggestions Tags -> View tags -> View titles with a tag Tools -> Manage staged MARC records -> Batch (I think the affected section of this template is obsolete) Tools -> Log viewer -> Log result Lists -> View lists (May be broken by Bug 15916) Note that if you search the templates for instances of a <tr> with a "highlight" class you'll find two instances in slip templates which refer to a class defined in printreceiptinvoice.css. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Looks good. Haven't seen any regression. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15927 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48535|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 48536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48536&action=edit [PASSED QA] Bug 15927 - Remove use of <tr class="highlight"> for alternating row colors The "highlight" class on table rows is unnecessary since we have a CSS rule which defines colors for alternating row colors. This patch removes use of the "highlight" class from templates and removes the definition from staff-global.css To test, view the affected pages and confirm that the change has not broken anything. Acquisitions -> Vendor -> View basket Acquisitions -> Late orders Acquisitions -> Ordered Acquisitions -> Vendor -> Receive shipment Acquisitions -> Spent Acquisitions -> Vendor details -> Contracts table Administration -> MARC frameworks (comment removed only) Administration -> Class sources Authorities -> Authority search results Catalog -> Bibliographic detail page -> Items -> View item's checkout history Catalog -> subject.tt (is this template used?) Cataloging -> Cataloging search results Patrons -> Patron account Reports -> Patrons who haven't checked out Reports -> Statistics wizards -> Patrons Reports -> Top lists -> Most-circulated items Reports -> Inactive -> Items with no checkouts Reports -> Reports dictionary Reports -> Statistics wizards -> Circulation Reports -> Statistics wizards -> Holds Holds -> Place a hold -> Existing holds table Serials -> New subscription -> Search for a vendor -> Search results Serials -> Check expiration Serials -> Subscription -> Serial collection Serials -> Subscription -> Serial collection -> Edit serials Suggestions Tags -> View tags -> View titles with a tag Tools -> Manage staged MARC records -> Batch (I think the affected section of this template is obsolete) Tools -> Log viewer -> Log result Lists -> View lists (May be broken by Bug 15916) Note that if you search the templates for instances of a <tr> with a "highlight" class you'll find two instances in slip templates which refer to a class defined in printreceiptinvoice.css. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Looks good. Haven't seen any regression. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15927 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes.