[Bug 40027] New: Use GitHub workflow to automatically close PRs opened on the Koha repo there
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40027 Bug ID: 40027 Summary: Use GitHub workflow to automatically close PRs opened on the Koha repo there Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Developer documentation Assignee: schodkowy.omegi-0r@icloud.com Reporter: schodkowy.omegi-0r@icloud.com QA Contact: testopia@bugs.koha-community.org CC: koha-bugs@lists.koha-community.org This is simply based on: https://github.com/mozilla-firefox/firefox/blob/main/.github/workflows/close... Automatically redirect users who try to submit a PR at GitHub to instructions on how to submit patches and close the PR. Better experience for potential new developers (since they get immediate feedback, while still in the flow for submitting the patch). The sparse checkout of readme is probably required, so that the gh command knows on what repo to work with. The message text is a combination of the Firefox's text with what people used to write when closing Koha's PRs. I think it should be good enough but of course feel free to share any suggestions for change if you feel like it needs one. TEST PLAN: None honestly. This workflow is proven to work on Firefox's repo. The only change is adding \n newlines to the comment for readability, which I didn't test for whether it works... Otherwise it can only be tested after merging (either to Koha repo or to some dummy test repo if you really want to). -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40027 --- Comment #1 from Michał <schodkowy.omegi-0r@icloud.com> --- Created attachment 182839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182839&action=edit [PATCH] Bug 40027: Use GitHub workflow to automatically close PRs opened on the Koha repo there [PATCH] Bug 40027: Use GitHub workflow to automatically close PRs opened on the Koha repo there Automatically redirect users who try to submit a PR at GitHub to instructions on how to submit patches and close the PR. Better experience for potential new developers (since they get immediate feedback, while still in the flow for submitting the patch). The sparse checkout of readme is probably required, so that the gh command knows on what repo to work with. Based on: https://github.com/mozilla-firefox/firefox/blob/main/.github/workflows/close... -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40027 Michał <schodkowy.omegi-0r@icloud.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Michał <schodkowy.omegi-0r@icloud.com> --- Note 1: the presence of .github folder will not impact other git forges. Note 2: the GH_TOKEN: ${{ github.token }} value is populated automatically on workflow's runtime by a temporary token belonging to GitHub Actions user and with a scope permitting basic changes to the repo, so there's no need to manually generate anything. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40027 Imani <imani.thomas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40027 --- Comment #3 from Imani <imani.thomas@bywatersolutions.com> --- Created attachment 187386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187386&action=edit Bug 40027: Use GitHub workflow to automatically close PRs opened on the Koha repo there Automatically redirect users who try to submit a PR at GitHub to instructions on how to submit patches and close the PR. Better experience for potential new developers (since they get immediate feedback, while still in the flow for submitting the patch). The sparse checkout of readme is probably required, so that the gh command knows on what repo to work with. Based on: https://github.com/mozilla-firefox/firefox/blob/main/.github/workflows/close... Signed-off-by: Imani Thomas <imani.thomas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40027 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40027 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182839|0 |1 is obsolete| | Attachment #187386|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187456&action=edit Bug 40027: Use GitHub workflow to automatically close PRs opened on the Koha repo there Automatically redirect users who try to submit a PR at GitHub to instructions on how to submit patches and close the PR. Better experience for potential new developers (since they get immediate feedback, while still in the flow for submitting the patch). The sparse checkout of readme is probably required, so that the gh command knows on what repo to work with. Based on: https://github.com/mozilla-firefox/firefox/blob/main/.github/workflows/close... Signed-off-by: Imani Thomas <imani.thomas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40027 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40027 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40027 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40027 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40027 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- kohadev-koha@kohadevbox:koha(main)$ prove -v /kohadevbox/koha/xt/check_makefile.t /kohadevbox/koha/xt/check_makefile.t .. 1..3 ok 1 - We should test something not ok 2 - All directories must be listed in Makefile.PL # Failed test 'All directories must be listed in Makefile.PL' # at /kohadevbox/koha/xt/check_makefile.t line 40. # got: '1' # expected: '0' # $VAR1 = [ # '.github' # ]; ok 3 - no warnings # Looks like you failed 1 test of 3. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Do we need to add the .github dir to Makefile.PL? -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40027 --- Comment #7 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 187493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187493&action=edit Bug 40027: (follow-up) Add .github/ to Makefile.PL Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40027 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-up pushed to main -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40027 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.05 released in| | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40027 --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40027 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00,25.05.05 |25.11.00,25.05.05,24.11.11 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.11 -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40027 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40027 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42421 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42421 [Bug 42421] Only run GitHub Actions for closing pull requests (close-pr.yml) on the community repo -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org