[Bug 40449] New: xt/author/valid-templates.t generates warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40449 Bug ID: 40449 Summary: xt/author/valid-templates.t generates warnings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 40444 those are diag xt/author/valid-templates.t .. 1/3 # excluding template /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc because it cannot stand on its own # excluding template /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc because it cannot stand on its own # excluding template /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms because it cannot stand on its own # excluding template /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/chapter.inc because it cannot stand on its own # excluding template /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/thesis.inc because it cannot stand on its own # excluding template /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/book.inc because it cannot stand on its own # excluding template /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/other.inc because it cannot stand on its own # excluding template /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/journal.inc because it cannot stand on its own # excluding template /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/article.inc because it cannot stand on its own # excluding template /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/resource.inc because it cannot stand on its own # excluding template /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/dvd.inc because it cannot stand on its own # excluding template /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/includes/ill/backends/Standard/shared/forms/conference.inc because it cannot stand on its own # excluding template /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms because it cannot stand on its own # excluding template /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/chapter.inc because it cannot stand on its own # excluding template /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/thesis.inc because it cannot stand on its own # excluding template /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/book.inc because it cannot stand on its own # excluding template /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/other.inc because it cannot stand on its own # excluding template /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/journal.inc because it cannot stand on its own # excluding template /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/article.inc because it cannot stand on its own # excluding template /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/resource.inc because it cannot stand on its own # excluding template /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/dvd.inc because it cannot stand on its own # excluding template /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/ill/backends/Standard/shared/forms/conference.inc because it cannot stand on its own Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40444 [Bug 40444] Add a test to ensure all Perl test files use Test::NoWarnings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40449 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25515 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 [Bug 25515] [OMNIBUS] Remove warnings and errors from tests output -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40449 Bug 40449 depends on bug 40444, which changed state. Bug 40444 Summary: Add a test to ensure all Perl test files use Test::NoWarnings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40444 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40449 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40449 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197180&action=edit Bug 40449: Add NoWarnings to xt/author/valid-templates.t Several templates generates warnings: xt/author/valid-templates.t .. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron-article-requests.inc line 82. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc line 8. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc line 8. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 192. Argument "" isn't numeric in subtraction (-) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt line 461. Argument "" isn't numeric in subtraction (-) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt line 461. Argument "" isn't numeric in subtraction (-) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt line 1649. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt line 334. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt line 1154. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt line 1159. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt line 1162. Argument "" isn't numeric in numeric gt (>) at koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 192. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 283. Argument "" isn't numeric in numeric gt (>) at koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc line 8. Argument "" isn't numeric in numeric gt (>) at koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc line 8. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt line 75. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt line 97. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 85. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 85. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 86. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 86. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 87. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 214. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 385. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/includes/user-star-ratings.inc line 17. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt line 76. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt line 415. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt line 420. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt line 423. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt line 355. This happens because we do not sent the variables from the tests (what we don't want to do). This patch is suggesting to remove those warnings by adding a test on the variables than are compared with >, - or * It makes the code is little less readable but IMO it's worth it. Test plan: Code review the changes And confirm that `prove xt/author/valid-templates.t` is now green with Test::NoWarnings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40449 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |42152 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42152 [Bug 42152] xt/author/valid-templates.t should use Koha::Devel::Files to list the files to process -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40449 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197180|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40449 --- Comment #2 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 197254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197254&action=edit Bug 40449: Add NoWarnings to xt/author/valid-templates.t Several templates generates warnings: xt/author/valid-templates.t .. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron-article-requests.inc line 82. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc line 8. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc line 8. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 192. Argument "" isn't numeric in subtraction (-) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt line 461. Argument "" isn't numeric in subtraction (-) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt line 461. Argument "" isn't numeric in subtraction (-) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt line 1649. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt line 334. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt line 1154. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt line 1159. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt line 1162. Argument "" isn't numeric in numeric gt (>) at koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 192. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 283. Argument "" isn't numeric in numeric gt (>) at koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc line 8. Argument "" isn't numeric in numeric gt (>) at koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc line 8. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt line 75. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt line 97. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 85. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 85. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 86. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 86. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 87. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 214. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 385. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/includes/user-star-ratings.inc line 17. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt line 76. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt line 415. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt line 420. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt line 423. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt line 355. This happens because we do not sent the variables from the tests (what we don't want to do). This patch is suggesting to remove those warnings by adding a test on the variables than are compared with >, - or * It makes the code is little less readable but IMO it's worth it. Test plan: Code review the changes And confirm that `prove xt/author/valid-templates.t` is now green with Test::NoWarnings Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40449 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |victor@tuxayo.net --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
It makes the code is little less readable but IMO it's worth it.
+1 Works, makes sense, QA script happy, code looks good, count my QA stamp in :) The test plan doesn't have a real relevance for a separate SO. But it depends on another bug non passed QA so this it will stay SOed but it's really passed QA, it's just blocked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40449 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197254|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40449 --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 197372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197372&action=edit Bug 40449: Add NoWarnings to xt/author/valid-templates.t Several templates generates warnings: xt/author/valid-templates.t .. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron-article-requests.inc line 82. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc line 8. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc line 8. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 192. Argument "" isn't numeric in subtraction (-) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt line 461. Argument "" isn't numeric in subtraction (-) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt line 461. Argument "" isn't numeric in subtraction (-) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt line 1649. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt line 334. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt line 1154. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt line 1159. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt line 1162. Argument "" isn't numeric in numeric gt (>) at koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc line 192. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 283. Argument "" isn't numeric in numeric gt (>) at koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc line 8. Argument "" isn't numeric in numeric gt (>) at koha-tmpl/intranet-tmpl/prog/en/includes/patron-return-claims.inc line 8. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt line 75. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt line 97. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 85. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 85. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 86. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 86. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 87. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 214. Argument "" isn't numeric in multiplication (*) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 385. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/includes/user-star-ratings.inc line 17. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discharge.tt line 76. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt line 415. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt line 420. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt line 423. Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt line 355. This happens because we do not sent the variables from the tests (what we don't want to do). This patch is suggesting to remove those warnings by adding a test on the variables than are compared with >, - or * It makes the code is little less readable but IMO it's worth it. Test plan: Code review the changes And confirm that `prove xt/author/valid-templates.t` is now green with Test::NoWarnings Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40449 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #5 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- I'm also ok with the patch, from a QA PoV also, shouldn't we set this as blocked instead SO ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40449 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |jonathan.druart@gmail.com --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Baptiste Wojtkowski (bwoj) from comment #5)
I'm also ok with the patch, from a QA PoV also, shouldn't we set this as blocked instead SO ?
You can mark as PQA then mark it BLOCKED. So it's clear in the history that is can be set back top PQA once the dependent bug is PQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40449 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40449 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org