[Bug 12693] New: colspan calculation done by members/statistics.pl should be moved to template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12693 Bug ID: 12693 Summary: colspan calculation done by members/statistics.pl should be moved to template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Patrons Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com members/statistics.pl contains some code to calculate how many columns of the main table the footer's total column should span. As the colspan value is purely a display consideration, the logic should be moved to the template. members/statistics.pl: length_keys => scalar( @statistic_column_names), koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt: <td colspan="[% length_keys %]">TOTAL</td> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12693 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12693 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 30471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30471&action=edit Bug 12693 - colspan calculation done by members/statistics.pl should be moved to template It is not necessary for the patron statistics script to pass a colspan value to the template. The number can be output using Template::Toolkit syntax. To test, view the statistics page for a patron. Confirm that the "Total" cell in the footer spans the correct number of columns. Test with various numbers of fields in the StatisticsFields system preference. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12693 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 30544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30544&action=edit [Signed-off] Bug 12693 - colspan calculation done by members/statistics.pl should be moved to template It is not necessary for the patron statistics script to pass a colspan value to the template. The number can be output using Template::Toolkit syntax. To test, view the statistics page for a patron. Confirm that the "Total" cell in the footer spans the correct number of columns. Test with various numbers of fields in the StatisticsFields system preference. Followed test plan. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12693 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30471|0 |1 is obsolete| | CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12693 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12693 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12693 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30544|0 |1 is obsolete| | --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 30572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30572&action=edit Bug 12693 - colspan calculation done by members/statistics.pl should be moved to template It is not necessary for the patron statistics script to pass a colspan value to the template. The number can be output using Template::Toolkit syntax. To test, view the statistics page for a patron. Confirm that the "Total" cell in the footer spans the correct number of columns. Test with various numbers of fields in the StatisticsFields system preference. Followed test plan. Patch behaves as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12693 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12693 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org