[Bug 7944] New: attribute error could be clearer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7944 Priority: P5 - low Change sponsored?: --- Bug ID: 7944 CC: gmcharlt@gmail.com Assignee: kyle.m.hall@gmail.com Summary: attribute error could be clearer QA Contact: koha.sekjal@gmail.com Severity: normal Classification: Unclassified OS: All Reporter: nengard@gmail.com Hardware: All Status: NEW Version: master Component: Patrons Product: Koha Created attachment 9125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9125&action=edit attribute error When you have an attribute set to unique you get an error when trying to save the patron record, but it mentions an attribute number and that number is not visible anywhere in the staff client so it's confusing the librarian entering the data what field they entered the wrong info in to. See attached (ignore the circled fields - the Driver's License is the unique field here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7944 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|kyle.m.hall@gmail.com |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7944 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7944 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 29865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29865&action=edit Bug 7944 - attribute error could be clearer If you try to create a patron and enter an extended attribute value which is required to be unique but exists in another record the error you receive is not clear. It uses the attribute code instead of the description. This patch adds description to the output. To test you must have ExtendedPatronAttributes enabled. - Edit or create an extended patron attribute and designate it a unique identifier. - Edit a patron and add a value to that attribute. - Edit another patron and try to add the same value. You should get an error which includes both the description of the attribute you tried to modify and the value you submitted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7944 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7944 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29865|0 |1 is obsolete| | --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 30641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30641&action=edit [SIGNED OFF] Bug 7944 - attribute error could be clearer If you try to create a patron and enter an extended attribute value which is required to be unique but exists in another record the error you receive is not clear. It uses the attribute code instead of the description. This patch adds description to the output. To test you must have ExtendedPatronAttributes enabled. - Edit or create an extended patron attribute and designate it a unique identifier. - Edit a patron and add a value to that attribute. - Edit another patron and try to add the same value. You should get an error which includes both the description of the attribute you tried to modify and the value you submitted. Signed-off-by: Christopher Brannon <christopher@debian.brannon.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7944 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- Master shows differently than example, where the CODE of the attribute is given, but still it is unclear. Patch is a HUGE improvement. Thanks for the patch! Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7944 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7944 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30641|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30667&action=edit [PASSED QA] Bug 7944 - attribute error could be clearer If you try to create a patron and enter an extended attribute value which is required to be unique but exists in another record the error you receive is not clear. It uses the attribute code instead of the description. This patch adds description to the output. To test you must have ExtendedPatronAttributes enabled. - Edit or create an extended patron attribute and designate it a unique identifier. - Edit a patron and add a value to that attribute. - Edit another patron and try to add the same value. You should get an error which includes both the description of the attribute you tried to modify and the value you submitted. Signed-off-by: Christopher Brannon <christopher@debian.brannon.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, no problems found. Passes tests and Qa script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7944 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org