[Bug 18477] New: AR_PENDING notice does not populate values from article_requests table.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Bug ID: 18477 Summary: AR_PENDING notice does not populate values from article_requests table. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The default AR_PENDING letter does not print populate <<article_requests.*>> fields. To replicate: 1) Enable article requests ( syspref: ArticleRequests => Enable, Circ and fine rules ALL/ALL (or a given category/itemtype): Article requests => Yes ) 2) Search for a title, click in to catalog detail, click 'Request Article' button. 3) Select Patron 4) Fill out request information 5) Click 'Pplace request' 6) Go to notices in patron record, inspect 'Article Request Received' notice. You should see the request information from step 4, but it doesn't display. Examples below: AR_PENDING =================================== <<borrowers.firstname>> <<borrowers.surname>> (<<borrowers.cardnumber>>) We have received your request for an article from <<biblio.title>>. Article requested: Title: <<article_requests.title>> Author: <<article_requests.author>> Volume: <<article_requests.volume>> Issue: <<article_requests.issue>> Date: <<article_requests.date>> Pages: <<article_requests.pages>> Chapters: <<article_requests.chapters>> Notes: <<article_requests.patron_notes>> =================================== Displays as =================================== Barton Chittenden (barton) We have received your request for an article from Bws test record 2 (). Article requested: Title: Author: Volume: Issue: Date: Pages: Chapters: Notes: Thank you! =================================== The 'processing' and 'completed' notices work work, here's the output from 'Article Request Completed' =================================== Barton Chittenden (barton) We are have completed your request for an article from Bws test record 2 (). Article requested: Title: TEST TEST TEST Author: asdfsadf Volume: foo Issue: bar Date: baz Pages: 123234 Chapters: 9 Notes: Raaaaaagh! You may pick your article up at Midway. Thank you! =================================== -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace@cca.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 63251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63251&action=edit Bug 18477 - AR_PENDING notice does not populate values from article_requests table The default AR_PENDING letter does not print populate <<article_requests.*>> fields. Test Plan: 1) Enable article requests ( syspref: ArticleRequests => Enable, Circ and fine rules ALL/ALL (or a given category/itemtype): Article requests => Yes ) 2) Search for a title, click in to catalog detail, click 'Request Article' button. 3) Select Patron 4) Fill out request information 5) Click 'Place request' 6) Go to notices in patron record, inspect 'Article Request Received' notice. You should see the request information from step 4, but it doesn't display. 7) Apply this patch 8) Repeat steps 2-6, not the fields now display! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63251|0 |1 is obsolete| | --- Comment #2 from Eric Phetteplace <ephetteplace@cca.edu> --- Created attachment 63261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63261&action=edit Bug 18477 - AR_PENDING notice does not populate values from article_requests table The default AR_PENDING letter does not print populate <<article_requests.*>> fields. Test Plan: 1) Enable article requests ( syspref: ArticleRequests => Enable, Circ and fine rules ALL/ALL (or a given category/itemtype): Article requests => Yes ) 2) Search for a title, click in to catalog detail, click 'Request Article' button. 3) Select Patron 4) Fill out request information 5) Click 'Place request' 6) Go to notices in patron record, inspect 'Article Request Received' notice. You should see the request information from step 4, but it doesn't display. 7) Apply this patch 8) Repeat steps 2-6, not the fields now display! Signed-off-by: Eric Phetteplace <phette23@gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please provide tests! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Laurel Moran <lmoran@sdlawlibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lmoran@sdlawlibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is critical as without the patch you can't tell what has been ordered. Can we please get the tests requested? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Upping severity -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #3)
Please provide tests!
Reading the code the change is obvious (the same call exists for other methods), but why do we call $self->SUPER::store instead of $self->store? Back to NQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #6)
(In reply to Jonathan Druart from comment #3)
Please provide tests!
Reading the code the change is obvious (the same call exists for other methods), but why do we call $self->SUPER::store instead of $self->store?
Back to NQA
Same question for me. Inconsistent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|AR_PENDING notice does not |AR_PENDING notice does not |populate values from |populate values from |article_requests table. |article_requests table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is still quite a problem for users of article requests - can we agree on a fix? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70228&action=edit Bug 18477: Use ->store to update the timestamp -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There is a big lack of test and add a test here will take me too much time. The fix sounds trivial and the ->store method is obviously missing. I am willing to push these patches as it, if QA is ok with that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |J.P.Knight@lboro.ac.uk --- Comment #11 from Jon Knight <J.P.Knight@lboro.ac.uk> --- (In reply to Jonathan Druart from comment #6)
(In reply to Jonathan Druart from comment #3)
Please provide tests!
Reading the code the change is obvious (the same call exists for other methods), but why do we call $self->SUPER::store instead of $self->store?
Back to NQA
I just had a look at this and it would appear to call the parent's store method because if it calls its own there's a loop: the $self->store() method in Koha/ArticleRequest.pm can call its $self->open() method. I tested it by doing the obvious: replacing $self-SUPER::store with $self->store and sure enough its a memory hogging loop that crashed by dev VM's web server. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70231&action=edit Bug 18477: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Indeed Jon, so we need tests :) Thanks for the catch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70228|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70231|0 |1 is obsolete| | --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 70633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70633&action=edit Bug 18477: Add tests Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63261|0 |1 is obsolete| | --- Comment #15 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 70634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70634&action=edit Bug 18477 - AR_PENDING notice does not populate values from article_requests table The default AR_PENDING letter does not print populate <<article_requests.*>> fields. Test Plan: 1) Enable article requests ( syspref: ArticleRequests => Enable, Circ and fine rules ALL/ALL (or a given category/itemtype): Article requests => Yes ) 2) Search for a title, click in to catalog detail, click 'Request Article' button. 3) Select Patron 4) Fill out request information 5) Click 'Place request' 6) Go to notices in patron record, inspect 'Article Request Received' notice. You should see the request information from step 4, but it doesn't display. 7) Apply this patch 8) Repeat steps 2-6, not the fields now display! Signed-off-by: Eric Phetteplace <phette23@gmail.com> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mtompset@hotmail.com --- Comment #16 from M. Tompsett <mtompset@hotmail.com> --- Tests added trigger code change. Apply tests only. Test fail. Apply both patches. Test passes. This is expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Critical, in the queue for too long already. Skipping QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #18)
Pushed?
Indeed! Commit id 85b0424eb704d416950510c30b41a10ce56cbc3b in master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to stable for 17.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #21 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org