[Bug 19985] New: TestBuilder.t fails if default circ rule exists
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 Bug ID: 19985 Summary: TestBuilder.t fails if default circ rule exists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Set a default circ rule vagrant@kohadevbox:kohaclone(BUGFUN)$ prove t/db_dependent/TestBuilder.t t/db_dependent/TestBuilder.t .. 1/13 Violation of unique constraint in DefaultCircRule at /home/vagrant/kohaclone/t/lib/TestBuilder.pm line 241. # Failed test 'TestBuilder should be able to create an object for every source' # at t/db_dependent/TestBuilder.t line 78. # got: '1' # expected: '0' # The following sources have not been generated correctly: DefaultCircRule # Looks like you failed 1 test of 1. t/db_dependent/TestBuilder.t .. 3/13 # Failed test 'Build all sources' # at t/db_dependent/TestBuilder.t line 84. t/db_dependent/TestBuilder.t .. 12/13 # Looks like you failed 1 test of 13. t/db_dependent/TestBuilder.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/13 subtests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70812&action=edit Bug 19985: Make TestBuilder.t pass even if default_circ_rules is not empty This table cannot contain more than 1 row, so we need to remove its data before trying to generate a new entry. Test plan: Set a default circ rule prove t/db_dependent/TestBuilder.t should return green Without this patch you get: # Failed test 'TestBuilder should be able to create an object for every source' # at t/db_dependent/TestBuilder.t line 78. # got: '1' # expected: '0' # The following sources have not been generated correctly: DefaultCircRule # Looks like you failed 1 test of 1. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70812|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 70817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70817&action=edit Bug 19985: Make TestBuilder.t pass even if default_circ_rules is not empty This table cannot contain more than 1 row, so we need to remove its data before trying to generate a new entry. Test plan: Set a default circ rule prove t/db_dependent/TestBuilder.t should return green Without this patch you get: # Failed test 'TestBuilder should be able to create an object for every source' # at t/db_dependent/TestBuilder.t line 78. # got: '1' # expected: '0' # The following sources have not been generated correctly: DefaultCircRule # Looks like you failed 1 test of 1. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Trivial, skipping QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Passed QA --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #3)
Trivial, skipping QA.
Please adjust status if you do so. This has been pushed while still in the signoff queue. Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to stable for 17.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19985 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org