[Bug 29528] New: Breadcrumbs on HTML customizations take you to news
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 Bug ID: 29528 Summary: Breadcrumbs on HTML customizations take you to news Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Go to HTML customizations and click on it in the breadbrumbs and you'll end up on News. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127936&action=edit Bug 29528: Breadcrumbs on HTML customizations take you to news This patch removes the "Additional contents" breadcrumb when working with news items or HTML customizations. Since news and HTML customizations are separate links on the Tools home page there's no reason to have the breadcrumbs imply the two sections are connected in any way. We already have the "See News" link, for example, for switching quickly between the two areas. To test, apply the patch and go to Tools -> News. - The breadcrumbs should be: Home > Tools > News - Click "New entry." The breadcrumbs should be: Home > Tools > News > Add additional content (News). Clicking "News" should take you to the correct page. - Go to Tools -> HTML customizations. - The breadcrumbs should be Home > Tools > HTML customizations. - Click "New entry." The breadcrumbs should be: Home > Tools > HTML customizations > Add additional content (HTML customizations). Clicking "HTML customizations" should take you to the correct page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Owen Leonard from comment #1)
Since news and HTML customizations are separate links on the Tools home page there's no reason to have the breadcrumbs imply the two sections are connected in any way.
There are other changes I'd like to make to this template along these same lines, but I don't want to hold up this patch with string changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127936|0 |1 is obsolete| | --- Comment #3 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 127964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127964&action=edit Bug 29528: Breadcrumbs on HTML customizations take you to news This patch removes the "Additional contents" breadcrumb when working with news items or HTML customizations. Since news and HTML customizations are separate links on the Tools home page there's no reason to have the breadcrumbs imply the two sections are connected in any way. We already have the "See News" link, for example, for switching quickly between the two areas. To test, apply the patch and go to Tools -> News. - The breadcrumbs should be: Home > Tools > News - Click "New entry." The breadcrumbs should be: Home > Tools > News > Add additional content (News). Clicking "News" should take you to the correct page. - Go to Tools -> HTML customizations. - The breadcrumbs should be Home > Tools > HTML customizations. - Click "New entry." The breadcrumbs should be: Home > Tools > HTML customizations > Add additional content (HTML customizations). Clicking "HTML customizations" should take you to the correct page. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127964|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128167&action=edit Bug 29528: Breadcrumbs on HTML customizations take you to news This patch removes the "Additional contents" breadcrumb when working with news items or HTML customizations. Since news and HTML customizations are separate links on the Tools home page there's no reason to have the breadcrumbs imply the two sections are connected in any way. We already have the "See News" link, for example, for switching quickly between the two areas. To test, apply the patch and go to Tools -> News. - The breadcrumbs should be: Home > Tools > News - Click "New entry." The breadcrumbs should be: Home > Tools > News > Add additional content (News). Clicking "News" should take you to the correct page. - Go to Tools -> HTML customizations. - The breadcrumbs should be Home > Tools > HTML customizations. - Click "New entry." The breadcrumbs should be: Home > Tools > HTML customizations > Add additional content (HTML customizations). Clicking "HTML customizations" should take you to the correct page. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128168&action=edit Bug 29528: Surround strings with span Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Depends on| |24387 Keywords| |rel_21_11_candidate Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 [Bug 24387] Rename News tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.01 released in| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This change removes the release notes| |"Additional contents" | |breadcrumb when working | |with news items or HTML | |customizations. Since news | |and HTML customizations are | |separate links on the tools | |home page there's no reason | |to have the breadcrumbs | |imply the two sections are | |connected in any way. We | |already have the "See News" | |link, for example, for | |switching quickly between | |the two areas. Keywords| |Manual CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29528 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |andrew@bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org