[Bug 29637] New: AutoSwitchPatron is broken since Bug 26352
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 Bug ID: 29637 Summary: AutoSwitchPatron is broken since Bug 26352 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: michael.hafen@washk12.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Bug 26352 changed the line in circ/circulation.pl that searches for a patron card number in the barcode field from using the $barcode variable to the $findborrower variable. This breaks AutoSwitchPatron. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 --- Comment #1 from Michael Hafen <michael.hafen@washk12.org> --- Created attachment 128232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128232&action=edit Proposed fix Test plan: 1. make sure AutoSwitchPatron system preference is on. 2. get two patron card numbers. 3. enter the first card number to check out to the patron. 4. enter the second card number in the item barcode field. 5. observe that the barcode is not found. 6. apply patch 7. enter the second card number in the item barcode field again. 8. observe that the second patron is loaded to check out to. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 Michael Hafen <michael.hafen@washk12.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26352 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 128240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128240&action=edit Bug 29637: AutoSwitchPatron should look for card number in the barcode Bug 26352 changed the line in circ/circulation.pl that searches for a patron card number in the barcode field from using the $barcode variable to the $findborrower variable. This breaks AutoSwitchPatron. Test plan: 1. make sure AutoSwitchPatron system preference is on. 2. get two patron card numbers. 3. enter the first card number to check out to the patron. 4. enter the second card number in the item barcode field. 5. observe that the barcode is not found. 6. apply patch 7. enter the second card number in the item barcode field again. 8. observe that the second patron is loaded to check out to. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an issue release notes| |introduced by bug 26352 in | |21.11 that caused the | |AutoSwitchPatron system | |preference to no longer | |work. (When | |AutoSwitchPatron is enabled | |and a patron barcode is | |scanned instead of a book, | |it automatically redirects | |to the patron.) CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Keywords| |regression -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |michael.hafen@washk12.org |ity.org | Severity|normal |major CC| |jonathan.druart+koha@gmail. | |com Keywords| |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128232|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128240|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128275&action=edit Bug 29637: AutoSwitchPatron should look for card number in the barcode Bug 26352 changed the line in circ/circulation.pl that searches for a patron card number in the barcode field from using the $barcode variable to the $findborrower variable. This breaks AutoSwitchPatron. Test plan: 1. make sure AutoSwitchPatron system preference is on. 2. get two patron card numbers. 3. enter the first card number to check out to the patron. 4. enter the second card number in the item barcode field. 5. observe that the barcode is not found. 6. apply patch 7. enter the second card number in the item barcode field again. 8. observe that the second patron is loaded to check out to. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 --- Comment #4 from David Nind <david@davidnind.com> --- Note that bug 26352 no longer seems to work (unless I set things up wrong) - see my note on the bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to David Nind from comment #4)
Note that bug 26352 no longer seems to work (unless I set things up wrong) - see my note on the bug.
I've tested with KitchenSink and pull-request : https://github.com/bywatersolutions/dev-koha-plugin-kitchen-sink/pull/17 All good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 --- Comment #6 from David Nind <david@davidnind.com> --- (In reply to Fridolin Somers from comment #5)
All good.
Excellent! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.01 released in| | CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29637 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |andrew@bywatersolutions.com --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org