[Bug 9093] New: 008 forgetting what material type was chosen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 Bug ID: 9093 Summary: 008 forgetting what material type was chosen Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: nengard@gmail.com CC: m.de.rooy@rijksmuseum.nl See the video for clarification (http://screencast.com/t/Rtrx2QZk). When you use the 008 plugin you choose your material type - so if you choose VM for example you then have visual material fields. You then fill in your 008 and save. This all saves fine and shows right in NORMAL view. But if I click the 008 plugin again it says BK again .. even though it was VM that I made changes to. The plugin should remember the material type properly. This happens in master and 3.8.5 Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 bondiurbano <costalc@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc@gmail.com --- Comment #1 from bondiurbano <costalc@gmail.com> --- This happens in 3.12.3 too. Issue very claimed by staff users. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 Pablo López Liotti <paliotti@mdp.edu.ar> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paliotti@mdp.edu.ar --- Comment #2 from Pablo López Liotti <paliotti@mdp.edu.ar> --- This issue was reported today to me by my library staff. If the procedure of change field 008 values is repeated sometimes, finally it´s possible save the record with correct values. There is any patch o tip to prevent this? We are using 3.12.00 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 20789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20789&action=edit Material type as determined by Leader/06 and Leader/07 008 do not forgets, because it don't know. As stated in http://www.loc.gov/marc/formatintegration.html, "Field 008 does not carry any explicit flag identifying the definition of positions 18-34. Instead, the identification of the type of field 008 is dependent on the content of Leader/06 (Type of record) and,in the case of textual material (i.e., when Leader/06 contains value a), the content of Leader/07 (Bibliographic level)." So to fix this we need a way to pass Leader/06 and /07 to the plugin so it learns and shows proper material type, and that if the leader is correctly filled. Attached is a PDF with all possible combinations on leader/06 /07 and what kind of material type must be set. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 Stefano Bargioni <bargioni@pusc.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bargioni@pusc.it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #4 from David Cook <dcook@prosentient.com.au> --- *** Bug 11472 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au Assignee|gmcharlt@gmail.com |dcook@prosentient.com.au --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Bernardo Gonzalez Kriegel from comment #3)
Created attachment 20789 [details] Material type as determined by Leader/06 and Leader/07
008 do not forgets, because it don't know. As stated in http://www.loc.gov/marc/formatintegration.html, "Field 008 does not carry any explicit flag identifying the definition of positions 18-34. Instead, the identification of the type of field 008 is dependent on the content of Leader/06 (Type of record) and,in the case of textual material (i.e., when Leader/06 contains value a), the content of Leader/07 (Bibliographic level)."
So to fix this we need a way to pass Leader/06 and /07 to the plugin so it learns and shows proper material type, and that if the leader is correctly filled.
Attached is a PDF with all possible combinations on leader/06 /07 and what kind of material type must be set.
Good work on the PDF! It looks like it's incorrect for 06 "a" 07 "i", but otherwise perfect. Field 008/18-34 Configuration If Leader/06 = a and Leader/07 = a, c, d, or m: Books If Leader/06 = a and Leader/07 = b, i, or s: Continuing Resources If Leader/06 = t: Books If Leader/06 = c, d, i, or j: Music If Leader/06 = e, or f: Maps If Leader/06 = g, k, o, or r: Visual Materials If Leader/06 = m: Computer Files If Leader/06 = p: Mixed Materials http://www.loc.gov/marc/bibliographic/bdleader.html I'm going to look at this one today. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Created attachment 28690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28690&action=edit Bug 9093 - 008 forgetting what material type was chosen This patch adds material type checking to the MARC21 008 tag editor, based on value from the leader. That is, the 008 tag editor will choose an initial material type based on the leader 06 (and if necessary the leader 07 position) _TEST PLAN_ 1) Create a new record or open an existing bib record 2) Change position 6 from its current value (probably "a") to "c" or "e" or "g" or "m" or "p". (See the end of this message for a comprehensive list of 06 values to try.) 3) Open the 008 tag editor 4) Note that it still says BKS even though it should say "MU" or "MP" or "VM" or "CF" or "MX". 5) Apply the patch 6) Repeat steps 2 and 3. 7) Note that the 008 tag editor now shows the correct material type based on the leader. 8) For more comprehensive checking, try switching position 6 back to "a" and changing position 7 to "b" instead of "m". 9) Note that it will switch from "BKS" to "CR". 10) Fin Comprehensive mapping: Field 008/18-34 Configuration If Leader/06 = a and Leader/07 = a, c, d, or m: Books If Leader/06 = a and Leader/07 = b, i, or s: Continuing Resources If Leader/06 = t: Books If Leader/06 = c, d, i, or j: Music If Leader/06 = e, or f: Maps If Leader/06 = g, k, o, or r: Visual Materials If Leader/06 = m: Computer Files If Leader/06 = p: Mixed Materials http://www.loc.gov/marc/bibliographic/bdleader.html -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28690|0 |1 is obsolete| | --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Created attachment 28691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28691&action=edit Bug 9093 - 008 forgetting what material type was chosen This patch adds material type checking to the MARC21 008 tag editor, based on value from the leader. That is, the 008 tag editor will choose an initial material type based on the leader 06 (and if necessary the leader 07 position) _TEST PLAN_ 1) Create a new record or open an existing bib record 2) Change position 6 from its current value (probably "a") to "c" or "e" or "g" or "m" or "p". (See the end of this message for a comprehensive list of 06 values to try.) 3) Open the 008 tag editor 4) Note that it still says BKS even though it should say "MU" or "MP" or "VM" or "CF" or "MX". 5) Apply the patch 6) Repeat steps 2 and 3. 7) Note that the 008 tag editor now shows the correct material type based on the leader. 8) For more comprehensive checking, try switching position 6 back to "a" and changing position 7 to "b" instead of "m". 9) Note that it will switch from "BKS" to "CR". 10) Fin Comprehensive mapping: Field 008/18-34 Configuration If Leader/06 = a and Leader/07 = a, c, d, or m: Books If Leader/06 = a and Leader/07 = b, i, or s: Continuing Resources If Leader/06 = t: Books If Leader/06 = c, d, i, or j: Music If Leader/06 = e, or f: Maps If Leader/06 = g, k, o, or r: Visual Materials If Leader/06 = m: Computer Files If Leader/06 = p: Mixed Materials http://www.loc.gov/marc/bibliographic/bdleader.html -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28691|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 28696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28696&action=edit [SIGNED-OFF] Bug 9093 - 008 forgetting what material type was chosen This patch adds material type checking to the MARC21 008 tag editor, based on value from the leader. That is, the 008 tag editor will choose an initial material type based on the leader 06 (and if necessary the leader 07 position) _TEST PLAN_ 1) Create a new record or open an existing bib record 2) Change position 6 from its current value (probably "a") to "c" or "e" or "g" or "m" or "p". (See the end of this message for a comprehensive list of 06 values to try.) 3) Open the 008 tag editor 4) Note that it still says BKS even though it should say "MU" or "MP" or "VM" or "CF" or "MX". 5) Apply the patch 6) Repeat steps 2 and 3. 7) Note that the 008 tag editor now shows the correct material type based on the leader. 8) For more comprehensive checking, try switching position 6 back to "a" and changing position 7 to "b" instead of "m". 9) Note that it will switch from "BKS" to "CR". 10) Fin Comprehensive mapping: Field 008/18-34 Configuration If Leader/06 = a and Leader/07 = a, c, d, or m: Books If Leader/06 = a and Leader/07 = b, i, or s: Continuing Resources If Leader/06 = t: Books If Leader/06 = c, d, i, or j: Music If Leader/06 = e, or f: Maps If Leader/06 = g, k, o, or r: Visual Materials If Leader/06 = m: Computer Files If Leader/06 = p: Mixed Materials http://www.loc.gov/marc/bibliographic/bdleader.html Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, nice job. koha-qa complains for a tab char, removed on followup. Mode change on TT file (+x), removed. No other errors NOTE: It would be desirable to update LEADER values to reflect changes on 008. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 28697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28697&action=edit Bug 9093 - followup to fix tab Removing tab on line 82 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28696|0 |1 is obsolete| | Attachment #28697|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28714&action=edit [PASSED QA] Bug 9093 - 008 forgetting what material type was chosen This patch adds material type checking to the MARC21 008 tag editor, based on value from the leader. That is, the 008 tag editor will choose an initial material type based on the leader 06 (and if necessary the leader 07 position) _TEST PLAN_ 1) Create a new record or open an existing bib record 2) Change position 6 from its current value (probably "a") to "c" or "e" or "g" or "m" or "p". (See the end of this message for a comprehensive list of 06 values to try.) 3) Open the 008 tag editor 4) Note that it still says BKS even though it should say "MU" or "MP" or "VM" or "CF" or "MX". 5) Apply the patch 6) Repeat steps 2 and 3. 7) Note that the 008 tag editor now shows the correct material type based on the leader. 8) For more comprehensive checking, try switching position 6 back to "a" and changing position 7 to "b" instead of "m". 9) Note that it will switch from "BKS" to "CR". 10) Fin Comprehensive mapping: Field 008/18-34 Configuration If Leader/06 = a and Leader/07 = a, c, d, or m: Books If Leader/06 = a and Leader/07 = b, i, or s: Continuing Resources If Leader/06 = t: Books If Leader/06 = c, d, i, or j: Music If Leader/06 = e, or f: Maps If Leader/06 = g, k, o, or r: Visual Materials If Leader/06 = m: Computer Files If Leader/06 = p: Mixed Materials http://www.loc.gov/marc/bibliographic/bdleader.html Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, nice job. koha-qa complains for a tab char, removed on followup. Mode change on TT file (+x), removed. No other errors NOTE: It would be desirable to update LEADER values to reflect changes on 008. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks David! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.1. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 --- Comment #13 from David Cook <dcook@prosentient.com.au> --- (In reply to Kyle M Hall from comment #10)
NOTE: It would be desirable to update LEADER values to reflect changes on 008.
Unfortunately, I don't think that's possible, since it's a one way mapping. You can arrive at the same material type via multiple different Leader value combinations, so you can't reverse engineer a material type to get the Leader values. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org