[Bug 11961] New: Add a "Z39.50 search" button to the authority creation and modfication forms.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Bug ID: 11961 Summary: Add a "Z39.50 search" button to the authority creation and modfication forms. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt@gmail.com Reporter: fcapovilla@live.ca QA Contact: testopia@bugs.koha-community.org Created attachment 26461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26461&action=edit Add a "Z39.50 search" button to the authority creation and modification pages. This patch adds the "Z39.50 search" button to the authority creation and modification forms. Test case : * Go to the authority creation page. A "Z39.50 search" should be in the toolbar. * Click on the button, a warning dialog should appear, telling you this action could overwrite the current authority record. Click Ok. * The Z39.50 authority search dialog should appear. Search for an authority and import it. * The authority creation form should be updated with the informations from the imported authority. Test case 2 : * Search for an existing authority and modify it. You should preferably test this feature with an "Author" or "Uniform Title" authority since they have search fields in the Z39.50 search dialog. * In the modification form, click on the "Z39.50 search" button. * The warning dialog should appear. Click Ok. * The Z39.50 search dialog should appear. If the authority was of a supported type, some search fields should be auto-filled with the informations of the current authority record. * Search for a replacement authority and import it. * The current authority record should have been updated. Save it. * The existing authority should be updated, and no new authority record should have been created. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|Medium patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26461|0 |1 is obsolete| | --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 26516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26516&action=edit [SIGNED-OFF] Add a "Z39.50 search" button to the authority creation and modification pages. This button lets you replace existing authorities using a Z39.50 search. http://bugs.koha-community.org/show_bug.cgi?id=11961 Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests pass -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|gmcharlt@gmail.com |fcapovilla@live.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle@bywatersolutions.com --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- FAIL authorities/authorities.pl FAIL critic # Subroutines::ProhibitSubroutinePrototypes: Got 1 violation(s). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com Assignee|fcapovilla@live.ca |eric.begin@inLibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 --- Comment #3 from Eric Bégin <eric.begin@inLibro.com> --- Created attachment 29867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29867&action=edit Fix the ProhibitedSubroutinePrototypes QA critical error by removing the ($) from the GetMandatoryFieldZ3950 function http://bugs.koha-community.org/show_bug.cgi?id=9961 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #4 from Eric Bégin <eric.begin@inLibro.com> --- Critical problem fixed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 26516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26516 [SIGNED-OFF] Add a "Z39.50 search" button to the authority creation and modification pages. Review of attachment 26516: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11961&attachment=26516) ----------------------------------------------------------------- Hi Eric, I have used the splinter review to add my comments. I like this addition, please provide a follow-up. ::: authorities/authorities.pl @@ +344,4 @@
return int(rand(1000000)); }
+=item GetMandatoryFieldZ3950
Hard coding the fields in many places is a problem - please refactor so that it is using the same method as GuessAuthTypeCode. It also needs to be MARC agnostic (support UNIMARC) and have unit tests. ::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt @@ +201,4 @@
<br />Go to page : <input id="goto_page" name="goto_page" value="[% current_page %]" size="4" /><input type="submit" name="changepage_goto" onclick="return validate_goto_page();" value="Go" /> </form>
+<p><form method="get" action="/cgi-bin/koha/cataloguing/z3950_auth_search.pl"><input type="hidden" name="authid" value="[% authid %]" /><input type="submit" value="Try Another Search"/></form></p>
Please fix the capitalization here (I know it was wrong before, but this is a good moment to do it). @@ +214,4 @@
</div> [% END %] <div class="dialog message">Nothing found.</div> + <p><form method="get" action="/cgi-bin/koha/cataloguing/z3950_auth_search.pl"><input type="hidden" name="authid" value="[% authid %]" /><input type="submit" value="Try Another Search"/></form></p>
Also here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Francois Charbonnier <francois.charbonnier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com | |, | |simith.doliveira@inlibro.co | |m Assignee|eric.begin@inLibro.com |simith.doliveira@inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 --- Comment #6 from simith.doliveira@inlibro.com --- Created attachment 30772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30772&action=edit This patch fix the QA critical error, fix the capitalization and the UNIMARC support. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29867|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30772|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 35418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35418&action=edit This patch fix the QA critical error, fix the capitalization and the UNIMARC support. http://bugs.koha-community.org/show_bug.cgi?id=11961 Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26516|0 |1 is obsolete| | Attachment #35418|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35490&action=edit [PASSED QA] Bug 11961 - Add a "Z39.50 search" button to the authority creation and modification pages. This button lets you replace existing authorities using a Z39.50 search. http://bugs.koha-community.org/show_bug.cgi?id=11961 Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests pass Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35491&action=edit [PASSED QA] Bug 11961 - This patch fix the QA critical error, fix the capitalization and the UNIMARC support. http://bugs.koha-community.org/show_bug.cgi?id=11961 Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Frederik! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org