[Bug 36608] New: Port default TO_PROCESS and AVAILABLE notices to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36608 Bug ID: 36608 Summary: Port default TO_PROCESS and AVAILABLE notices to Template Toolkit syntax Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: roadmap_24_05 Severity: enhancement Priority: P5 - low Component: Notices Assignee: emily.lamancusa@montgomerycountymd.gov Reporter: emily.lamancusa@montgomerycountymd.gov QA Contact: testopia@bugs.koha-community.org Blocks: 15278 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36608 --- Comment #1 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 165590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165590&action=edit Bug 36608: Adjust TO_PROCESS and AVAILABLE to use TT To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Go to "my account", and enter a Primary email 4. Under Administration > Libraries, enter an email address for at least one library 5. Add the demo user (koha) as the owner of the Main Fund a) Go to the Acquisitions module b) Click on Main Fund c) Click the Actions button at the end of Main Fund row > click Edit d) Click "Select owner" e) Search for "koha" f) Click the Select button g) Click Submit 6. Click "Suggestions" on the left side of the page, and click "New purchase suggestion" 7. Fill in values for, at minimum: Bibliographic information: Title Author Acquisition information: Library (set to the library you entered an email for in step 4) Fund (set to Main Fund) 9. Submit the suggestion 10. Run the cron job to generate TO_PROCESS notification email: misc/cronjobs/notice_unprocessed_suggestions.pl -v -c --days=0 11. Set the new suggestion to "Accepted" a) Check the checkbox next to the new suggestion b) Below the table, set "Mark selected as" drop-down to "Accepted" c) Click Submit 12. Create an order from the purchase suggestion a) Return to the Acquisitions homepage b) Leave the Vendor field blank and click Search c) Next to the sample basket (My Basket), click "Add to basket" d) Click "From a suggestion" e) Click "+ Order" next to the suggestion f) Make sure there are values for all required item fields g) Click "Add item" h) Click Save 13. Close the basket and receive the order a) Click "Close basket" and click "Yes, close" b) Click "Receive shipments" c) Enter a number in "Vendor invoice" and click Next d) Check the checkbox next to "My Basket" and click "Receive selected" button e) Check the checkbox under "Receive?" in the Items table f) Click Confirm 14. Return to "my account" and open the Notices tab --> There should be (among others) notices for "A suggestion is ready to be processed" and "Suggested purchase available" 15. Open each of the above two notices, and confirm all the information was filled in correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36608 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36608 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165590|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166408&action=edit Bug 36608: Adjust TO_PROCESS and AVAILABLE to use TT To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Go to "my account", and enter a Primary email 4. Under Administration > Libraries, enter an email address for at least one library 5. Add the demo user (koha) as the owner of the Main Fund a) Go to the Acquisitions module b) Click on Main Fund c) Click the Actions button at the end of Main Fund row > click Edit d) Click "Select owner" e) Search for "koha" f) Click the Select button g) Click Submit 6. Click "Suggestions" on the left side of the page, and click "New purchase suggestion" 7. Fill in values for, at minimum: Bibliographic information: Title Author Acquisition information: Library (set to the library you entered an email for in step 4) Fund (set to Main Fund) 9. Submit the suggestion 10. Run the cron job to generate TO_PROCESS notification email: misc/cronjobs/notice_unprocessed_suggestions.pl -v -c --days=0 11. Set the new suggestion to "Accepted" a) Check the checkbox next to the new suggestion b) Below the table, set "Mark selected as" drop-down to "Accepted" c) Click Submit 12. Create an order from the purchase suggestion a) Return to the Acquisitions homepage b) Leave the Vendor field blank and click Search c) Next to the sample basket (My Basket), click "Add to basket" d) Click "From a suggestion" e) Click "+ Order" next to the suggestion f) Make sure there are values for all required item fields g) Click "Add item" h) Click Save 13. Close the basket and receive the order a) Click "Close basket" and click "Yes, close" b) Click "Receive shipments" c) Enter a number in "Vendor invoice" and click Next d) Check the checkbox next to "My Basket" and click "Receive selected" button e) Check the checkbox under "Receive?" in the Items table f) Click Confirm 14. Return to "my account" and open the Notices tab --> There should be (among others) notices for "A suggestion is ready to be processed" and "Suggested purchase available" 15. Open each of the above two notices, and confirm all the information was filled in correctly Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36608 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36608 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Simple patch, Quick QA here. Passing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36608 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36608 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36608 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36608 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36608 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The default notice release notes| |templates for certain | |purchase suggestion | |notifications (TO_PROCESS | |and AVAILABLE) now use | |modern Template Toolkit | |rather than the old custom | |syntax. This will only | |affect new installations, | |unless the library chooses | |to reset their notices to | |the default. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org