[Bug 36126] New: Port default HOLD notice to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36126 Bug ID: 36126 Summary: Port default HOLD notice to Template Toolkit syntax Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: roadmap_24_05 Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: emily.lamancusa@montgomerycountymd.gov QA Contact: testopia@bugs.koha-community.org Blocks: 15278 We have default HOLD notices defined for email, sms, and print - all three need to be updated to Template Toolkit syntax Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36126 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36126 --- Comment #1 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 165808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165808&action=edit Bug 36126: Adjust default HOLD notices to use TT To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Enable SMS Notices a) Find the system preference SMSSendDriver b) Enter "Email" as the value for SMSSendDriver and save 4. Go to a patron account, and set the following messaging preferences: Hold filled: - Check SMS - Check Email - Leave Digests only unchecked 5. Leave SMS number and all email address fields blank for that patron 6. Place a hold for that patron 7. Check in an item to fill the hold 8. Open the Notices tab on that patron's account --> The patron should have a Print "hold filled" notice, since they don't have an email address or SMS number in the system 9. Add a Primary email and SMS number to the patron account 10. Place another hold for that patron 11. Check in an item to fill the hold 12. Go back to the Notices tab on that patron's account --> The patron should now have Email and SMS "hold filled" notices as well 13. Open each notice and confirm that all information is correct -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36126 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emily.lamancusa@montgomeryc |ity.org |ountymd.gov Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36126 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165808|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166412&action=edit Bug 36126: Adjust default HOLD notices to use TT To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Enable SMS Notices a) Find the system preference SMSSendDriver b) Enter "Email" as the value for SMSSendDriver and save 4. Go to a patron account, and set the following messaging preferences: Hold filled: - Check SMS - Check Email - Leave Digests only unchecked 5. Leave SMS number and all email address fields blank for that patron 6. Place a hold for that patron 7. Check in an item to fill the hold 8. Open the Notices tab on that patron's account --> The patron should have a Print "hold filled" notice, since they don't have an email address or SMS number in the system 9. Add a Primary email and SMS number to the patron account 10. Place another hold for that patron 11. Check in an item to fill the hold 12. Go back to the Notices tab on that patron's account --> The patron should now have Email and SMS "hold filled" notices as well 13. Open each notice and confirm that all information is correct Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36126 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36126 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Simple and clear patch, works in testing. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36126 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36126 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36126 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36126 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36126 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The default notice template release notes| |for hold pickup | |notifications now uses | |modern Template Toolkit | |rather than the old custom | |syntax. This will only | |affect new installations, | |unless the library chooses | |to reset their notices to | |the default. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org