[Bug 18559] New: Koha:: Clubs - methods should not get the return type in parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18559 Bug ID: 18559 Summary: Koha::Clubs - methods should not get the return type in parameter Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: kyle@bywatersolutions.com Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 12461, 18553 Koha::Clubs->get_club_enrollments and Koha::Clubs->get_enrollable_clubs take a $return_scalar parameter. The return value type should not be a parameter. We should return _new_from_dbic or Koha::Objects->search in any cases. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 [Bug 12461] Add patron clubs feature https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18553 [Bug 18553] Incorrect "Loading..." tag on moremember.tt when no clubs defined -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18559 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63256&action=edit Bug 18559: Koha::Clubs - Remove $return_scalar from parameters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18559 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Kyle, Here is my try. But tests fail now... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18559 Bug 18559 depends on bug 12461, which changed state. Bug 12461 Summary: Add patron clubs feature https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18559 Bug 18559 depends on bug 18553, which changed state. Bug 18553 Summary: Incorrect "Loading..." tag on moremember.tt when no clubs defined https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18553 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18559 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18559 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #2)
Kyle, Here is my try. But tests fail now...
Trying to raise attention - fqa. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18559 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18559 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18559 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18559 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WONTFIX |DUPLICATE --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Actually fixed on Bug 29844: Simplify Koha::Clubs->get_enrollable *** This bug has been marked as a duplicate of bug 29844 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org