https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18559 Bug ID: 18559 Summary: Koha::Clubs - methods should not get the return type in parameter Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: kyle@bywatersolutions.com Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 12461, 18553 Koha::Clubs->get_club_enrollments and Koha::Clubs->get_enrollable_clubs take a $return_scalar parameter. The return value type should not be a parameter. We should return _new_from_dbic or Koha::Objects->search in any cases. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 [Bug 12461] Add patron clubs feature https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18553 [Bug 18553] Incorrect "Loading..." tag on moremember.tt when no clubs defined -- You are receiving this mail because: You are watching all bug changes.