[Bug 40740] New: Validation for biblioitems in about/system information joins on biblionumber not biblioitemnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40740 Bug ID: 40740 Summary: Validation for biblioitems in about/system information joins on biblionumber not biblioitemnumber Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: lisette@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org select bi.biblioitemnumber, dbi.biblioitemnumber from biblioitems bi join deletedbiblioitems dbi on bi.biblionumber=dbi.biblionumber Warns if there's items from the same biblio, one not deleted, one is deleted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40740 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lisette@bywatersolutions.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40740 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35033 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35033 [Bug 35033] Add a validation for biblioitems in about/system information -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40740 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40740 --- Comment #1 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 186056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186056&action=edit Bug 40740: Validation for biblioitems in about/system information joins on biblionumber not biblioitemnumber This patche fixes the validation for biblioitems to only warn when the biblioitemnumber is in both tables instead of the biblionumber. To test: 1. Delete an item that has another item on the record. 2. Go to About and select the system configuration tab 3. Observe there is a warning. 4. Run a report select bi.biblioitemnumber, dbi.biblioitemnumber from biblioitems bi join deletedbiblioitems dbi on bi.biblionumber=dbi.biblionumber 5. You'll see the numbers don't match 6. Apply the patch 7. Repeat step 2 8. Observe no warning 9. Repeat step 4 10. Observe no results. 11. Sign off! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40740 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch fixes an issue release notes| |where the about page warns | |incorrectly when there are | |items in both the | |biblioitems and | |deletedbiblioitems tables | |on the same record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40740 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- I didn't get a warning on the system information tab. I deleted one of the items for Effective Perl programming (biblionumber = 139), in the default KTD it has two items. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40740 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |blawlor@clamsnet.org --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- I also didn't get a warning on the system information tab. On step 4 when I run the query before applying the patch I get no results too. Is there something missing from the test plan? I don't see any records in deletedbiblioitems after just deleting an item. I only get a deletedbiblioitems record after deleting a bib record. When I was testing I found when you delete a bib record only one record is added to deletedbiblioitems that has the same biblioitemnumber as its biblionumber. Is that correct or a different bug? I was able to reproduce the error after some sql statements to update biblioitems and deletedbiblioitems. I think we need some suggested steps to reproduce something like this: 1. Delete all items from a bib and delete the bib 2. Take note of biblio and biblioitemnumbers for making an update statement select biblionumber, biblioitemnumber from deletedbiblioitems 3. Update a biblioitem record to have a match for example update biblioitems set biblionumber=233 biblioitemnumber = 233 where biblionumber = 1; I applied the patch, but the error didn't go away, until I updated the data again to fix it. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org