[Bug 33095] New: Text is white on white when hovering over pay/writeoff buttons in paycollect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33095 Bug ID: 33095 Summary: Text is white on white when hovering over pay/writeoff buttons in paycollect Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org The members/paycollect page has buttons to switch between pay and writeoff when you are paying a charge. When you hover the mouse cursor over the inactive button, the text becomes white, on a white background. To get there: 1. Add a charge to a patron's account and go to pay 1.1. Go to Patrons 1.2. Click "Search" 1.3. Click on the name of any patron 1.4. Click on the "Accounting" tab (on the left) 1.5. Click on the "Create manual invoice" tab 1.6. Enter an amount 1.7. Click "Save and pay" 2. Hover on the "Writeoff" button at the top of the form --> Text "disappears" Also, I noticed the text for the active button becomes underlined and the button changes size... 3. Hover on the "Pay" button at the top of the form --> "Pay" becomes underlined --> Yellow button gets smaller -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33095 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33095 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33095 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 147577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147577&action=edit Bug 33095: Text is white on white when hovering over pay/writeoff buttons in paycollect The "Make a payment" page uses unusual navigation for the switch between the "Pay" and "Write off" views: Bootstrap nav pills. The style on these is a little muddled because a mix of Bootstrap and custom CSS is at work. This patch adds some CSS specific to nav pills and removes some ambiguous CSS. Two links in the template get a dummy "#" href attribute to make them work better with default styles. To test, apply the patch and rebuild the staff interface CSS. - Locate a patron who has outstanding charges (lost item charge, account renewal fee, overdue fine, etc.). - From the patron checkout or detail page, click the "Accounting" tab in the left hand sidebar. - Click the "Pay" button on one of the oustanding charges. - On the "Pay an individual fine" page, confirm that there is a button and a link at the top of tab panel: "Pay" and "Write off." The "Pay" button should green with white text, the "Write off" button should be white with green text. - Click the "Write off" button and the styles of the links should be reversed. - Confirm that the CSS changes do not affect the appearance of the main navigation bar at the top of the page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33095 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33095 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147577|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 147579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147579&action=edit Bug 33095: Text is white on white when hovering over pay/writeoff buttons in paycollect The "Make a payment" page uses unusual navigation for the switch between the "Pay" and "Write off" views: Bootstrap nav pills. The style on these is a little muddled because a mix of Bootstrap and custom CSS is at work. This patch adds some CSS specific to nav pills and removes some ambiguous CSS. Two links in the template get a dummy "#" href attribute to make them work better with default styles. To test, apply the patch and rebuild the staff interface CSS. - Locate a patron who has outstanding charges (lost item charge, account renewal fee, overdue fine, etc.). - From the patron checkout or detail page, click the "Accounting" tab in the left hand sidebar. - Click the "Pay" button on one of the oustanding charges. - On the "Pay an individual fine" page, confirm that there is a button and a link at the top of tab panel: "Pay" and "Write off." The "Pay" button should green with white text, the "Write off" button should be white with green text. - Click the "Write off" button and the styles of the links should be reversed. - Confirm that the CSS changes do not affect the appearance of the main navigation bar at the top of the page. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33095 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is much much better than before, but I notice that here and in some other places we have yellow buttons with white font. The normal "main" button is yellow with black font, which I think has the better contrast. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33095 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33095 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147579|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 147748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147748&action=edit Bug 33095: Text is white on white when hovering over pay/writeoff buttons in paycollect The "Make a payment" page uses unusual navigation for the switch between the "Pay" and "Write off" views: Bootstrap nav pills. The style on these is a little muddled because a mix of Bootstrap and custom CSS is at work. This patch adds some CSS specific to nav pills and removes some ambiguous CSS. Two links in the template get a dummy "#" href attribute to make them work better with default styles. To test, apply the patch and rebuild the staff interface CSS. - Locate a patron who has outstanding charges (lost item charge, account renewal fee, overdue fine, etc.). - From the patron checkout or detail page, click the "Accounting" tab in the left hand sidebar. - Click the "Pay" button on one of the oustanding charges. - On the "Pay an individual fine" page, confirm that there is a button and a link at the top of tab panel: "Pay" and "Write off." The "Pay" button should green with white text, the "Write off" button should be white with green text. - Click the "Write off" button and the styles of the links should be reversed. - Confirm that the CSS changes do not affect the appearance of the main navigation bar at the top of the page. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33095 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33095 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33095 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |jacob.omara@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33095 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.04 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33095 --- Comment #6 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33095 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Can't recreate in 22.05, won't backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org