[Bug 31665] New: 952$d ( Date acquired ) no longer prefills with todays date when focused
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 Bug ID: 31665 Summary: 952$d ( Date acquired ) no longer prefills with todays date when focused Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Before the introduction of Flatpickr, when adding a new item if you clicked on the date acquired field, and it was empty, it would be prefilled with today's date. It would be useful if we could get that functionality back. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I am seeing this in 21.11 too. Note that it is about focus of the text box. Clicking on the plugin control next to the text box does still update the field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- When you focus the field, the date popup comes up. If that would respond to Enter, it would already be helpful? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- How to categorize this bug might be hard too: If lots of items would not get a date anymore, a library might not consider this Minor anymore -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #3)
How to categorize this bug might be hard too: If lots of items would not get a date anymore, a library might not consider this Minor anymore
Today's date is used autommagically when you leave the input empty. So that won't be the case, but I also liked the old behaviour as it allowed easy manipulation of the date. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #4)
(In reply to Marcel de Rooy from comment #3)
How to categorize this bug might be hard too: If lots of items would not get a date anymore, a library might not consider this Minor anymore
Today's date is used autommagically when you leave the input empty. So that won't be the case, but I also liked the old behaviour as it allowed easy manipulation of the date.
That is depending on the context. You are right for new items. Which will be the scope mainly here. For existing items, see bug 29958: Do not set dateaccessioned on updates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 Michael Adamyk <madamyk@ckls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk@ckls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30797 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Could this be related to Bug 30797 ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Looking back at 21.05.x I see that this works with via the dateaccessioned.pl plugin. In the dateaccessioned.pl code there is this event handler: function Focus$function_name(event) { set_to_today(event.data.id); } Looking at master now I see that the event handler is still there on the 'tag_952_subfield_d_' element but has an input type of 'type="hidden"'. That is being hidden by flatpickr, so the event needs to be attached to the Flatpickr wrapper. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 145923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145923&action=edit Bug 31665: Set today date for date cataloguing plugin dateaccessioned.pl must pick today's date when the input gets the focus on. Test plan: Edit an item, or create a new one. Confirm that today's date is prefilled into the date's input when it's empty and that it gets the focus on -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29963 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I am really hesitant here, didn't we decide to not prefill it? See bug 29963. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #9)
I am really hesitant here, didn't we decide to not prefill it?
See bug 29963.
Ok, got it. This is about the focus. Then I think the patch is correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145923|0 |1 is obsolete| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 145979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145979&action=edit Bug 31665: Set today date for date cataloguing plugin dateaccessioned.pl must pick today's date when the input gets the focus on. Test plan: Edit an item, or create a new one. Confirm that today's date is prefilled into the date's input when it's empty and that it gets the focus on Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145979|0 |1 is obsolete| | --- Comment #12 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 145981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145981&action=edit Bug 31665: Set today date for date cataloguing plugin dateaccessioned.pl must pick today's date when the input gets the focus on. Test plan: Edit an item, or create a new one. Confirm that today's date is prefilled into the date's input when it's empty and that it gets the focus on Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Michael Adamyk <madamyk@ckls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145981|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 147721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147721&action=edit Bug 31665: Set today date for date cataloguing plugin dateaccessioned.pl must pick today's date when the input gets the focus on. Test plan: Edit an item, or create a new one. Confirm that today's date is prefilled into the date's input when it's empty and that it gets the focus on Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Michael Adamyk <madamyk@ckls.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 --- Comment #15 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31665 --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- Won't apply cleanly to 22.05, no backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org