[Bug 36083] New: Not able to create customizable areas to intranet home pages that are library specific
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36083 Bug ID: 36083 Summary: Not able to create customizable areas to intranet home pages that are library specific Change sponsored?: --- Product: Koha Version: 23.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When testing the enhancement coming in 23.11, bug 6419, it appears that library-specific text does not display as it should with the HTML Customization tool. Process to test: 1. Tools> HTML Customizations 2. Choose to create an entry in StaffAcquisitionsHome 3. Assign it to a specific library 4. Add text and publication date. 5. Save 6. Go to the Acquisitions Home page - logged into that library, no text displays. This enhancement does work if creating an entry for 'all libraries'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36083 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36083 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36083 --- Comment #1 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 170612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170612&action=edit Bug 36083: Fix HTML additional contents for the logged in branchcode This patch updates the calls to AdditionalContents.get() to use Branches.GetLoggedInBranchcode instead of the logged in users homebranch for the library parameter. To test: 1. In Tools > HTML Customizations 2. Choose to create an entry in StaffAcquisitionsHome 3. Assign it to a specific library It's helpful to test with libraries other than Centerville 4. Add text and publication date (important or it will never display) 5. Save 6. Go to the Acquisitions Home page - logged into that library, no text displays. 7. Apply patch and refresh browser 8. Notice the library specifc content displays 9. Notice content created for all libraries still displays too 10. Test HTML content for specific libraries works on all 8 pages IntranetmainUserBlock Staff AcquisitionsHome StaffAuthoritiesHome StaffCataloguing Home StaffListsHome StaffPatronsHome StaffPOSHome StaffSerialsHome -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36083 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |blawlor@clamsnet.org |ity.org | CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36083 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|23.11 |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36083 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |samalau@gmail.com --- Comment #2 from Sam Lau <samalau@gmail.com> --- Everything works except for StaffAuthoritiesHome -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36083 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36083 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170612|0 |1 is obsolete| | --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 170615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170615&action=edit Bug 36083: Fix HTML additional contents for the logged in branchcode This patch updates the calls to AdditionalContents.get() to use Branches.GetLoggedInBranchcode instead of the logged in users homebranch for the library parameter. To test: 1. In Tools > HTML Customizations 2. Choose to create an entry in StaffAcquisitionsHome 3. Assign it to a specific library It's helpful to test with libraries other than Centerville 4. Add text and publication date (important or it will never display) 5. Save 6. Go to the Acquisitions Home page - logged into that library, no text displays. 7. Apply patch and refresh browser 8. Notice the library specifc content displays 9. Notice content created for all libraries still displays too 10. Test HTML content for specific libraries works on all 8 pages IntranetmainUserBlock Staff AcquisitionsHome StaffAuthoritiesHome StaffCataloguing Home StaffListsHome StaffPatronsHome StaffPOSHome StaffSerialsHome -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36083 --- Comment #4 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 170616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170616&action=edit Bug 36083: (follow-up) add USE Branches for html customizations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36083 --- Comment #5 from Brendan Lawlor <blawlor@clamsnet.org> --- (In reply to Sam Lau from comment #2)
Everything works except for StaffAuthoritiesHome
Good catch. I didn't realize that page didn't include Branches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36083 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36083 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170615|0 |1 is obsolete| | --- Comment #6 from Sam Lau <samalau@gmail.com> --- Created attachment 170617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170617&action=edit Bug 36083: Fix HTML additional contents for the logged in branchcode This patch updates the calls to AdditionalContents.get() to use Branches.GetLoggedInBranchcode instead of the logged in users homebranch for the library parameter. To test: 1. In Tools > HTML Customizations 2. Choose to create an entry in StaffAcquisitionsHome 3. Assign it to a specific library It's helpful to test with libraries other than Centerville 4. Add text and publication date (important or it will never display) 5. Save 6. Go to the Acquisitions Home page - logged into that library, no text displays. 7. Apply patch and refresh browser 8. Notice the library specifc content displays 9. Notice content created for all libraries still displays too 10. Test HTML content for specific libraries works on all 8 pages IntranetmainUserBlock Staff AcquisitionsHome StaffAuthoritiesHome StaffCataloguing Home StaffListsHome StaffPatronsHome StaffPOSHome StaffSerialsHome Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36083 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170616|0 |1 is obsolete| | --- Comment #7 from Sam Lau <samalau@gmail.com> --- Created attachment 170618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170618&action=edit Bug 36083: (follow-up) add USE Branches for html customizations Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36083 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170617|0 |1 is obsolete| | --- Comment #8 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 171798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171798&action=edit Bug 36083: Fix HTML additional contents for the logged in branchcode This patch updates the calls to AdditionalContents.get() to use Branches.GetLoggedInBranchcode instead of the logged in users homebranch for the library parameter. To test: 1. In Tools > HTML Customizations 2. Choose to create an entry in StaffAcquisitionsHome 3. Assign it to a specific library It's helpful to test with libraries other than Centerville 4. Add text and publication date (important or it will never display) 5. Save 6. Go to the Acquisitions Home page - logged into that library, no text displays. 7. Apply patch and refresh browser 8. Notice the library specifc content displays 9. Notice content created for all libraries still displays too 10. Test HTML content for specific libraries works on all 8 pages IntranetmainUserBlock Staff AcquisitionsHome StaffAuthoritiesHome StaffCataloguing Home StaffListsHome StaffPatronsHome StaffPOSHome StaffSerialsHome Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36083 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170618|0 |1 is obsolete| | --- Comment #9 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 171799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171799&action=edit Bug 36083: (follow-up) add USE Branches for html customizations Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36083 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36083 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171798|0 |1 is obsolete| | --- Comment #10 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 171800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171800&action=edit Bug 36083: Fix HTML additional contents for the logged in branchcode This patch updates the calls to AdditionalContents.get() to use Branches.GetLoggedInBranchcode instead of the logged in users homebranch for the library parameter. To test: 1. In Tools > HTML Customizations 2. Choose to create an entry in StaffAcquisitionsHome 3. Assign it to a specific library It's helpful to test with libraries other than Centerville 4. Add text and publication date (important or it will never display) 5. Save 6. Go to the Acquisitions Home page - logged into that library, no text displays. 7. Apply patch and refresh browser 8. Notice the library specifc content displays 9. Notice content created for all libraries still displays too 10. Test HTML content for specific libraries works on all 8 pages IntranetmainUserBlock Staff AcquisitionsHome StaffAuthoritiesHome StaffCataloguing Home StaffListsHome StaffPatronsHome StaffPOSHome StaffSerialsHome Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36083 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171799|0 |1 is obsolete| | --- Comment #11 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 171801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171801&action=edit Bug 36083: (follow-up) add USE Branches for html customizations Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36083 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #12 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Great job here, Brendan! Passing QA! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36083 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36083 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36083 --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36083 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Doesn't clean apply to 24.05.x, rebase if needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org