[Bug 38043] New: KohaTimes filter is missing tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38043 Bug ID: 38043 Summary: KohaTimes filter is missing tests Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Bug 36594 introduced a new template filter, but didn't provide tests. Full code and use cases coverage is expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38043 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Depends on| |36594 Assignee|chris@bigballofwax.co.nz |cj.lynce@westlakelibrary.or | |g Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 [Bug 36594] Library hours display issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38043 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38043 --- Comment #1 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Created attachment 172362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172362&action=edit Bug 38043: Add unit tests for KohaTimes TT filter This adds units tests for the new KohaTimes TT filter. This also corrects a minor issue with a wrong comparitor operation in KohaTimes.pm causing a WARN to be thrown. To test 1. Apply patch 2. prove t/db_dependent/Template/Plugin/KohaTimes.t 3. Verify 5 Tests PASS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38043 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38043 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38043 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172362|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 172387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172387&action=edit Bug 38043: Add unit tests for KohaTimes TT filter This adds units tests for the new KohaTimes TT filter. This also corrects a minor issue with a wrong comparitor operation in KohaTimes.pm causing a WARN to be thrown. To test 1. Apply patch 2. prove t/db_dependent/Template/Plugin/KohaTimes.t 3. Verify 5 Tests PASS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38043 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version|unspecified |Main QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38043 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38043 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172387|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 172497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172497&action=edit Bug 38043: Add unit tests for KohaTimes TT filter This adds units tests for the new KohaTimes TT filter. This also corrects a minor issue with a wrong comparitor operation in KohaTimes.pm causing a WARN to be thrown. To test 1. Apply patch 2. prove t/db_dependent/Template/Plugin/KohaTimes.t 3. Verify 5 Tests PASS Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38043 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I LOVE tests :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38043 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38043 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38043 Bug 38043 depends on bug 36594, which changed state. Bug 36594 Summary: Library hours display issues https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36594 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38043 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org