[Bug 7996] New: Patron Modification Log Requires Parameters Permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 Priority: P5 - low Change sponsored?: --- Bug ID: 7996 CC: gmcharlt@gmail.com Assignee: kyle.m.hall@gmail.com Summary: Patron Modification Log Requires Parameters Permission QA Contact: koha.sekjal@gmail.com Severity: normal Classification: Unclassified OS: All Reporter: nengard@gmail.com Hardware: All Status: NEW Version: master Component: Patrons Product: Koha Created attachment 9274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9274&action=edit without parameters permission See attached. The "Modification Log" tab does not appear while viewing a patron's record (Detail, Check Out) unless the staff member has the "Set Koha system parameters" priviledge enabled. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 9275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9275&action=edit with parameters permission -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe this would be a good one to clean up for the academy too. As far I can see there are 4 files linking to the modification logs: koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc 33 [% IF ( CAN_user_tools_view_system_logs ) %][% IF ( logview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=CATALOGUING&action=MODIFY&object=[% biblionumber %]">Modification log</a> </li>[% END %] koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc 77 [% IF ( logview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=MEMBERS&modules=circulation&object=[% borrowernumber %]&src=circ">Modification log</a></li> koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.tt 77 [% IF ( CAN_user_parameters ) %][% IF ( logview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=MEMBERS&modules=circulation&object=[% borrower.borrowernumber %]&src=circ">Modification log</a></li>[% END %] koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc 13 [% IF ( logview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=MEMBERS&action=MODIFY&object=[% borrowernumber %]">Modification log</a></li> Only the first seems to be using the correct permission check. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 --- Comment #3 from Rochelle Healy <rochellehealy.student@wegc.school.nz> --- Created attachment 35262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35262&action=edit Bug 7996: Patron Modification Log Requires Parameters Permission To test 1- Open 'set permissions' on patron page and uncheck '(parameters) Set koha system parameters' 2- Open patron page and notice that there is no 'modification log' tab 3- Apply patch 4- Refresh page and notice 'modification log' tab is there -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 Rochelle Healy <rochellehealy.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |rochellehealy.student@wegc. | |school.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Rochelle, the way it works after your patch, it will need both the permission 'parameters' and 'view_system_logs'. I think what we need to do here is take a look at all the conditions [IF ...] that apply to show the link and check which are really needed / make sense. My feeling is that it would make sense to use 'view_system_logs' everywhere, as this is the more specific permission. What do others think? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 Fiona Borthwick <fiona.borthwick@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org