[Bug 23526] New: Shibboleth login url with query has double encoded '?' %3F
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526 Bug ID: 23526 Summary: Shibboleth login url with query has double encoded '?' %3F Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org In login_shib_url we place an encoded '?' into the login url: 65 if ( $query->query_string() ) { 66 $param = $param . '%3F' . $query->query_string(); 67 } Then in the templates we filter that using the URL filter: <p>If you have a Shibboleth account, please <a href="[% shibbolethLoginUrl | url %]">click here to login</a>.</p> The URL filter turns the % into %25 and the string comes out as https://anykoha.bywatersolutions.com/Shibboleth.sso/Login?target=https://any... This returns a 4040 on successful login -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 92699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92699&action=edit Bug 23526: Don't use encoded question mark in shib_login_url To test: 1 - Enable shib 2 - Do a search 3 - Try to login from search 4 - Get an error 5 - Apply patch 6 - Retry Note: You don't haveto really enable shib, you can simply enable it in koha-conf.xml and check the URLs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92699|0 |1 is obsolete| | --- Comment #2 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 92939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92939&action=edit Bug 23526: Don't use encoded question mark in shib_login_url To test: 1 - Enable shib 2 - Do a search 3 - Try to login from search 4 - Get an error 5 - Apply patch 6 - Retry Note: You don't haveto really enable shib, you can simply enable it in koha-conf.xml and check the URLs Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger@biblibr | |e.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Passed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am moving this PQA as the change is tiny and I trust Nick and Matthias. Also our RM is a Shibboleth pro. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.04 released in| | --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526 --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Oh but UT needs to be fixed : Auth_with_shibboleth.t "login shib url" calls : is( login_shib_url($query), 'https://testopac.com' . '/Shibboleth.sso/Login?target=' . 'https://testopac.com/cgi-bin/koha/opac-user.pl' . '%3F' . $query_string, "login shib url" ); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526 --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Fridolin SOMERS from comment #6)
Oh but UT needs to be fixed :
Auth_with_shibboleth.t "login shib url" calls :
is( login_shib_url($query), 'https://testopac.com' . '/Shibboleth.sso/Login?target=' . 'https://testopac.com/cgi-bin/koha/opac-user.pl' . '%3F' . $query_string, "login shib url" );
Corrected by : Bug 23526: (RM follow-up) Fix failing test Perfect 👌 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23526 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.11 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org