[Bug 31516] New: Missing error handling for accessing deleted/non-existent club enrollment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31516 Bug ID: 31516 Summary: Missing error handling for accessing deleted/non-existent club enrollment Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: joonas.kylmala@iki.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If you visit in staff interface club enrollment page for a non-existent club you get a somewhat broken page, e.g. http://localhost:8081/cgi-bin/koha/clubs/club-enrollments.pl?id=101010100100... We should provide a clear error message that the club the user tried to view doesn't exists. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31516 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31516 --- Comment #1 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 140178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140178&action=edit Bug 31516: Add error message for viewing enrollments for a non-existent club To test: 1) Go to non-existent club's enrollment page, e.g. http://localhost:8081/cgi-bin/koha/clubs/club-enrollments.pl?id=101010100100... 2) Notice the not fully filled header text and empty table 3) Apply patch and revisit the page to see the proper error message given -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31516 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140178|0 |1 is obsolete| | --- Comment #2 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 140179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140179&action=edit Bug 31516: Add error message for viewing enrollments for a non-existent club To test: 1) Go to non-existent club's enrollment page, e.g. http://localhost:8081/cgi-bin/koha/clubs/club-enrollments.pl?id=101010100100... 2) Notice the not fully filled header text and empty table 3) Apply patch and revisit the page to see the proper error message given -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31516 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |joonas.kylmala@iki.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31516 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31516 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140179|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 140326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140326&action=edit Bug 31516: Add error message for viewing enrollments for a non-existent club To test: 1) Go to non-existent club's enrollment page, e.g. http://localhost:8081/cgi-bin/koha/clubs/club-enrollments.pl?id=101010100100... 2) Notice the not fully filled header text and empty table 3) Apply patch and revisit the page to see the proper error message given Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31516 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds an error message release notes| |when viewing enrollments | |for a non-existent club. | |Previously, the title and | |table displayed were empty. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31516 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140326|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140475&action=edit Bug 31516: Add error message for viewing enrollments for a non-existent club To test: 1) Go to non-existent club's enrollment page, e.g. http://localhost:8081/cgi-bin/koha/clubs/club-enrollments.pl?id=101010100100... 2) Notice the not fully filled header text and empty table 3) Apply patch and revisit the page to see the proper error message given Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31516 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Trivial fix, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31516 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This adds an error message |This adds an error message release notes|when viewing enrollments |when viewing enrollments |for a non-existent club. |for a non-existent club. |Previously, the title and |Previously, a page with an |table displayed were empty. |empty title and table were | |displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31516 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31516 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31516 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.07 released in| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.07 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31516 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org