[Bug 31486] New: Deleting a message from circulation.pl redirects to moremember.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486 Bug ID: 31486 Summary: Deleting a message from circulation.pl redirects to moremember.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If you are on the patron checkout page (circulation.pl) and you delete a message you will be redirected to the details page (moremember.pl) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 139967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139967&action=edit Bug 31486: Redirect to proper page after message deletion To test: 1. Go to a patron account and create some messages 2. Try deleting some from both the patron details page and the patron checkout page. 3. Notice that is you are on the patron checkout page and delete a message you are then redirected to the patron details page. 4. Apply patch 5. Try deleting messages from both pages and confirm you are redirected back to that same page and the message is properly deleted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Text to go in the| |This patch corrects a release notes| |problem where message | |deletion was improperly | |redirecting to the patron | |delete page when a message | |is deleted on the | |circulation page. Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139967|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 140309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140309&action=edit Bug 31486: Redirect to proper page after message deletion To test: 1. Go to a patron account and create some messages 2. Try deleting some from both the patron details page and the patron checkout page. 3. Notice that is you are on the patron checkout page and delete a message you are then redirected to the patron details page. 4. Apply patch 5. Try deleting messages from both pages and confirm you are redirected back to that same page and the message is properly deleted. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Summary|Deleting a message from |Deleting a message from |circulation.pl redirects to |checkouts tab redirects to |moremember.pl |detail tab in patron | |account -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140309|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 140402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140402&action=edit Bug 31486: Redirect to proper page after message deletion To test: 1. Go to a patron account and create some messages 2. Try deleting some from both the patron details page and the patron checkout page. 3. Notice that is you are on the patron checkout page and delete a message you are then redirected to the patron details page. 4. Apply patch 5. Try deleting messages from both pages and confirm you are redirected back to that same page and the message is properly deleted. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 140404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140404&action=edit Bug 31513: Remove price formatting form data- attributes We cannot use data formatted with a decimal comma for calculations. So we need to make sure that the data- attributes passed to the modals are in 'database format' with decimal . This will fix the NaN errors on the forms, but might also negatively effect formatting in some spots. Formatting should be fixed separately as this is for sure the right first step, but we need to put in more work for displays. To test: * Set CurrencyFormat system preference to FR * Go to any patron account > accounting tab * Create a credit * On Transactions tab: Payout amount at bottom = Verify NaN in input * On Transactions tab: Issue payout on the credit line = Verify NaN in input * Create a manual debit and pay it * On Transactions tab: Issue refund = Verify NaN in input * Apply patch * Repeat test plan * Now all input fields should be set with the correct amounts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.07 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.07 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|22.11.00, 22.05.07 |22.11.00, 22.05.07, released in| |21.11.14 CC| |arthur.suzuki@biblibre.com --- Comment #7 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11 for 21.11.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31486 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor@tuxayo.net --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org