http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |master Summary|stat wizrad: circulation |Statistics wizard: |(new filters) |circulation (new filters) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13099&action=edit Bug 7679: Followup: circulation statistics wizard improvements -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 MathildeF <mathilde.formery@ville-nimes.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathilde.formery@ville-nime | |s.fr --- Comment #4 from MathildeF <mathilde.formery@ville-nimes.fr> --- Tested in sandbox (maroille) It works (I compared the results with report sql) just one thing : It seems that the limits of end intervals are included for Period and exclued for itemcallnumber ? (see Stéphane Delaye comment) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Assignee|julian.maurice@biblibre.com |brendan@bywatersolutions.co | |m --- Comment #6 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 16243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16243&action=edit Bug-7679-Followup-circulation-statistics-wizard-impr.patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13099|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16243|0 |1 is patch| | Attachment #16243|application/octet-stream |text/plain mime type| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 0) See comment about Brendan's patch. 1) I am a bit confused about some things in this patch, for example on master we get for the filters: 'Event issue' and with this patch it's 'AA issue'. 2) Also I note that the filters part before = is not translatable, but that's not a regression. 3) I would like to see Mathilde's comment addressed. 4) I think I need a test plan for creating a report that groups by hour (I have not many issues in my database, so it should be as general as possible). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Hi Katrin, 0) Yes, /branch/ is changed to /^branch/ to distinguish from /homebranch/ and /holdingbranch/ 1) This is a bug + debug residues (I'll write a patch) 3) It seems that Mathilde is right: date filters are inclusive, and end itemcallnumber filter is exclusive (for this one it is explicitly mentioned) Is this a problem? 4) All you need is some issues made at different hours (check statistics.datetime). - chose "Period" for row and select "group by hour" - chose another for column (for example categorycode) - submit - values in row N represent how much issues have been made between N:00 (inclusive) and (N+1):00 (exclusive) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2012-09-24 last check this| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 --- Comment #14 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Hi Nice enh Tested on sandbox 1 * Test of Sort by hours: seems OK Period From 03/09/2013 Period To 04/09/2013 Library = MAURES Home branch = MAURES Holding branch = MAURES Event = issue Display by = 4 datetime / itemtype Compact Disque Livre audio Livre Revue TOTAL 9 0 0 0 1 0 0 1 10 0 0 0 2 0 0 2 11 0 0 0 3 0 0 3 In database : 2013-09-03 09:45:23 MAURES 0.0000 issue 5464 LIVR 6068 2013-09-03 10:57:34 MAURES 0.0000 issue 4862 LIVR 7570 2013-09-03 10:57:44 MAURES 0.0000 issue 1338 LIVR 7570 2013-09-03 11:19:39 MAURES 0.0000 issue 5663 LIVR 3488 2013-09-03 11:29:47 MAURES 0.0000 issue 2171 LIVR 3431 2013-09-03 11:39:31 MAURES 0.0000 issue 4350 LIVR 5212 * test of flter by itemtype : seems ok (same kind of test) * test of patron attribute filter : - display all checkouts between 01/08/2013 and 04/09/2013 ; dates in columns ; professions in rows => I did not check database, but presentation of results seemed ok : agent administratif 0 0 0 0 0 0 0 0 0 0 0 agent d'accueil 0 0 0 0 0 0 0 0 0 0 0 enfant 0 0 1 0 0 0 0 0 0 0 1 Enseignant 0 0 1 0 0 0 0 0 0 0 1 etc. - use a value of attribute Profession as a filter : value "Enseignant" display only one line => ok PROFESSION / datetime 9 10 11 12 13 14 15 16 17 18 TOTAL Enseignant 0 0 1 0 0 0 0 0 0 0 1 TOTAL 0 0 1 0 0 0 0 0 0 0 3 ============ But, at that point, I remarked a bug : TOTAL is wrong : the last column is displaying "3", while the last column for the only row ('Enseignant') is 1. So, for Koha, the "sum" of 1 is 3. Wrong somewhere Other remarks (cosmetic) I think "Item type" should be better understood if named "Document type". That make obvious that is using biblioitems.itemtype (I suppose so?) and not items.itype. In the results, the " Display by = [1...4] " line is not easy to understand. It seems that each number match a kind of date grouping (hours, months...). Could you display it in plain english? Could you check the calculation of "TOTAL" line? M. Saby -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> --- The problem is that PROFESSION attribute has equivalent values with different cases. mysql> SELECT attribute FROM borrower_attributes WHERE code = 'PROFESSION' AND borrower_attributes.attribute is not null AND borrower_attributes.attribute LIKE 'Enseignant'; +------------+ | attribute | +------------+ | Enseignant | | enseignant | +------------+ The mysql GROUP BY clause is case insensitive, so in the process we lose one of those values mysql> SELECT attribute FROM borrower_attributes WHERE code = 'PROFESSION' AND borrower_attributes.attribute is not null AND borrower_attributes.attribute LIKE 'Enseignant' group by attribute; +------------+ | attribute | +------------+ | Enseignant | +------------+ The TOTAL takes into account 'Enseignant' and 'enseignant' values but does not display the 'enseignant' value because of that. I don't know what is the best way to solve this issue. Should we continue to display only one line but display all values in the same line? Or should we display multiple lines for every "case-variant"? Changing status to "In discussion". -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 --- Comment #18 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 22745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22745&action=edit Bug 7679: Group different case values in the same row/column -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 --- Comment #20 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (In reply to Paul Poulain from comment #17)

isn't that a bug in the dataset ? Seems silly to me to have "enseignant" and "Enseignant" being 2 different values...

Yes, that would be silly! Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 --- Comment #22 from Koha Team AMU <koha.aixmarseille@gmail.com> --- (In reply to Julian Maurice from comment #19)

This is a proposal patch for the first mentioned option : display only one line with all "case-variant" values in it.

The 2nd option seems to require more work.

It's ok for this patch. "agent administratif" and "Agent administratif" are included in the same row. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #24 from Julian Maurice <julian.maurice@biblibre.com> --- This patch should fix problems of comment 21 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 --- Comment #26 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 25443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25443&action=edit Bug 7679: Fix two SQL queries when using patron attributes and remove some Perl warnings -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Koha Team AMU <koha.aixmarseille@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #28 from Koha Team AMU <koha.aixmarseille@gmail.com> --- So sorry, problem is not fixed ! Test options : Test on sandbox (Langres) Filtered on: Period From 01/01/2012 To 31/12/2012 Event = issue Column = Library (all values) Cell value : Count total items --> in all results (except the following one), with differents options in rows , total = 6251 - test on row = Patron attribute (all values) Output : to screen into the browser --> The last row "TOTAL" does not make sense (0 + 6237 = 6251 !!!) PROFESSION / branch BDP MAURES TOTAL agent administratif 0 0 0 (...) Urbaniste 0 7 7 NULL 0 6063 6063 TOTAL 0 6237 6251 Output : To a file --> The last row "TOTAL" does not appear but when I work out the total, I have total sum for each column = 6237. - test on row = patron sort 1 or row=patron sort 2 borrowers.sort1 / branch BDP MAURES TOTAL (...) NULL 0 2317 2317 TOTAL 0 8568 6251 --> Total of the 2nd column is higher than total sum - test on row = itemtype or row = shelving location itemtype / branch BDP MAURES TOTAL UNKNOWN VALUE 0 0 0 Compact Disque 0 463 463 Livre audio 0 24 24 Livre 0 5041 5041 Revue 0 688 688 UNKNOWN VALUE 0 35 35 TOTAL 0 6251 6251 --> there are many rows "Unknown value" with differents results Change status in "Failed QA" (hope so to change status in "signed off" soon ! ;-) ) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #30 from Julian Maurice <julian.maurice@biblibre.com> --- Hopefully, I easily reproduced your problems. This patch fixed them for me, so I hope it will work for you too :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 --- Comment #32 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 31311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31311&action=edit Bug 7679: Display all table headers (case and accent sensitive) It appears that we can't assume that a lowercase word is equivalent to the same word in uppercase (or a mix of lowercase and uppercase letters). And this is also true about accented words. So display all values even if they differ only by case or by their accents. This means that: - "foobar" and "Foobar" will be in two separate rows/columns - "Etudiant" and "Étudiant" (french) will be in two separate rows/columns too -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16242|0 |1 is obsolete| | --- Comment #33 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39250&action=edit Bug 7679: circulation statistics wizard improvements - Add patron branch to the list of possible rows, columns, and filters - Add extended patron attributes to the list of possible rows, columns, and filters - Allow to group period by hour - Allow to translate filter names Signed-off-by: Brendan <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17798|0 |1 is obsolete| | --- Comment #35 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39252&action=edit Bug 7679: Fix criteria display -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25053|0 |1 is obsolete| | --- Comment #37 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39254&action=edit Bug 7679: Fix several bugs in circulation statistics wizard - Display values in NULL columns/rows - Display columns/rows that contain values only in NULL rows/columns - "To" filter in period row should be inclusive (YYYY-MM-DD should be YYYY-MM-DD 23:59:59) - Make it possible to use only the "To" filter in period row (actually it results in DBI error (2 bind variables instead of 1)) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26531|0 |1 is obsolete| | --- Comment #39 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39256&action=edit Bug 7679: Various fixes for circulation statistics wizard - use SQL TRIM functions to avoid having '' and ' ' considered as different values - use Text::Unaccent to remove accents from columns or rows values when accessing %table. This is required as MySQL consider as equals two strings that differ only by their accents when using GROUP BY clause. - Exclude '' values from the list of columns or rows. Otherwise we could have a row 'UNKNOWN VALUE' and a row 'NULL' which both have the same values in their cells. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Needs Signoff |Patch doesn't apply --- Comment #43 from Chris Cormack <chris@bigballofwax.co.nz> --- Falling back to patching base and 3-way merge... Auto-merging reports/issues_stats.pl CONFLICT (content): Merge conflict in reports/issues_stats.pl Failed to merge in the changes. Not a simple conflict -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39250|0 |1 is obsolete| | --- Comment #45 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 46184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46184&action=edit Bug 7679: circulation statistics wizard improvements - Add patron branch to the list of possible rows, columns, and filters - Add extended patron attributes to the list of possible rows, columns, and filters - Allow to group period by hour - Allow to translate filter names NOTE: Removed signed off, since I believe I have dealt with the conflicts. Retesting required. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39252|0 |1 is obsolete| | --- Comment #47 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 46186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46186&action=edit Bug 7679: Fix criteria display -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39254|0 |1 is obsolete| | --- Comment #49 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 46188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46188&action=edit Bug 7679: Fix several bugs in circulation statistics wizard - Display values in NULL columns/rows - Display columns/rows that contain values only in NULL rows/columns - "To" filter in period row should be inclusive (YYYY-MM-DD should be YYYY-MM-DD 23:59:59) - Make it possible to use only the "To" filter in period row (actually it results in DBI error (2 bind variables instead of 1)) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39256|0 |1 is obsolete| | --- Comment #51 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 46190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46190&action=edit Bug 7679: Various fixes for circulation statistics wizard - use SQL TRIM functions to avoid having '' and ' ' considered as different values - use Text::Unaccent to remove accents from columns or rows values when accessing %table. This is required as MySQL consider as equals two strings that differ only by their accents when using GROUP BY clause. - Exclude '' values from the list of columns or rows. Otherwise we could have a row 'UNKNOWN VALUE' and a row 'NULL' which both have the same values in their cells. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46184|0 |1 is obsolete| | --- Comment #53 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 46192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46192&action=edit Bug 7679: circulation statistics wizard improvements - Add patron branch to the list of possible rows, columns, and filters - Add extended patron attributes to the list of possible rows, columns, and filters - Allow to group period by hour - Allow to translate filter names NOTE: Removed signed off, since I believe I have dealt with the conflicts. Retesting required. Found some comments C4::Date that I missed. line prepatch 194/ postpatch 233 seems to be where the major conflict is. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46186|0 |1 is obsolete| | --- Comment #55 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 46194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46194&action=edit Bug 7679: Fix criteria display -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46188|0 |1 is obsolete| | --- Comment #57 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 46196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46196&action=edit Bug 7679: Fix several bugs in circulation statistics wizard - Display values in NULL columns/rows - Display columns/rows that contain values only in NULL rows/columns - "To" filter in period row should be inclusive (YYYY-MM-DD should be YYYY-MM-DD 23:59:59) - Make it possible to use only the "To" filter in period row (actually it results in DBI error (2 bind variables instead of 1)) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46190|0 |1 is obsolete| | --- Comment #59 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 46198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46198&action=edit Bug 7679: Various fixes for circulation statistics wizard - use SQL TRIM functions to avoid having '' and ' ' considered as different values - use Text::Unaccent to remove accents from columns or rows values when accessing %table. This is required as MySQL consider as equals two strings that differ only by their accents when using GROUP BY clause. - Exclude '' values from the list of columns or rows. Otherwise we could have a row 'UNKNOWN VALUE' and a row 'NULL' which both have the same values in their cells. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.