http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 --- Comment #1 from Elliott Davis <elliott@bywatersolutions.com> --- Created attachment 14257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14257&action=edit Bug 9316: Add ability to install/configure nginx To Test: 1) Ensure that you have nginx installed 2) Esure that you have the following packages installed libplack-perl libcgi-emulate-psgi-perl libcgi-compile-perl 3) Apply patch 4) Run through the make file, you will notice 5 new configuration options. 5) Make sure you choose NGiNX as your webserver 6) You may choose whatever ports you wish and also whatever DNS entries you wish 7) After you're done configuring run make 8) Run make install (you may need sudo if you've used sudo before) 9) Start plack (you may wish to copy the script to init.d) with the script in koha-dev/bin/koha-plack.sh (requires sudo) 10) TURN OFF APACHE, and start NGiNX 11) go to your web browser and see if everything fires up as normal. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 --- Comment #2 from Elliott Davis <elliott@bywatersolutions.com> --- A note, this is pretty preliminary so please TEST TEST TEST and let me know if you spot anything. I will try and patch ASAP. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- A few notes so far: I'm doing my initial testing on a comletely clean install of Debian Stable. I'm also working through it as a dev type install 1. /home/koha/koha-dev/var/run/plack is not created during make install, therefore the make issues the error: chmod: cannot access '/home/koha/koha-dev/var/run/plack' - I created this directory manual an re-ran the make install.. no other errors were reported. 2. I noticed that koha-httpd.conf is still created (along with koha-nginx.conf) under koha-dev/etc/.. should this be the case still for nginx configurations? 3. The two scripts created under /koha-dev/bin are not created with executable permission like the rest of the scripts within that directory? (koha-plack.sh and koha.psgi) After correcting the above simple problems and symlinking the koha-nginx.conf to /etc/nginx/site-enabled and restarting nginx. 4. Attempting to run 'sudo /etc/init.d/koha-plack.sh start' results in the following error: Starting Koha Plack Daemon /etc/init.d/koha-plack: 72: [[: not found /etc/init.d/koha-plack: 72: starman: not found At this point I stopped. Great start on the work, but for me it's not yet working.. I'm reminding myself how plack is meant to work now and will report back if/when I get further. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 --- Comment #7 from Elliott Davis <elliott@bywatersolutions.com> --- Hey Martin, You're absolutely right about the directories and permissions. I forgot I made those early on and forgot to include them in the patch. I'll push an update soon and make sure those directories get created with the correct permissions. I'll also take a look at the plack init script and see what could be causing the ]] warning. Did you install the starman deps? I noticed my copy of starman was in /usr/local/bin but it could be different for you. If starman isn't in your path that would explain why it isn't executing. Thanks for testing, I had a feeling I would be running into some permission/file issues like these. Elliott Davis -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 --- Comment #9 from Elliott Davis <elliott@bywatersolutions.com> --- Martin, I am just grateful for getting some feedback. I didn't want this to get stuck and never make it. Don't worry I promise to take all comments constructively :) I too had a go with the 502 errors from nginx. What I was seeing was a permissions error for the user for the plack script. You are probably seeing the same issue. If you run a tail -f /var/log/nginx/error.log (or where ever your log dir is) you should probably see something similar. I assumed it was just my setup. I resolved the issue by starting plack as the sudo user. Zebra runs as the koha user but I am thinking it may be a requirement to run plack as root. Let me know what you think/see. Elliott Davis -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- That's interesting.. It was indeed a permissions thing (once I'd sorted out a few other missing dependencies that were flagged at the end of the Makefile.pl run) I found the issue was solved by giving 'write' permission for the 'group'.. My permissions are now: -rw-r--r-- 1 root root 5 Jan 2 18:49 plack.pid srwxrwxr-x 1 koha www-data 0 Jan 2 18:49 plack.sock Although running /etc/init.d/koha-plack seems to reset ownership to koha:koha? PS: The missing dependencies that I had neglected earlier were: starman CGI::Emulate::PSGI CGI::Compile Plack::Middleware::Debug -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Found a fix for the above missing supplementary files. Looking at the below error in /var/log/nginx/error.log: 2013/01/02 19:16:59 [error] 1192#0: *135 open() "/home/koha/kohaclone/koha-tmpl/intranet-tmpl/intranet-tmpl/prog/en/includes/favicon.ico" failed (2: No such file or directory), client: 192.168.0.10, server: plack.koha-ptfs.eu, request: "GET /intranet-tmpl/prog/en/includes/favicon.ico HTTP/1.1", host: "plack.koha-ptfs.eu" I noted that is looked as though an extra '/intranet-tmpl/' was appearing in the directory tree. I edited the koha-nginx.conf file removing '/opac-tmpl/' from line 18 and '/intranet-tmpl/' from line 42. I'm not expert in nginx config file though.. so hopefully you'll spot if that's not the way it should be. This is all on a dev install still.. I'll also test with a from scratch install using the production install mechanism. Also.. is the plDebug bar meant to display be default in a plack install (or have I somehow inadvertently added a debug environment variable without meaning to?) Martin -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 --- Comment #15 from Elliott Davis <elliott@bywatersolutions.com> --- I've made the requested changes to the nginx configs and the plack startup script. You should still have to start the plack script as root. I am still trying to figure out how to create the correct permissions to run plack as the koha user. Typically scripts in /etc/init.d are run as root but if I remember correctly koha-zebra-ctl.sh is run as the koha user. I also made one tine change for non-dev installs to path the run directory correctly. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14370|0 |1 is obsolete| | --- Comment #17 from Elliott Davis <elliott@bywatersolutions.com> --- Created attachment 14371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14371&action=edit Bug 9316: Add ability to install/configure nginx Added perms change -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14375|0 |1 is obsolete| | --- Comment #19 from Elliott Davis <elliott@bywatersolutions.com> --- Created attachment 14376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14376&action=edit Bug 9316: Add ability to install/configure nginx attempting to fix debian control -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- not applied that last one yet.. but spotted an error in the code.. Your chmod in the new koha-plack.sh You've missed the "T" at then end, and the permission required I think is 666, 775 doesn't appear to work.. (666 is the same as the zebra sockets permissions) I'd have made the cahnge myself.. but it looks like your working on it so I thought it sensible to wait until your happy with what you've got. As a niggle. Might it be sensible to split up the lock and run files to follow the conventions in the zebra server.. (ie. put the lock file inside /var/lock/plack)? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14378|0 |1 is obsolete| | --- Comment #23 from Elliott Davis <elliott@bywatersolutions.com> --- Created attachment 14379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14379&action=edit Bug 9316: Add ability to install/configure nginx fix for debian control Plack::Middleware::Debug and Starman have no packages -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 --- Comment #25 from Elliott Davis <elliott@bywatersolutions.com> --- the reason I chose a .sh was mostly due to the fact that I don't have much experience in shell scripting of any kind so I modeled the file after koha-zebra-ctl.sh. I have altered the socket permissions to run under 660 rather that 775 or 666. Feel free to modify from here on out I think I am done pushing changed to it for today. Elliott -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 --- Comment #27 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Martin, please make sure you have your git user set up so that you can get credit for your work: git config --global user.name "your NAME" git config --global user.email "your@mail.com" -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14383|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 14385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14385&action=edit Bug 9316: Followup patch with suggested additions Amended commit author details as requested. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14381|0 |1 is obsolete| | --- Comment #31 from Elliott Davis <elliott@bywatersolutions.com> --- Created attachment 14789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14789&action=edit Bug 9316: Add ability to install/configure nginx Amended permissions for plack socket and fixed type Altered mount location for opac to reflect current koha path settings -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net --- Comment #33 from Mirko Tietgen <mirko@abunchofthings.net> --- Applying: Bug 9316: Add ability to install/configure nginx - Minor Corrections fatal: sha1 information is lacking or useless (C4/Installer/PerlDependencies.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Not sure what that means or how to resolve it. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14789|0 |1 is obsolete| | --- Comment #34 from Elliott Davis <elliott@bywatersolutions.com> --- Created attachment 15859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15859&action=edit Bug 9316: Add ability to install/configure nginx Amended permissions for plack socket and fixed type Altered mount location for opac to reflect current koha path settings Update: Resolved merge problems -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #36 from Elliott Davis <elliott@bywatersolutions.com> --- (In reply to comment #35)

Patches appear to be applied in the wrong order.

...

4) Run through the make file, you will notice 5 new configuration options.

No, I don't. Am I missing something obvious?

They do seem to be in the wrong order in BZ. The new configuration options are Staff/OPAC DNS and port entries. I think the problem with the merge was the incorrect order. If you apply the patches backwards it should be fine. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 --- Comment #38 from Elliott Davis <elliott@bywatersolutions.com> --- (In reply to comment #37)

...

5) Make sure you choose NGiNX as your webserver

So this is not supposed to happen when I run the makefile?

This was in an older version of the patch. It was removed at the request of the RM. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 --- Comment #40 from Elliott Davis <elliott@bywatersolutions.com> --- that should be the only one. To Test: 1) Ensure that you have nginx installed 2) Esure that you have the following packages installed libplack-perl libcgi-emulate-psgi-perl libcgi-compile-perl 3) Apply patch 4) Run through the make file, you will notice 4 new configuration options. 5) You may choose whatever ports you wish and also whatever DNS entries you wish 6) After you're done configuring run make 7) Run make install (you may need sudo if you've used sudo before) 8) Start plack (you may wish to copy the script to init.d) with the script in koha-dev/bin/koha-plack.sh (requires sudo) 9) TURN OFF APACHE, and start NGiNX 10) go to your web browser and see if everything fires up as normal. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 --- Comment #42 from Mirko Tietgen <mirko@abunchofthings.net> --- I meant »502 Bad Gateway« Log message in readable form: 2013/03/09 09:53:30 [error] 22634#0: *17 connect() to unix:/var/run/testkoha/plack/plack.sock failed (11: Resource temporarily unavailable) while connecting to upstream, client: 192.168.2.1, server: localhost, request: "GET / HTTP/1.1", upstream: "http://unix:/var/run/testkoha/plack/plack.sock:/cgi-bin/koha/mainpage.pl", host: "192.168.2.25:8090" -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15859|0 |1 is obsolete| | --- Comment #43 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 21818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21818&action=edit Bug 9316: Add ability to install/configure nginx Amended permissions for plack socket and fixed type Altered mount location for opac to reflect current koha path settings Update: Resolved merge problems -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #45 from Chris Cormack <chris@bigballofwax.co.nz> --- This took quite a bit of rebasing, I ended up needing to use the old git apply PATCH --reject trick -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pants, just spotted that I created the small follow-up patch.. Can't really sign off then. I'll bully someone at kohacon13 hackfest if the change is made quick enough. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK.. I've been trying to narrow down the bug with requiring Plack::Middleware::Debug. I've narrowed it down to the following lines in koha.psgi: enable_if { $ENV{'KOHA_DEBUG'} } 'Debug', panels => [[ 'DBITrace', level => 1 ], @$panels ]; I think the logic here is flawed somehow. First up I think it should actually be: enable_if { $_[0]->{'KOHA_DEBUG'} } 'Debug', panels => [[ 'DBITrace', level => 1 ], @$panels ]; But this also doesn't work. I think the builder checks for the module availability even if it's not actually to be loaded as part of the enable_if. I'm baffled.. anyone got any idea's how to fix this? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I worked through it and got koha.psgi into a state where Plack::Middleware::Debug is no longer required.. I am a little confused as to how to enable KOHA_DEBUG using nginx however.. any hints would be greatly appreciated. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #53 from Magnus Enger <magnus@enger.priv.no> --- I'm a bit confused by the relationshio between this bug and bug 7844. Culd we say that 7844 is for developers and this bug for production? Or do they overlap? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin@rot13.org -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #56 from Chris Cormack <chris@bigballofwax.co.nz> --- With the plack in production as of 3.22.0 this bug needs a rethink, the patches as they stand will duplicate a lot of stuff -- You are receiving this mail because: You are watching all bug changes.