[Bug 4927] New: OPAC advanced search has two call number entries; remove one?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4927 Summary: OPAC advanced search has two call number entries; remove one? Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Searching AssignedTo: gmcharlt@gmail.com ReportedBy: jwagner@ptfs.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 In the OPAC advanced search, with More Options selected, two Call Number entries show in the search pulldown. The first one is searching the item-level call number: <option value="callnum">Call Number</option> The second one, under the Standard Number section, seems to be searching an index (lccn) for the call number in the bib record -- I verified this by searching something in the 050 that wasn't in the item call number. I don't know if this includes Dewey callnums or just LC callnums, but it seems redundant to me in any case. Any objections to removing this second Call Number search from the OPAC advanced search? It isn't present in the staff advanced search. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4927 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- No objections here - in fact I thought I had fixed that already .... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4927 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #2 from Magnus Enger <magnus@enger.priv.no> --- Both options are still present: <option value="callnum">Call number</option> <option value="lcn,phr"> Call number</option> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4927 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is still valid. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4927 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 30521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30521&action=edit Bug 4927 - OPAC advanced search has two call number entries; remove one? This patch removes the second Call number entry in OPAC Advanced search with Advanced option (for bootstrap). To test: - Go to OPAC, Advanced search, enable Advaced options - In dropdowns you see two entries "Call number" - Apply patch - Verify that the second "Call number" has disappeared (below ISSN) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4927 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |veron@veron.ch Patch complexity|--- |Trivial patch Assignee|gmcharlt@gmail.com |veron@veron.ch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4927 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30521|0 |1 is obsolete| | --- Comment #5 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 30603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30603&action=edit 0001-SIGNED-OFF-Bug-4927-OPAC-advanced-search-has-two-cal.patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4927 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4927 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4927 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30603|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30822&action=edit [PASSED QA] Bug 4927 - OPAC advanced search has two call number entries; remove one? This patch removes the second Call number entry in OPAC Advanced search with Advanced option (for bootstrap). To test: - Go to OPAC, Advanced search, enable Advaced options - In dropdowns you see two entries "Call number" - Apply patch - Verify that the second "Call number" has disappeared (below ISSN) Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template change only - no problems found. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4927 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4927 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC advanced search has |Remove doubled call number |two call number entries; |entry from OPAC advanced |remove one? |search page -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org