[Bug 12760] New: add restrictions purge to cleanup_database.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12760 Bug ID: 12760 Summary: add restrictions purge to cleanup_database.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: fridolyn.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The database cleanup script should have an option to purge expired restrictions (debarments). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12760 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |2720 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12760 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolyn.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12760 --- Comment #1 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 30786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30786&action=edit Bug 12760 - add restrictions purge to cleanup_database.pl This patch adds to the database cleanup script an option to purge expired patron restrictions (debarments in code). Test plan : - Select a borrower - Create a restriction with expiration date in the futur - Create a restriction expired since 7 days - Create a restriction expired since 14 days - run "misc/cronjobs/cleanup_database.pl -v --restrictions 14" => no restriction is removed for this borrower - run "misc/cronjobs/cleanup_database.pl -v --restrictions 13" => restriction expired since 14 days is removed - run "misc/cronjobs/cleanup_database.pl -v --restrictions 6" => restriction expired since 7 days is removed - run without argument "misc/cronjobs/cleanup_database.pl" => You see help text for restrictions option - run without days "misc/cronjobs/cleanup_database.pl -v --restrictions" => You get a purge on 30 days -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12760 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12760 --- Comment #2 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 30788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30788&action=edit Bug 12760 - add restrictions purge to cleanup_database.pl (followup 1) Remove unused $query var Correct redefined $count var -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12760 --- Comment #3 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 30789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30789&action=edit Bug 12760 - add restrictions purge to cleanup_database.pl (followup 2) Formatting : perltidy use q{} for SQL queries add use Modern::Perl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12760 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12760 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30786|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 30813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30813&action=edit Bug 12760 - add restrictions purge to cleanup_database.pl This patch adds to the database cleanup script an option to purge expired patron restrictions (debarments in code). Test plan : - Select a borrower - Create a restriction with expiration date in the futur - Create a restriction expired since 7 days - Create a restriction expired since 14 days - run "misc/cronjobs/cleanup_database.pl -v --restrictions 14" => no restriction is removed for this borrower - run "misc/cronjobs/cleanup_database.pl -v --restrictions 13" => restriction expired since 14 days is removed - run "misc/cronjobs/cleanup_database.pl -v --restrictions 6" => restriction expired since 7 days is removed - run without argument "misc/cronjobs/cleanup_database.pl" => You see help text for restrictions option - run without days "misc/cronjobs/cleanup_database.pl -v --restrictions" => You get a purge on 30 days Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12760 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30788|0 |1 is obsolete| | --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 30814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30814&action=edit Bug 12760 - add restrictions purge to cleanup_database.pl (followup 1) Remove unused $query var Correct redefined $count var Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12760 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12760 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30789|0 |1 is obsolete| | --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 30815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30815&action=edit Bug 12760 - add restrictions purge to cleanup_database.pl (followup 2) Formatting : perltidy use q{} for SQL queries add use Modern::Perl Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12760 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12760 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30813|0 |1 is obsolete| | Attachment #30814|0 |1 is obsolete| | Attachment #30815|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30832&action=edit [PASSED QA] Bug 12760 - add restrictions purge to cleanup_database.pl This patch adds to the database cleanup script an option to purge expired patron restrictions (debarments in code). Test plan : - Select a borrower - Create a restriction with expiration date in the futur - Create a restriction expired since 7 days - Create a restriction expired since 14 days - run "misc/cronjobs/cleanup_database.pl -v --restrictions 14" => no restriction is removed for this borrower - run "misc/cronjobs/cleanup_database.pl -v --restrictions 13" => restriction expired since 14 days is removed - run "misc/cronjobs/cleanup_database.pl -v --restrictions 6" => restriction expired since 7 days is removed - run without argument "misc/cronjobs/cleanup_database.pl" => You see help text for restrictions option - run without days "misc/cronjobs/cleanup_database.pl -v --restrictions" => You get a purge on 30 days Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12760 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30833&action=edit [PASSED QA] Bug 12760 - add restrictions purge to cleanup_database.pl (followup 1) Remove unused $query var Correct redefined $count var Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12760 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30834&action=edit [PASSED QA] Bug 12760 - add restrictions purge to cleanup_database.pl (followup 2) Formatting : perltidy use q{} for SQL queries add use Modern::Perl Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12760 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13166 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12760 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12760 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Component|Patrons |System Administration -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org