[Bug 22477] New: Missing DataTables configuration when searching patrons for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Bug ID: 22477 Summary: Missing DataTables configuration when searching patrons for holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Target Milestone: --- When placing a hold, if the page displays patron search results there is a JavaScript error in the console complaining that KohaTable is not defined. The patron search results table is supposed to be a DataTable with columns configuration but request.tt doesn't provide any column configuration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86328&action=edit Bug 22477: Missing DataTables configuration when searching patrons for holds This patch adds columns configuration to the holds request page to fix a JavaScript error in the console and to allow the patron search results table to be enabled as a DataTable. To reproduce: Place a hold on a title in the staff client. When prompted for a patron, perform a search which will return multiple results. The patron search results will appear in an unsortable table. A JS error can be seen in the browser console. To test, apply the patch and repeat the steps above. The patron search results table should be sortable and there should be no JS error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86328|0 |1 is obsolete| | --- Comment #2 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 86398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86398&action=edit Bug 22477: Missing DataTables configuration when searching patrons for holds This patch adds columns configuration to the holds request page to fix a JavaScript error in the console and to allow the patron search results table to be enabled as a DataTable. To reproduce: Place a hold on a title in the staff client. When prompted for a patron, perform a search which will return multiple results. The patron search results will appear in an unsortable table. A JS error can be seen in the browser console. To test, apply the patch and repeat the steps above. The patron search results table should be sortable and there should be no JS error. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-marc.thibault@inlibr | |o.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Bin <bin.wen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86398|0 |1 is obsolete| | --- Comment #3 from Bin <bin.wen@inlibro.com> --- Created attachment 86399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86399&action=edit Bug 22477: Missing DataTables configuration when searching patrons for holds This patch adds columns configuration to the holds request page to fix a JavaScript error in the console and to allow the patron search results table to be enabled as a DataTable. To reproduce: Place a hold on a title in the staff client. When prompted for a patron, perform a search which will return multiple results. The patron search results will appear in an unsortable table. A JS error can be seen in the browser console. To test, apply the patch and repeat the steps above. The patron search results table should be sortable and there should be no JS error. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should the columns be configurable? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #4)
Should the columns be configurable?
Maybe, but I think that would be a different bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86399|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86467&action=edit Bug 22477: Missing DataTables configuration when searching patrons for holds This patch adds columns configuration to the holds request page to fix a JavaScript error in the console and to allow the patron search results table to be enabled as a DataTable. To reproduce: Place a hold on a title in the staff client. When prompted for a patron, perform a search which will return multiple results. The patron search results will appear in an unsortable table. A JS error can be seen in the browser console. To test, apply the patch and repeat the steps above. The patron search results table should be sortable and there should be no JS error. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com Status|Signed Off |Passed QA --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Owen Leonard from comment #5)
(In reply to Katrin Fischer from comment #4)
Should the columns be configurable?
Maybe, but I think that would be a different bug.
I agree, this patch fixes bug, enhancement could be done on another report -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I agree too - looking at the change I was just wondering, if it should be: columns_settings_borrowers_table = [% ColumnsSettings.GetColumns( 'circ', 'circulation', 'table_borrowers', 'json' ) | $raw %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27292 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 [Bug 27292] TablesSettings.GetColumns() returning nothing creates unexpected Javascript on request.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|27292 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 [Bug 27292] TablesSettings.GetColumns() returning nothing creates unexpected Javascript on request.tt -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org