[Bug 27803] New: publicationyear / copyrightdate not included in Holds to Pull
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27803 Bug ID: 27803 Summary: publicationyear / copyrightdate not included in Holds to Pull Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: joonas.kylmala@helsinki.fi QA Contact: testopia@bugs.koha-community.org CC: aleisha@catalyst.net.nz, gmcharlt@gmail.com Depends on: 24488 The rewrite of Holds to Pull page (circ/pendingreserves.pl) in Bug 24488 missed the copyrightdate / publicationyear data. That should be added back again and we should also verify whether other fields are missing as well. The commit removing the publication year is 2285c2d6575 (Bug 24488: Show correct first patron details on Holds to pull). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27803 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27803 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27803 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 117468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117468&action=edit Bug 27803: Ensure publicationyear or copyrightdate shows in Holds to Pull If marcflavour is set to MARC21, use biblio.copyrightdate. If marcflavour is set to something other than MARC21, use biblioitem.publicationyear. This is to match previous behaviour of this feature. To test: 1) Set your marcflavour system preferenece to MARC21. 2) Go to Administration -> Koha to MARC mapping to confirm what MARC tag maps to biblio.copyrightdate. 3) In your terminal, run misc/batchRebuildBiblioTables.pl from the shell to confirm the mapping is locked. 4) Edit a biblio, fill in whichever field is mapped to biblio.copyrightdate and Save. 5) Place a hold on this biblio. (It must have an available item to allow placing holds.) 6) Go to Circulation -> Holds to Pull. 7) Confirm your hold shows in the table with the copyrightdate. 8) Set your marcflavour system preference to something other thatn MARC21. 9) Go to Administration -> Koha to MARC mapping to confirm what MARC tag maps to biblioitem.publicationyear. 10) In your terminal, run misc/batchRebuildBiblioTables.pl from the shell to confirm the mapping is locked. 11) Edit a biblio, fill in whichever field is mapped to biblioitem.publicationyear and Save. 12) Place a hold on this biblio. (It must have an available item to allow placing holds.) 13) Go to Circulation -> Holds to Pull. 14) Confirm your hold shows in the table with the publicationyear. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27803 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27803 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27803 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117468|0 |1 is obsolete| | --- Comment #2 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 117473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117473&action=edit Bug 27803: Ensure publicationyear or copyrightdate shows in Holds to Pull If marcflavour is set to MARC21, use biblio.copyrightdate. If marcflavour is set to something other than MARC21, use biblioitem.publicationyear. This is to match previous behaviour of this feature. To test: 1) Set your marcflavour system preferenece to MARC21. 2) Go to Administration -> Koha to MARC mapping to confirm what MARC tag maps to biblio.copyrightdate. 3) In your terminal, run misc/batchRebuildBiblioTables.pl from the shell to confirm the mapping is locked. 4) Edit a biblio, fill in whichever field is mapped to biblio.copyrightdate and Save. 5) Place a hold on this biblio. (It must have an available item to allow placing holds.) 6) Go to Circulation -> Holds to Pull. 7) Confirm your hold shows in the table with the copyrightdate. 8) Set your marcflavour system preference to something other thatn MARC21. 9) Go to Administration -> Koha to MARC mapping to confirm what MARC tag maps to biblioitem.publicationyear. 10) In your terminal, run misc/batchRebuildBiblioTables.pl from the shell to confirm the mapping is locked. 11) Edit a biblio, fill in whichever field is mapped to biblioitem.publicationyear and Save. 12) Place a hold on this biblio. (It must have an available item to allow placing holds.) 13) Go to Circulation -> Holds to Pull. 14) Confirm your hold shows in the table with the publicationyear. Sponsored-by: Catalyst IT Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27803 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27803 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117473|0 |1 is obsolete| | --- Comment #3 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 117475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117475&action=edit Bug 27803: Ensure publicationyear or copyrightdate shows in Holds to Pull If marcflavour is set to MARC21, use biblio.copyrightdate. If marcflavour is set to something other than MARC21, use biblioitem.publicationyear. This is to match previous behaviour of this feature. To test: 1) Set your marcflavour system preferenece to MARC21. 2) Go to Administration -> Koha to MARC mapping to confirm what MARC tag maps to biblio.copyrightdate. 3) In your terminal, run misc/batchRebuildBiblioTables.pl from the shell to confirm the mapping is locked. 4) Edit a biblio, fill in whichever field is mapped to biblio.copyrightdate and Save. 5) Place a hold on this biblio. (It must have an available item to allow placing holds.) 6) Go to Circulation -> Holds to Pull. 7) Confirm your hold shows in the table with the copyrightdate. 8) Set your marcflavour system preference to something other thatn MARC21. 9) Go to Administration -> Koha to MARC mapping to confirm what MARC tag maps to biblioitem.publicationyear. 10) In your terminal, run misc/batchRebuildBiblioTables.pl from the shell to confirm the mapping is locked. 11) Edit a biblio, fill in whichever field is mapped to biblioitem.publicationyear and Save. 12) Place a hold on this biblio. (It must have an available item to allow placing holds.) 13) Go to Circulation -> Holds to Pull. 14) Confirm your hold shows in the table with the publicationyear. Sponsored-by: Catalyst IT Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27803 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |joonas.kylmala@helsinki.fi |y.org | --- Comment #4 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- In the commit message it said to modify biblioitem.publicationyear but at least in my koha the field is biblioitems.publicationyear, probably just a typo. Had to also restart plack after changing marcflavour to get the publicationyear to show in holds to pull. Passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27803 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27803 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27803 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 24488 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org