http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13343 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13343 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Items are not embedded when |Items are not embedded when |sending a basket/shelve |sending a basket/shelf -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13343 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13345 See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13345 | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13343 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33952|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 34623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34623&action=edit Bug 13343: Embed items when send a basket/shelf When a basket/shelf is downloaded, items are embedded, but not when sending it by email. We would expect to get the same file. Test plan: On Opac and intranet: 1/ Add records with items to your basket and send it by email. Verify the file contains items. 2/ Add records with items to a list and send it by email. Verify the file contains items. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13343 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34623|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34708&action=edit [PASSED QA] Bug 13343: Embed items when send a basket/shelf When a basket/shelf is downloaded, items are embedded, but not when sending it by email. We would expect to get the same file. Test plan: On Opac and intranet: 1/ Add records with items to your basket and send it by email. Verify the file contains items. 2/ Add records with items to a list and send it by email. Verify the file contains items. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13343 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- yes, we should at least call GetMarcBiblio with the 3rd param set to 1 (opac=1). It is introduced by bug 12252. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13343 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13343 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com Keywords| |rel_3_16_candidate --- Comment #10 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.8r -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13343 --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to Katrin Fischer from comment #5)

A note about this: as things currently are, we will send out information that has been marked as not visible in the OPAC or labelled as internal note. I wonder if we should make including items in the staff/cart optional for the time being as fixing the problem with visibility is a much bigger issue. There has been a discussion about this for OAI as well, but things OPAC side might need a different treatment (bug 12252).

I know this patch just makes things more consistent as one download includes items and the other does not - if people are ok with the idea of optional, I will try to work up a patch on a separate bug - not blocking this.

I'd still like to see this, Koha should be the most privacy conscious library system out there. Let's try to make this our goal. I'd be happy to test and sign off a patch that respects the hidden settings -- You are receiving this mail because: You are watching all bug changes.