https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32800 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 146016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146016&action=edit Bug 32800: Don't embed items for deleted records To test: 1 - Delete a biblio 2 - perl /kohadevbox/koha/misc/migration_tools/build_oai_sets.pl -v -i -r 3 - Error: Can't call method "items" on an undefined value at /kohadevbox/koha/Koha/Biblio/Metadata.pm line 163. 4 - Apply patch 5 - Repeat 6 - Success! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32800 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |magnus@libriotech.no --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- $ git bz apply 32800 Bug 32800 - build_oai_sets.pl fails on deleted records 146016 - Bug 32800: Don't embed items for deleted records Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 32800: Don't embed items for deleted records error: sha1 information is lacking or useless (misc/migration_tools/build_oai_sets.pl). error: could not build fake ancestor Patch failed at 0001 Bug 32800: Don't embed items for deleted records hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-32800-Dont-embed-items-for-deleted-records-PJwYZy.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32800 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146016|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148913&action=edit Bug 32800: Don't embed items for deleted records To test: 1 - Delete a biblio 2 - perl /kohadevbox/koha/misc/migration_tools/build_oai_sets.pl -v -i -r 3 - Error: Can't call method "items" on an undefined value at /kohadevbox/koha/Koha/Biblio/Metadata.pm line 163. 4 - Apply patch 5 - Repeat 6 - Success! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32800 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148913|0 |1 is obsolete| | --- Comment #4 from Magnus Enger <magnus@libriotech.no> --- Created attachment 148914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148914&action=edit Bug 32800: Don't embed items for deleted records To test: 1 - Delete a biblio 2 - perl /kohadevbox/koha/misc/migration_tools/build_oai_sets.pl -v -i -r 3 - Error: Can't call method "items" on an undefined value at /kohadevbox/koha/Koha/Biblio/Metadata.pm line 163. 4 - Apply patch 5 - Repeat 6 - Success! Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32800 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32800 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Also verified that the deleted records are added to the set now correctly and show as "Deleted". -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32800 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32800 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.