[Bug 31057] New: Add clarifying text to 'To Date'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 Bug ID: 31057 Summary: Add clarifying text to 'To Date' Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Holidays Assignee: koha-bugs@lists.koha-community.org Reporter: bwsdonna@gmail.com QA Contact: testopia@bugs.koha-community.org In the Calendar tool it would be helpful to add text to the 'To Date' box indicating that the date only should be entered for holidays on a range. As it is now, if you are entering a single holiday, or holiday repeated weekly, or holiday repeated yearly, the 'To Date' field has no effect, nor is the information entered in the box retained. This is very confusing, especially to new users. I suggest adding 'Only used with holidays on a range' either next to or under the 'To Date' box. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 Eric Rector <erector@ferrum.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |erector@ferrum.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add clarifying text to 'To |Add clarifying text to 'To |Date' |date' in the calendar tool Version|21.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146460&action=edit Bug 31057: Add hint to the 'To date' input on the calendar form Just adding a hint using the 'hint' class didn't work as expected here. The hint was immediately hidden. That is because of the collapsable hint text for the option at the bottom of the form using the [?] link. So I chose to use the class of the [$] to make the script a little more selective. To test: * Go to the calendar tool * Test that the [$] hide/show different help texts * Apply patch * Verify a hint now shows below the "To date" * Verify that the help texts still function as before -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146460|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 146464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146464&action=edit Bug 31057: Add hint to the 'To date' input on the calendar form Just adding a hint using the 'hint' class didn't work as expected here. The hint was immediately hidden. That is because of the collapsable hint text for the option at the bottom of the form using the [?] link. So I chose to use the class of the [$] to make the script a little more selective. To test: * Go to the calendar tool * Test that the [$] hide/show different help texts * Apply patch * Verify a hint now shows below the "To date" * Verify that the help texts still function as before Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thank you, Matt! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- .. all the [$] should be [?] of course... seeing yesterday's typos with freh eyes today -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146464|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 148318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148318&action=edit Bug 31057: Add hint to the 'To date' input on the calendar form Just adding a hint using the 'hint' class didn't work as expected here. The hint was immediately hidden. That is because of the collapsable hint text for the option at the bottom of the form using the [?] link. So I chose to use the class of the [$] to make the script a little more selective. To test: * Go to the calendar tool * Test that the [$] hide/show different help texts * Apply patch * Verify a hint now shows below the "To date" * Verify that the help texts still function as before Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #4)
.. all the [$] should be [?] of course... seeing yesterday's typos with freh eyes today
The description is very obscure. But no problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for QA! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara@ptfs-europe.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 --- Comment #9 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31057 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply clean in 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org