[Bug 24776] New: Remove Borrowers Template Toolkit plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776 Bug ID: 24776 Summary: Remove Borrowers Template Toolkit plugin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Borrowers Template Toolkit plugin contains methods IsDebarred and HasOverdues that can be directly called from Koha::Patron object. Also in template circ/returns.tt, when patron is restricted and checkin was backdated, var "patron" is undefined, should be "issue.patron". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 99921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99921&action=edit Bug 24776: Remove Borrowers.HasOverdues call Borrowers Template Toolkit plugin contains method HasOverdues that can be directly called from Koha::Patron object. Test plan : 1) Go to circulation page of a patron with overdues 2) Click on print button 3) You see "Print overdues" 4) Go to circulation page of a patron without overdues 5) Click on print button 6) You don't see "Print overdues" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 99922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99922&action=edit Bug 24776: Remove Borrowers.IsDebarred call Borrowers Template Toolkit plugin contains method IsDebarred that can be directly called from Koha::Patron object. Also in template circ/returns.tt, when patron is restricted and checkin was backdated, var "patron" is undefined, should be "issue.patron". Test plan : 1) Enable system preference SpecifyReturnDate 2) For a patron without restriction create a checkout 3) Create a manual restriction to debarre patron 4) Go to return page and click on "Checkin settings" 5) Specify a date in the past, barcode and click "Check in" 6) You see message "Jon Doe is restricted. Please verify this patron should still be restricted." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove Borrowers Template |Remove useless Borrowers |Toolkit plugin |Template Toolkit plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776 --- Comment #3 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 99925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99925&action=edit Bug 24776: Remove file Koha/Template/Plugin/Borrowers.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24777 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99921|0 |1 is obsolete| | Attachment #99922|0 |1 is obsolete| | Attachment #99925|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 100411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100411&action=edit Bug 24776: Remove Borrowers.HasOverdues call Borrowers Template Toolkit plugin contains method HasOverdues that can be directly called from Koha::Patron object. Test plan : 1) Go to circulation page of a patron with overdues 2) Click on print button 3) You see "Print overdues" 4) Go to circulation page of a patron without overdues 5) Click on print button 6) You don't see "Print overdues" Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 100412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100412&action=edit Bug 24776: Remove Borrowers.IsDebarred call Borrowers Template Toolkit plugin contains method IsDebarred that can be directly called from Koha::Patron object. Also in template circ/returns.tt, when patron is restricted and checkin was backdated, var "patron" is undefined, should be "issue.patron". Test plan : 1) Enable system preference SpecifyReturnDate 2) For a patron without restriction create a checkout 3) Create a manual restriction to debarre patron 4) Go to return page and click on "Checkin settings" 5) Specify a date in the past, barcode and click "Check in" 6) You see message "Jon Doe is restricted. Please verify this patron should still be restricted." Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 100413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100413&action=edit Bug 24776: Remove file Koha/Template/Plugin/Borrowers.pm Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100411|0 |1 is obsolete| | Attachment #100412|0 |1 is obsolete| | Attachment #100413|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100580&action=edit Bug 24776: Remove Borrowers.HasOverdues call Borrowers Template Toolkit plugin contains method HasOverdues that can be directly called from Koha::Patron object. Test plan : 1) Go to circulation page of a patron with overdues 2) Click on print button 3) You see "Print overdues" 4) Go to circulation page of a patron without overdues 5) Click on print button 6) You don't see "Print overdues" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100581&action=edit Bug 24776: Remove Borrowers.IsDebarred call Borrowers Template Toolkit plugin contains method IsDebarred that can be directly called from Koha::Patron object. Also in template circ/returns.tt, when patron is restricted and checkin was backdated, var "patron" is undefined, should be "issue.patron". Test plan : 1) Enable system preference SpecifyReturnDate 2) For a patron without restriction create a checkout 3) Create a manual restriction to debarre patron 4) Go to return page and click on "Checkin settings" 5) Specify a date in the past, barcode and click "Check in" 6) You see message "Jon Doe is restricted. Please verify this patron should still be restricted." Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100582&action=edit Bug 24776: Remove file Koha/Template/Plugin/Borrowers.pm Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #11 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24776 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org