[Bug 24341] New: Allow for more complex markup in OPAC confirmation dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 Bug ID: 24341 Summary: Allow for more complex markup in OPAC confirmation dialogs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 21870 The confirmation dialogs made possible by Bug 21870 currently use jQuery's text() function to add content to the dialog's body. Using html() instead will allow us to show more than just plain text. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21870 [Bug 21870] Convert browser alerts to modals: OPAC user summary -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 96796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96796&action=edit Bug 24341: Allow for more complex markup in OPAC confirmation dialogs This patch changes the globally-available confirmModal() function in the OPAC so that it uses jQuery's html() function for adding information to the confirmation modal's body. This will allow for more than just plain text to be added. This patch also removes some obsolete lines from the JavaScript in opac-user.tt and renames some variable for clarity. To test, apply the patch log in to the OPAC as a user who has holds and article requests. - Test the following interactions, both the confirmation and cancel options for each: - Cancel a hold - Suspend all holds - Resume all holds - Cancel an article request -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24336 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336 [Bug 24336] Ask for confirmation before deleting a suggestion in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96796|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 97420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97420&action=edit Bug 24341: Allow for more complex markup in OPAC confirmation dialogs This patch changes the globally-available confirmModal() function in the OPAC so that it uses jQuery's html() function for adding information to the confirmation modal's body. This will allow for more than just plain text to be added. This patch also removes some obsolete lines from the JavaScript in opac-user.tt and renames some variable for clarity. To test, apply the patch log in to the OPAC as a user who has holds and article requests. - Test the following interactions, both the confirmation and cancel options for each: - Cancel a hold - Suspend all holds - Resume all holds - Cancel an article request Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |maryse.simard@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Cancelling a hold in the OPAC doesn't ask for confirmation in my testing - can you pleas check? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24433 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433 [Bug 24433] OPAC account page no longer asks for confirmation before deleting hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #3)
Cancelling a hold in the OPAC doesn't ask for confirmation in my testing - can you pleas check?
This is true in master too. I've created Bug 24433 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #4)
(In reply to Katrin Fischer from comment #3)
Cancelling a hold in the OPAC doesn't ask for confirmation in my testing - can you pleas check?
This is true in master too. I've created Bug 24433
Thx Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97420|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 97591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97591&action=edit Bug 24341: Allow for more complex markup in OPAC confirmation dialogs This patch changes the globally-available confirmModal() function in the OPAC so that it uses jQuery's html() function for adding information to the confirmation modal's body. This will allow for more than just plain text to be added. This patch also removes some obsolete lines from the JavaScript in opac-user.tt and renames some variable for clarity. To test, apply the patch log in to the OPAC as a user who has holds and article requests. - Test the following interactions, both the confirmation and cancel options for each: - Cancel a hold - Suspend all holds - Resume all holds - Cancel an article request Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |joy@bywatersolutions.com Resolution|--- |FIXED --- Comment #8 from Joy Nelson <joy@bywatersolutions.com> --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow for more complex |Add support for more |markup in OPAC confirmation |complex markup in OPAC |dialogs |confirmation dialogs CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org