[Bug 21506] New: DataTables four button pagination uses the wrong icon for First and Last buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21506 Bug ID: 21506 Summary: DataTables four button pagination uses the wrong icon for First and Last buttons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: arouss1980@gmail.com QA Contact: testopia@bugs.koha-community.org Created attachment 80154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80154&action=edit wrong icon for First and Last buttons As per the attached screenshot, when four button pagination is used the DataTables buttons for 'First' and 'Last' use the wrong icon. The buttons themselves work fine, it's just that two of the icons are repeated: the same icon is used for 'First'/'Previous' and the same icon is used for 'Next'/'Last'. The icons for 'First' and 'Last' should include a vertical bar, like this: |<< >>|. In addition to the pages shown in the screenshot, other templates appear to be affected as well (`git grep four_button` for a list). AFAICT this was inadvertedly caused by commit 5434882 from Bug 8549 which introduced a change in the class names of the four buttons. Another (minor) issue is that all four buttons' icons are clipped/ truncated at the bottom due to insufficient padding. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21506 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Priority|P5 - low |P3 Assignee|oleonard@myacpl.org |arouss1980@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21506 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21506 --- Comment #1 from Andreas Roussos <arouss1980@gmail.com> --- Created attachment 80155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80155&action=edit Bug 21506: DataTables four button pagination uses the wrong icon for First and Last buttons Pages with DataTables' four button pagination use the wrong icon for 'First' and 'Last'. Also, the icons for all four buttons are truncated at the bottom. This patch fixes that. Test plan: 1) Go to a page that uses four button pagination (e.g. Home > Administration > MARC frameworks) and notice how the pagination icons for First/Previous and Next/Last are the same. Also notice all four icons are clipped at the bottom. 2) Apply the patch. 3) Refresh the page; the First and Last buttons' icons now include a vertical bar, and there is no clipping visible. 4) For completeness, check other affected pages as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21506 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8549 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21506 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21506 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80155|0 |1 is obsolete| | --- Comment #2 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 80161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80161&action=edit Bug 21506: DataTables four button pagination uses the wrong icon for First and Last buttons Pages with DataTables' four button pagination use the wrong icon for 'First' and 'Last'. Also, the icons for all four buttons are truncated at the bottom. This patch fixes that. Test plan: 1) Go to a page that uses four button pagination (e.g. Home > Administration > MARC frameworks) and notice how the pagination icons for First/Previous and Next/Last are the same. Also notice all four icons are clipped at the bottom. 2) Apply the patch. 3) Refresh the page; the First and Last buttons' icons now include a vertical bar, and there is no clipping visible. 4) For completeness, check other affected pages as well. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21506 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #3 from Séverine Queune <severine.queune@bulac.fr> --- Nice catch ! Works fine for the 4 pages on the attached screenshot. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21506 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80161|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 80222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80222&action=edit Bug 21506: DataTables four button pagination uses the wrong icon for First and Last buttons Pages with DataTables' four button pagination use the wrong icon for 'First' and 'Last'. Also, the icons for all four buttons are truncated at the bottom. This patch fixes that. Test plan: 1) Go to a page that uses four button pagination (e.g. Home > Administration > MARC frameworks) and notice how the pagination icons for First/Previous and Next/Last are the same. Also notice all four icons are clipped at the bottom. 2) Apply the patch. 3) Refresh the page; the First and Last buttons' icons now include a vertical bar, and there is no clipping visible. 4) For completeness, check other affected pages as well. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21506 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected, code is reasonable and I've not spotted anywhere it's not applying (shared library code). Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21506 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21506 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21550 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21550 [Bug 21550] DataTables four button pagination uses the wrong icon for disabled buttons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21506 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21506 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21506 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org