[Bug 21550] New: DataTables four button pagination uses the wrong icon for disabled buttons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21550 Bug ID: 21550 Summary: DataTables four button pagination uses the wrong icon for disabled buttons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P3 Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: arouss1980@gmail.com, martin.renvoize@ptfs-europe.com, nick@bywatersolutions.com, severine.queune@bulac.fr, testopia@bugs.koha-community.org Depends on: 21506 When four button pagination is used any button which is disabled uses the icon for active buttons. For instance: The "next" button on the last page of results. The arrow icon should be gray instead of blue. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21506 [Bug 21506] DataTables four button pagination uses the wrong icon for First and Last buttons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21550 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21550 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 80413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80413&action=edit Bug 21550: DataTables four button pagination uses the wrong icon for disabled buttons This patch modifies the DataTables CSS which styles "full_nubmers" controls which are disabled: First and Previous buttons on the first page of results, Next and Last buttons on the last page of results. These buttons should have gray icons instead of blue. To test, apply the patch and clear your browser cache if necessary. View a page which uses a "full_numbers" DataTables configuration, e.g. - Administration -> Cities - ILL requests -> List requests - Circulation -> Holds to pull Confirm that buttons in their disabled state have a gray icon and text instead of blue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21550 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21550 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80413|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 80444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80444&action=edit Bug 21550: DataTables four button pagination uses the wrong icon for disabled buttons This patch modifies the DataTables CSS which styles "full_nubmers" controls which are disabled: First and Previous buttons on the first page of results, Next and Last buttons on the last page of results. These buttons should have gray icons instead of blue. To test, apply the patch and clear your browser cache if necessary. View a page which uses a "full_numbers" DataTables configuration, e.g. - Administration -> Cities - ILL requests -> List requests - Circulation -> Holds to pull Confirm that buttons in their disabled state have a gray icon and text instead of blue. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80444|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80445&action=edit Bug 21550: DataTables four button pagination uses the wrong icon for disabled buttons This patch modifies the DataTables CSS which styles "full_nubmers" controls which are disabled: First and Previous buttons on the first page of results, Next and Last buttons on the last page of results. These buttons should have gray icons instead of blue. To test, apply the patch and clear your browser cache if necessary. View a page which uses a "full_numbers" DataTables configuration, e.g. - Administration -> Cities - ILL requests -> List requests - Circulation -> Holds to pull Confirm that buttons in their disabled state have a gray icon and text instead of blue. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21550 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21550 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21550 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21550 Bug 21550 depends on bug 21506, which changed state. Bug 21506 Summary: DataTables four button pagination uses the wrong icon for First and Last buttons https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21506 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21550 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org