https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17436 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17436 [Bug 17436] Add a way to know in patron module where renew of an item was made -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #2 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 94395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94395&action=edit Bug 23838: Add renewals modal This patch adds the display of the renewals modal when appropriate. A "View" link is displayed next to renewals that have logs associated with them. Clicking the link opens the modal that displays the logged renewals. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94395|0 |1 is obsolete| | --- Comment #6 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- Created attachment 94636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94636&action=edit Bug 23838: Add renewals modal This patch adds the display of the renewals modal when appropriate. A "View" link is displayed next to renewals that have logs associated with them. Clicking the link opens the modal that displays the logged renewals. Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> https://bugs.koha-community.org/show_bug.cgi?id=23392 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #8 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 94663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94663&action=edit Bug 23838: (follow-up) Fix QA tool failures Remove those pesky tabs as requested by Owen in comment #7 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #11 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 94676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94676&action=edit Bug 23838: (follow-up) Rephrase log message As suggested by Owen in comment #10 Thanks Owen, I went for the second option -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94635|0 |1 is obsolete| | Attachment #94636|0 |1 is obsolete| | Attachment #94663|0 |1 is obsolete| | Attachment #94664|0 |1 is obsolete| | Attachment #94676|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 94681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94681&action=edit Bug 23838: Add 'renewals' API route This patch adds a /patrons/x/renewals API GET route which returns a patron's renewals, optionally filtered by item_id. Tests are also included Sponsored-by: Loughborough University Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 94683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94683&action=edit Bug 23838: (follow-up) Fix QA tool failures Remove those pesky tabs as requested by Owen in comment #7 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 94685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94685&action=edit Bug 23838: (follow-up) Rephrase log message As suggested by Owen in comment #10 Thanks Owen, I went for the second option Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Bouzid Fergani <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94682|0 |1 is obsolete| | --- Comment #18 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Created attachment 95467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95467&action=edit Bug 23838: Add renewals modal This patch adds the display of the renewals modal when appropriate. A "View" link is displayed next to renewals that have logs associated with them. Clicking the link opens the modal that displays the logged renewals. Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Bouzid Fergani <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94684|0 |1 is obsolete| | --- Comment #20 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Created attachment 95469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95469&action=edit Bug 23838: (follow-up) Fix JS strings As requested by Owen in comment #7 Owen, I have modified the "x out y renewals have been logged" formation as you suggested. The "Renewed on x by y" string is harder because it contains markup and I suspected the strings file should contain such things. I have however very slightly reworded it which will hopefully mean it's structure is suitable for other languages too. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #22 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Created attachment 95471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95471&action=edit Bug 17374: (follow-up) Unit tests and remove warns Signed-off-by: Maxime Dufresne <maxime.dufresne@inlibro.com> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #24 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Hi Bouzid I think when you attached your sign off patches to this bug, you accidentally attached an unrelated patch to the end. If this is correct, could you please obsolete it? Many thanks Andrew -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95471|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95466|0 |1 is obsolete| | --- Comment #26 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 96186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96186&action=edit Bug 23838: Add 'renewals' API route This patch adds a /patrons/x/renewals API GET route which returns a patron's renewals, optionally filtered by item_id. Tests are also included Sponsored-by: Loughborough University Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> Signed-off-by: Ben Veasey <B.T.Veasey@lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95468|0 |1 is obsolete| | --- Comment #28 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 96188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96188&action=edit Bug 23838: (follow-up) Fix QA tool failures Remove those pesky tabs as requested by Owen in comment #7 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> Signed-off-by: Ben Veasey <B.T.Veasey@lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95470|0 |1 is obsolete| | --- Comment #30 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 96190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96190&action=edit Bug 23838: (follow-up) Rephrase log message As suggested by Owen in comment #10 Thanks Owen, I went for the second option Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> Signed-off-by: Ben Veasey <B.T.Veasey@lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #32 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Hi Tomás I'm not sure what you mean when you say "putting the mapping on the Koha::Object level", could you please elaborate? Do you mean add a "to_api" method into the Koha::ActionLog object rather than having it in Koha/REST/V1/Patrons/Renewals.pm Thanks, Andrew -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #34 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #33)

+ $('#patronRenewals #incomplete').append(note + ': ' + data.length + ' ' + out_of + ' ' + renewals + ' ' + renewals_logged).show();

To make this correctly translatable you should use the .format() JS function.

Hi Jonathan This was addressed in this follow up patch https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96189&action=diff Did you not have all patches applied when you looked at this? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I started to test these and to code review and there are some points I have been wondering: 1) Patron (membership) renewal vs. checkouts renewal There is a strong pattern in the patches, file names, the API path of patron-renewals. Tbh, I wonder if this is not misleading. I'd expect something to do with membership renewals for patrons here. I wonder if we should add the checkout aspect here. 2) REST API This adds a new route to our REST API: /patrons/{patron_id}/renewals But it doesn't appear to have an RFC and has not been voted on yet. If you could write something up, we could maybe fast track at in the meeting this Wednesday: https://wiki.koha-community.org/wiki/REST_api_RFCs Because of one, maybe this would be better: GET /patrons/{patron_id}/checkouts/{checkout_id}/renewals 3) Database structure / tables So far we have pulled statistics related data form issues, old_issues and statistics, which also logs renewals. I think the action_logs was mostly used for the log viewer (hope I didn't miss something). So deleting the action_logs, didn't have much consequence. I am worried, that libraries haven't kept the data in the action_logs so this won't work as expected. Since a long time, we have an option in the cleanup_database.pl script to delete log entries older than x days. Is there a strong reason to favor action_logs over statistics here? In 20.05 we will also have an option for old_issues and statistics. Tbh - I would not recommend a library using either of these as they delete and you lose valueable data about the use of your collection. It will kill your reading histories, I'd always prefer anonymizing, but we don't have that option yet in the cleanup scripts. I think some strong warning notes about consequences should be the least we do. I know our database situation here is less than ideal. :( If I am correct we are missing the issue_id in both tables? 4) Wrong data showing The scenario (very likely in a lot of our libraries with course books especially): 1) Patron A checks out the book 2) Renewals take place until no more renewals are allowed 3) Patron A returns the book and checks it out again immediately 4) More renewals take place In my testing after 2) I had 3 renewals showing in the table, when I click on Details 2 showed. This was due to me turning on RenewalLog too late (so ok) But after 4) I have the same information show on both entries. 3 renewals = 2 renewals logged on 2020-05-14 1 renewal = 2 renwals logged on 2020-05-15 This leads me to believe that this can't deal with multiple checkouts of the same item. 5) QA script Only 2 very minor problems, probably caused by clean-up since these patches were written: FAIL t/db_dependent/api/v1/patrons_renewals.t OK critic FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545). (line 16) FAIL Koha/REST/V1/Patrons/Renewals.pm OK critic FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545). (line 16) Failing for 4) and 5) (would have fixed 5) in QA, but needs more work). 1) should be resolved as well to our agreed workflow. 2) and 3) I hope to discuss, maybe get more opinions on. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_candidate |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #38 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #36) 1 & 2)

There is a strong pattern in the patches, file names, the API path of patron-renewals. Tbh, I wonder if this is not misleading. I'd expect something to do with membership renewals for patrons here. I wonder if we should add the checkout aspect here.

I agree it could be misleading. I think your suggestion of an alternative API route makes sense. Looking at the spec I created, I had the patron_id as an optional parameter, though I'm not sure that makes sense, I can't think of any case where you'd want to retrieve *all* a patron's renewals. I'm going to retain the "embed" optional parameter as I do think this is useful. So, to summarise, I'll change the route to: GET /patrons/{patron_id}/checkouts/{checkout_id}/renewals(?embed=patron,renewed_by) 3) Is there a strong reason to favor action_logs over statistics here? Statistics doesn't store the identity of who performed the renewal, which was a key requirement for our customer. There is no reliable way of obtaining that information, hence the use of action_logs which, I agree, are not an ideal solution for the reasons you mention. I'm not sure how reasonable it would be to add a, perhaps, "operator" column to statistics, which would enable us to record the renewing staff member. I'm not really familiar with the purpose of the statistics table, but it looks pretty multipurpose, so adding a column of this nature may not be appropriate. 4)

But after 4) I have the same information show on both entries. 3 renewals = 2 renewals logged on 2020-05-14 1 renewal = 2 renwals logged on 2020-05-15

This leads me to believe that this can't deal with multiple checkouts of the same item.

This seems to be a bug. Currently the API call just gets all renewals for a specific patron / item combination, hence the result you're seeing. We could pass the appropriate issue ID to the modal, which would enable it to get just the renewals for that specific issue. However, the issue ID is not recorded in entries made in the action_logs, so we'd have to add that. Or, assuming, we decide to stop using action_logs, it would need to be added whereever we record it. 5) OK, thanks, I'll fix those. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, for the API it might be good to get opinions of people more familiar with it. I can see the issue about statistics and action_logs not having all the information we need. :( I would not be opposed to improve the tables in a way that allows us to link it reliably. The issue_id is not that old (given the age of Koha), so maybe that's the main reason we haven't been logging it? It seems the way that things are we will keep "guessing" to some extend as not even the timestamp could be slightly different on action_logs and lastrenewed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #42 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- (In reply to Tomás Cohen Arazi from comment #41)

We should add something like:

parent_issue_id is_renewal

to the issues table.

OK, this makes sense, I'll take this approach

And then make /checkouts/:checkout_id/renewals return, well, the renewals.

OK

I wouldn't oppose to an intermediate solution 'in the meantime' but it is not clear the data is good enough to make the route reliable right now.

I think it would be better to do this properly now. Clearly historical renewals won't be populated fully, but that's unavoidable and will improve over time. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---

We should add something like:

parent_issue_id is_renewal

to the issues table.

And then make /checkouts/:checkout_id/renewals return, well, the renewals. I wouldn't oppose to an intermediate solution 'in the meantime' but it is not clear the data is good enough to make the route reliable right now.

Which table to you intend to add this to? If you meant issues I am not sure if I like it. It would mean adding a new line for every renewal... once again throwing off all reports people may have written on these tables. I'd like it better if we could 'pimp' statistics to work in the indended way. I could imagine adding a 'issue_id' column there. then we have the entries for issue, return, renew that make it clear what was done. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #46 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Andrew Isherwood from comment #43)

(In reply to Tomás Cohen Arazi from comment #41)

...

We should add something like:

parent_issue_id is_renewal

to the issues table.

Actually, thinking about this, I'm not sure the is_renewal flag is necessary, surely the fact that it's a renewal can be inferred from a populated parent_issue_id column? I may be missing something in your reasoning though! :)

TBH, my original thinking was we needed a 'checkout_type' or similar field, in which we put 'renewal' (there's already an 'onsite' flag that would be moved there). But thought it was simpler to write is_renewal to make a point. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'd really like to see this one move forward, but I haven't been able to come up with a good suggestion yet. My impression is that if the same person checks out the same item multiple times, which might happen easily depending on library rules (in some you will have to bring in the item before you can then renew it again), things will get really messed up. I think we should move the discussion on how to link issues and renewals reliably onto a different bug by now and link this one to it? So far we've discussed: 1 Adding the issue_id to statistics and/or action logs 2 Adding a new table for renewals 3 Treating renewals as new entries to the issues table I am more keen on 1 or 2 at the moment as 3 would be a huge change and I think easier and better solutions can be found. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #49)

Assuming I'm reading this right, I think an minimal version 2 option would be the best route to goal.. a simple 'renewals' table with just 'issue_id' and 'timestamp' required really.. all other details can still come from the issues table directly... or are there other details we would want to record like 'type' to denote autorenewals vs manual ones, and interface to denote a staff client renewal vs an online/opac renewal?... Either way, I think we should record the minimum in the 'renewals' table and rely on the issues table link to fill out the rest of the details we may need.

In statistics or action_logs (sorry, I didn't check that) we also record: - where the renewal has taken place (branch) - what type of renewal it was (opac, staff, etc.) - for this bug: who did the renewal - in the future: seen or unseen? A lot of this information we have already, but the reliable link (issue_id) is missing. I am still wondering if not adding the issue_id to the statistics/action_logs tables would be a good way to handle this as otherwise we do end up with a lot of duplicate data that then has to be anonymized etc. again. Also: do we need an old_renewals then as well? (what happens when the items are returned? we want to keep the history) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30275 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 [Bug 30275] Checkout renewals should be stored in their own table -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96187|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131892&action=edit Bug 23838: Add renewals modal This patch adds the display of the renewals modal when appropriate. A "View" link is displayed next to renewals count where appropriate. Clicking the link opens the modal that displays the logged renewals. Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> Signed-off-by: Ben Veasey <B.T.Veasey@lboro.ac.uk> Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> I rescued this patchset by squashing previous work and updating it to utilise the new renewals API routes introduced in bug 30275. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96188|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96190|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #53 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, I squashed the existing patches and reworked them slightly to use the new API's introduced in bug 30275 to try and get this one moving again. Keeping the signoff as the feature continue to work as it did in my testing, but it worth a refreshed round of QA at this point. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #55 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131915&action=edit Bug 23838: Use $datetime formater -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #57 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Andrew Fuerste-Henry from comment #56)

I applied this and 30275 and tried to run through the test plan here. I'm not getting a View button next to the renewal count in patron Circulation History even when the Renewal Log is enabled and there are renewals in the action_logs for the checkout. Is there something else I should be doing to get it to show?

Setting to FQA to get attention on this. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131914|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 133945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133945&action=edit Bug 23838: Add renewals modal This patch adds the display of the renewals modal when appropriate. A "View" link is displayed next to renewals count where appropriate. Clicking the link opens the modal that displays the logged renewals. Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> Signed-off-by: Ben Veasey <B.T.Veasey@lboro.ac.uk> Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> I rescued this patchset by squashing previous work and updating it to utilise the new renewals API routes introduced in bug 30275. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #62 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 133967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133967&action=edit Bug 23838: Use $datetime formater -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #64 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Note to self, must add 'Sponsored-by: Loughborough University' line back into patches -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133967|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134891&action=edit Bug 23838: Use $datetime formater Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #68 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Added sponsorship line to attribute original sponsor of the feature from long long ago.. and rebased ;) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen@gmail.com |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134891|0 |1 is obsolete| | --- Comment #70 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137168&action=edit Bug 23838: Use $datetime formater Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #72 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased now that the dependency bug has been pushed :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #73 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Overall, this works really well, but I found a small display glitch: If the user (in my case it was 42) has no first name, the display is: 22.07.2022 09:25 Renewed by null koha Possibly the same issue arises if there is no surname. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137167|0 |1 is obsolete| | --- Comment #75 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138019&action=edit Bug 23838: Add renewals modal This patch adds the display of the renewals modal when appropriate. A "View" link is displayed next to renewals count where appropriate. Clicking the link opens the modal that displays the logged renewals. Sponsored-by: Loughborough University Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com> Signed-off-by: Ben Veasey <B.T.Veasey@lboro.ac.uk> Rescued-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> I rescued this patchset by squashing previous work and updating it to utilise the new renewals API routes introduced in bug 30275. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137169|0 |1 is obsolete| | --- Comment #77 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138021&action=edit Bug 23838: (follow-up) Add missing template filter Quieting an issue highlighted by the QA tool. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #79 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 138039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138039&action=edit Bug 23838: (QA follow-up) Rename patron-renewal => checkout-renewal Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138039|0 |1 is obsolete| | --- Comment #81 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 138041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138041&action=edit Bug 23838: (QA follow-up) Rename patron-renewal => checkout-renewal Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #84 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 138043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138043&action=edit Bug 23838: (QA follow-up) Move include files As talked with Martin, this patches were originally developed before we added the modals/ and str/ dirs, but we need to align it with current way of doing it. This patch does that. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Bug 23838 depends on bug 30275, which changed state. Bug 30275 Summary: Checkout renewals should be stored in their own table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds a |This enhancement adds a release notes|modal to display checkout |modal to display checkout |renewal history details. |renewal history details | |where appropriate. This | |includes the circulation | |history and the items tab | |of the staff detail page. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |CLOSED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/605 --- Comment #86 from Aude Charillon <aude.charillon@ptfs-europe.com> --- Manual updated. -- You are receiving this mail because: You are watching all bug changes.