https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- I see a couple of issues with this: - QA tool failures: tab characters - I think the way the translatable strings is handled isn't correct. Separating each little piece of a sentence isn't going to work for a lot of languages, so placeholders should be used instead. https://wiki.koha-community.org/wiki/Coding_Guidelines#JS4:_Use_the_format.2... So something like this in the strings include: var msg = _("Note: %s out of %s renewals have been logged"); And in the JS: msg.format( data.length, renewals ) -- You are receiving this mail because: You are watching all bug changes.