[Bug 5729] New: Add coins information to the intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5729 Summary: Add coins information to the intranet Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Staff Client AssignedTo: paul.poulain@biblibre.com ReportedBy: chris@bigballofwax.co.nz QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Estimated Hours: 0.0 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5729 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-02-10 01:23:03 UTC --- Created attachment 3117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3117 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5729 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5729 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-02-17 19:07:06 UTC --- Chris, Does this mean that Zotero will work in the staff client? Is there anything else it can do? Just checking before I test to see what I'm looking for. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5729 --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2011-03-01 22:11:01 UTC --- Nicole, yes it makes coinS work on staff interface -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5729 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Patch Status|Needs Signoff |Does not apply --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2011-03-03 23:59:18 UTC --- I dont think this patch applied. I didn't see any change in the staff client and I got this when I tried to apply the patch: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 5729 : Add Coins support to intranet Using index info to reconstruct a base tree... <stdin>:65: trailing whitespace. { # <stdin>:93: trailing whitespace. <!-- /TMPL_IF --> <stdin>:117: trailing whitespace. display: block; <stdin>:132: trailing whitespace. <!-- /TMPL_IF --> <stdin>:150: trailing whitespace. , entries/page : warning: squelched 3 whitespace errors warning: 8 lines add whitespace errors. Falling back to patching base and 3-way merge... Auto-merging catalogue/MARCdetail.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tmpl nengard@debian:~/kohaclone$ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5729 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2011-03-04 01:40:27 UTC --- As long as git doesn't ask you to resolve a conflict and it doesn't tell you explicitly the patch failed then I think you can assume the patch was applied. Whether or not a patch does anything is another matter :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5729 --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2011-03-04 03:16:13 UTC --- Okay then, I applied the patch and when I did a search I didn't see my usual Zotero icon in the address bar that indicates that CoinS is working. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5729 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Failed QA --- Comment #7 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-03-06 12:09:53 UTC --- This bug is mentioned in: Bug 5729 : Add Coins support to intranet http://lists.koha-community.org/pipermail/koha-patches/2011-February/013811.... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5729 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3117|0 |1 is obsolete| | --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> 2011-09-09 10:00:00 UTC --- Created attachment 5379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5379 proposed patch New patch, completly rewritten : * all code not related to Adding CoinS has been removed * T::T compliant How to test : * add zotero to your firefox * open a biblio in staff interface (default, marc or isbd view) => you should get the zotero icon in your firefox toolbar (if your biblio is correct of course. If you get it in OPAC, you must have it in staff to) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5729 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5729 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #9 from Frédéric Demians <frederic@tamil.fr> 2011-09-09 15:45:32 UTC --- (In reply to comment #8)
Created attachment 5379 [details] proposed patch
New patch, completly rewritten : * all code not related to Adding CoinS has been removed * T::T compliant
There is syspref COinSinOPACResults controling if COinS tag is displayed or not on OPAC search result page. This is a recent enhencement: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5957 This has been added for efficiency reason. Shouldn't we use a similar syspref for staff interface? or better: the function generating COinS could be improved... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5729 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5957 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5729 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> 2011-09-27 16:36:08 UTC --- Created attachment 5610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5610 Bug 5729 - Add CoinS to intranet This patch adds CoinS support to biblio displays in staff interface. librarians can now use zotero on the staff interface -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5729 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5379|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5729 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Depends on| |7073 --- Comment #11 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-20 20:13:04 UTC --- Adding dependence on 7073, which changes the parameters required by GetCOinSBiblio from biblionumber to GetMarcBiblio-sourced $record -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5729 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |Rel_3_8 --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-24 11:38:12 UTC --- Updating Version : This ENH will be for Koha 3.8 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5729 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Rel_3_8 |master --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-25 15:05:45 UTC --- Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5729 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5610|0 |1 is obsolete| | --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-15 00:49:24 UTC --- Created attachment 6796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6796 Bug 5729 - Add CoinS to intranet This patch adds CoinS support to biblio displays in staff interface. librarians can now use zotero on the staff interface Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5729 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5729 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6796|0 |1 is obsolete| | --- Comment #15 from Ian Walls <ian.walls@bywatersolutions.com> 2011-12-21 23:02:40 UTC --- Created attachment 6914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6914 Rebased/Passed QA patch Passed QA patch, with reflection of the new GetCOinSBiblio interface (uses $record now, not $biblionumber, for increased efficiency on most pages). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5729 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5729 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed --- Comment #16 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-27 17:37:48 UTC --- patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5729 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer@bsz-bw.de -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5729 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org