[Bug 8027] New: Wrong order for parameters in Z39.50 SQL INSERT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8027 Priority: P5 - low Change sponsored?: --- Bug ID: 8027 Assignee: adrien.saurat@biblibre.com Summary: Wrong order for parameters in Z39.50 SQL INSERT Severity: normal Classification: Unclassified OS: All Reporter: adrien.saurat@biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Z39.50 / SRU / OpenSearch Servers Product: Koha In the z3950servers.pl page, the INSERT for new servers is prepared like this : =================================== INSERT INTO z3950servers (host,port,db,userid,password,name,checked,rank,syntax,encoding,timeout) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) =================================== but then executed like this : =================================== $sth->execute( $input->param( 'host' ), $input->param( 'port' ), $input->param( 'db' ), $input->param( 'userid' ), $input->param( 'password' ), $input->param( 'searchfield' ), $checked, $input->param( 'rank' ), $input->param( 'syntax' ), $input->param( 'timeout' ), $input->param( 'encoding' ) ); } =================================== The last parameters, timeout and encoding, are not in the same order. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8027 --- Comment #1 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Created attachment 9364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9364&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8027 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8027 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9364|0 |1 is obsolete| | --- Comment #2 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 9365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9365&action=edit Bug 8027: fix param order for z3950 INSERT In the z3950servers.pl order of columns which are inserted for new server is wrong, which results in empty timeout and encoding values when new server is added. Test scenario: 1. Open Z39.50 server administration 2. add new server with encoding and timeout 3. save server and verify that it has encoding and timeout Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8027 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin@rot13.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8027 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Dobrica Pavlinusic <dpavlin@rot13.org> --- I added test scenario and fixed bug number in commit message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8027 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #4 from Ian Walls <koha.sekjal@gmail.com> --- Switches the params to match the order of the INSERT statement. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8027 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8027 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8027 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org